From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f50.google.com (mail-dl1-f50.google.com [74.125.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65FF93B6371 for ; Tue, 31 Mar 2026 20:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774989582; cv=none; b=jL1a8eyI5iCEzdLYquuCRgu2XSUbCfhmKqgDooaj5goBboU6HjYDzHSZjm8J8xEx87ywIBzAvJ/2SBJp8er4M2yimx2f6AWqTym2B9T2ZJdZ72e1liPXCxyotBA26yalPcPE/MER6JZsv0sEQUyiVlMLKbGtkrTZvt0Kc5TMznU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774989582; c=relaxed/simple; bh=HP1NLiOIWXUdUXadhKy3DijqQs/PEm5plRHuOWWD/BE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s5eq3wKOPpj91TrQUGQ3vlSJubcpyxwOAcmCNG4QB6lgAmmIyDP/uo5a8DR0KzfMlfw2V6A+kPW7o/j+gMfvvsxhJsY7gxWfUA64FET566FcSV/KFgVSiWTsOj/qx0DnO8UE/hyGeeMubd4h1uGrM3VVp85IrrWkkoo3oHCpWKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DPBpTV4h; arc=none smtp.client-ip=74.125.82.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DPBpTV4h" Received: by mail-dl1-f50.google.com with SMTP id a92af1059eb24-12a74039dc6so4974526c88.0 for ; Tue, 31 Mar 2026 13:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774989579; x=1775594379; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZRCQMa9zMGlvIHkM8ghTZ/x9mDeTjIV8vVymtj5kVU4=; b=DPBpTV4h5w2BFiOw69qC+snsZ6UIPwzQUE28J8UvFype6PVntmyF2izsLsD3mVkNpo hEX0V2St3RZ/fo7/DNSHVdP/nRF2pDhUmS82K+mOK0dKLWg0ZEy1SHHW/KYikQ6jlmg+ /QRCmbdxAr0z30oIdubZGSvnCXv5vPZiAGAtiIx50CcbCaB5Btz2XYpoebS2eGo1nAtX JzST46OlyDicpt9dwVPP7+vuVa4HMyPUXC+3QyUTgQeBHwd89ewVamIHDySTBvH3i+Kx puL+W9SyIIYqID6hvy2VtRKnfNMKP0CUzKemuiDoGSRs3jWdKjyStdNPB0ufQutwUP4S iufQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774989579; x=1775594379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZRCQMa9zMGlvIHkM8ghTZ/x9mDeTjIV8vVymtj5kVU4=; b=WHgp+hc20dwIaNw8dh+OE3dQ/f2i3FVKpmVPe5dC1EMPaUA1XvTiIte/Zxq/zseveX Y1rq97++z/JBLb6Ss9Y6uzj6mUMBlBPhMUqRrQe0Fhcw8D+ghN3XLMWL+XiFSMzUHkx2 FGE8R3pqtqOJajTrhuyKExipOfM83rxnxoW3GHE3EKOgdgs6doIZdGYsH51DlM5QNuWu VAMuuf+4loN4xQ+YmKRoKTjJiYWcTFO4hUml/AJ+ZOW0nu3jUBR7NWDHLlPQzmOU8E0d kVScOpGqDe1/B/68egIn8d/Qw79JB+uHObkKSKT6tF5ljpXDXhk5aX9ipIgaFv0EFMAY GhNA== X-Forwarded-Encrypted: i=1; AJvYcCWFOwnxzRV5yrySOEJ9VTa2g1IXnQqjPZ/Atn4lynN3ZNIzpi3XNDKIEQpJW+vd5RWR3KZbX8F4h9W1uuA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0sHpbhvZhoM0XREYU4OIkPqv8cP40s5FHGErK3un50TI89BtK H7Ju8fEpa2IsE6k8JG/ZaqV+liHE1It1QzKIac4nbirxf78Ri5gFhCSF/XxH5l3V8g== X-Gm-Gg: ATEYQzxjQ63KrUhtYC4qf7vclcxxfWDJlzs5HNXAXMm8DvreDbxor7hl95n14olrt+y M+U7C2ZrtnOwUkKx/J1dCtxEVwSCkeMwJq/8YOmWY7ye3cDD4gZuIzGxFA9V5eNBi8fVD5pkacP SimLoNO+FdshiIYsoLkTwC0qiza4sscJ2t07wE7xq3WwC+ioFI1JoPsCZTGsmtjt1fS3sQQ1p41 68lYe/b5eiq1Jdjv3JW1fVdBDZvTM4vXwPbOmvNHBGfqwb3abKKoOyd419cyyg4mC1ZhAMlDEqc sTlwNVKEKC0aCz7L935KcFVjqWY7W6JNqPs1gE44ks7xmDOwkDm87rbZ8RIqK+WFfNKZRKRl0p+ JK+6YcxktA2yXsgFaNP3NZQD2M8lQQdvrLXv0U8px+Lr/xT4XkJx6zrqji+N+QeWETn3BrtxppO hFmudu3HIxLThxk0IuXOvXBw/TzVDa3NtSJO7UpF5iSn6ZxyIkB7EEHT+e7Zgj5hjfwbo2x4lGI Tb2VdTcd8vBb1GeeDJgdMjNsw== X-Received: by 2002:a05:7022:41aa:b0:128:d494:a1ab with SMTP id a92af1059eb24-12be649eb12mr512442c88.15.1774989578723; Tue, 31 Mar 2026 13:39:38 -0700 (PDT) Received: from ?IPV6:2a00:79e0:2e7c:8:6a92:85c3:5cd5:d23d? ([2a00:79e0:2e7c:8:6a92:85c3:5cd5:d23d]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12ab983f9f3sm16792226c88.10.2026.03.31.13.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 13:39:38 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 13:39:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 3/6] mfd: max77759: add register bitmasks and modify irq configs for charger To: Lee Jones Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar , Mark Brown , Matti Vaittinen , Andrew Morton , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso References: <20260325-max77759-charger-v9-0-4486dd297adc@google.com> <20260325-max77759-charger-v9-3-4486dd297adc@google.com> <20260331123138.GE3795166@google.com> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: <20260331123138.GE3795166@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Lee, On 3/31/26 5:31 AM, Lee Jones wrote: > On Wed, 25 Mar 2026, Amit Sunil Dhamne via B4 Relay wrote: > >> From: Amit Sunil Dhamne >> >> Add register bitmasks for charger function. >> In addition split the charger IRQs further such that each bit represents >> an IRQ downstream of charger regmap irq chip. In addition populate the >> ack_base to offload irq ack to the regmap irq chip framework. >> >> Signed-off-by: Amit Sunil Dhamne >> Reviewed-by: André Draszik >> --- >> drivers/mfd/max77759.c | 95 ++++++++++++++++++++++--- >> include/linux/mfd/max77759.h | 166 +++++++++++++++++++++++++++++++++++-------- >> 2 files changed, 222 insertions(+), 39 deletions(-) >> > [...] > >> +/* >> + * enum max77759_chgr_chgin_dtls_status - Charger Input Status >> + * @MAX77759_CHGR_CHGIN_DTLS_VBUS_UNDERVOLTAGE: >> + * Charger input voltage (Vchgin) < Under Voltage Threshold (Vuvlo) >> + * @MAX77759_CHGR_CHGIN_DTLS_VBUS_MARGINAL_VOLTAGE: Vchgin > Vuvlo and >> + * Vchgin < (Battery Voltage (Vbatt) + system voltage (Vsys)) >> + * @MAX77759_CHGR_CHGIN_DTLS_VBUS_OVERVOLTAGE: >> + * Vchgin > Over Voltage threshold (Vovlo) >> + * @MAX77759_CHGR_CHGIN_DTLS_VBUS_VALID: >> + * Vchgin > Vuvlo, Vchgin < Vovlo and Vchgin > (Vsys + Vbatt) >> + */ > This comment is masquerading as a kernel-doc header, but isn't actually > kernel-doc. Either change the formatting or adapt the formatting to use > /** and use W=1 to check it. Thanks for pointing this out! I'll fix this in the next version and ensure it's a proper kernel-doc block. BR, Amit >> +enum max77759_chgr_chgin_dtls_status { >> + MAX77759_CHGR_CHGIN_DTLS_VBUS_UNDERVOLTAGE, >> + MAX77759_CHGR_CHGIN_DTLS_VBUS_MARGINAL_VOLTAGE, >> + MAX77759_CHGR_CHGIN_DTLS_VBUS_OVERVOLTAGE, >> + MAX77759_CHGR_CHGIN_DTLS_VBUS_VALID, >> +};