From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BA4DC19F29 for ; Thu, 28 Jul 2022 09:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235338AbiG1JuE (ORCPT ); Thu, 28 Jul 2022 05:50:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233296AbiG1JuC (ORCPT ); Thu, 28 Jul 2022 05:50:02 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FEBC65D4D; Thu, 28 Jul 2022 02:50:01 -0700 (PDT) Received: from [10.88.19.200] (10.88.19.200) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server id 15.1.2176.2; Thu, 28 Jul 2022 17:49:58 +0800 Message-ID: Date: Thu, 28 Jul 2022 17:50:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v2 4/4] dt-binding: perf: Add Amlogic DDR PMU Content-Language: en-US To: Krzysztof Kozlowski , , , , CC: Rob Herring , Krzysztof Kozlowski , Will Deacon , Mark Rutland , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Chris Healy References: <20220726230329.2844101-1-jiucheng.xu@amlogic.com> <20220726230329.2844101-4-jiucheng.xu@amlogic.com> From: Jiucheng Xu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.88.19.200] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/27 15:09, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On 27/07/2022 01:03, Jiucheng Xu wrote: >> Add binding documentation for the Amlogic G12 series DDR >> performance monitor unit. >> >> Signed-off-by: Jiucheng Xu >> --- >> Changes v1 -> v2: >> - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml >> - Delete "model", "dmc_nr", "chann_nr" new properties >> - Fix compiling error >> --- >> .../bindings/perf/amlogic,g12_ddr_pmu.yaml | 45 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > >> diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >> new file mode 100644 >> index 000000000000..46ef52b61492 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >> @@ -0,0 +1,45 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic G12 DDR performance monitor >> + >> +maintainers: >> + - Jiucheng Xu >> + >> +properties: >> + compatible: >> + oneOf: > That's not oneOf... > >> + - items: >> + - enum: >> + - amlogic,g12b-ddr-pmu >> + amlogic,g12a-ddr-pmu >> + amlogic,sm1-ddr-pmu >> + - const: amlogic,g12-ddr-pmu >> + >> + reg: >> + maxItems: 2 > You need to list and describe the items. > >> + >> + interrupts: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + ddr_pmu: ddr_pmu { >> + >> + #include > Code looks terrible... > >> + >> + compatible = "amlogic,g12a-ddr-pmu"; >> + reg = <0x0 0xff638000 0x0 0x100 >> + 0x0 0xff638c00 0x0 0x100>; > That's one item. You need to separate regs. > > > > Best regards, > Krzysztof Thanks for your comments. Once I thought the example DTB got generated means the yaml file is ok. I will learn the writing-schema. rst doc and modify the binding doc as your comments. -- Thanks, Jiucheng