From: Andrew Lunn <andrew@lunn.ch>
To: Graeme Smecher <gsmecher@threespeedlogic.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Shay Agroskin <shayagr@amazon.com>, Rob Herring <robh@kernel.org>,
Yang Yingliang <yangyingliang@huawei.com>,
Marek Majtyka <alardam@gmail.com>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ti/cpsw_new: Expose the same module parameters as ti/cpsw.
Date: Mon, 14 Aug 2023 23:45:17 +0200 [thread overview]
Message-ID: <e53ac28b-c896-4f8d-a8b0-371f92c4ad5a@lunn.ch> (raw)
In-Reply-To: <20230814211323.3272487-1-gsmecher@threespeedlogic.com>
On Mon, Aug 14, 2023 at 02:13:21PM -0700, Graeme Smecher wrote:
> The "old" CPSW driver (cpsw.c) exports the following module parameters:
>
> - ti_cpsw.debug_level
> - ti_cpsw.ale_ageout
> - ti_cpsw.rx_packet_max
> - ti_cpsw.descs_pool_size
>
> This patch exposes the same parameters for the "new" CPSW driver:
>
> - ti_cpsw_new.debug_level
> - ti_cpsw_new.ale_ageout
> - ti_cpsw_new.rx_packet_max
> - ti_cpsw_new.descs_pool_size
>
> It seems like consistency between the two drivers is a reasonable goal.
The new driver was written because the old driver had a lot of bad
practices. module parameters are bad practices, there are better APIs
to use. So that is why they are not present.
ethtool has an API to set debug_level. descs_pool_size sounds a lot
like ethtool --set-ring. I don't know what the other two do, but look
to see if ethtool has an option to set them.
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2023-08-14 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 21:13 Graeme Smecher
2023-08-14 21:45 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e53ac28b-c896-4f8d-a8b0-371f92c4ad5a@lunn.ch \
--to=andrew@lunn.ch \
--cc=alardam@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=grygorii.strashko@ti.com \
--cc=gsmecher@threespeedlogic.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=shayagr@amazon.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®