From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.garry@huawei.com>, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
ming.lei@redhat.com
Subject: Re: [PATCH] blk-mq: Put driver tag in blk_mq_dispatch_rq_list() when no budget
Date: Fri, 17 Apr 2020 19:43:14 -0700 [thread overview]
Message-ID: <e5416179-2ba0-c9a8-1b86-d52eae29e146@acm.org> (raw)
In-Reply-To: <1587035931-125028-1-git-send-email-john.garry@huawei.com>
On 2020-04-16 04:18, John Garry wrote:
> If in blk_mq_dispatch_rq_list() we find no budget, then we break of the
> dispatch loop, but the request may keep the driver tag, evaulated
> in 'nxt' in the previous loop iteration.
>
> Fix by putting the driver tag for that request.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 8e56884fd2e9..a7785df2c944 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1222,8 +1222,10 @@ bool blk_mq_dispatch_rq_list(struct request_queue *q, struct list_head *list,
> rq = list_first_entry(list, struct request, queuelist);
>
> hctx = rq->mq_hctx;
> - if (!got_budget && !blk_mq_get_dispatch_budget(hctx))
> + if (!got_budget && !blk_mq_get_dispatch_budget(hctx)) {
> + blk_mq_put_driver_tag(rq);
> break;
> + }
>
> if (!blk_mq_get_driver_tag(rq)) {
> /*
Is this something that can only happen if q->mq_ops->queue_rq(hctx, &bd)
returns another value than BLK_STS_OK, BLK_STS_RESOURCE and
BLK_STS_DEV_RESOURCE? If so, please add a comment in the source code
that explains this.
Is this perhaps a bug fix for 0bca799b9280 ("blk-mq: order getting
budget and driver tag")? If so, please mention this and add Cc tags for
the people who were Cc-ed on that patch.
Thanks,
Bart.
next prev parent reply other threads:[~2020-04-18 2:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 11:18 John Garry
2020-04-16 14:12 ` Ming Lei
2020-04-16 15:27 ` Jens Axboe
2020-04-18 2:43 ` Bart Van Assche [this message]
2020-04-20 8:22 ` John Garry
2020-04-20 12:48 ` Bart Van Assche
2020-04-23 22:42 ` Doug Anderson
2020-04-24 1:35 ` Ming Lei
2020-04-24 7:18 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5416179-2ba0-c9a8-1b86-d52eae29e146@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®