From: Paolo Bonzini <pbonzini@redhat.com>
To: yunhong jiang <yunhong.jiang@linux.intel.com>,
Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Wanpeng Li" <wanpeng.li@hotmail.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Yunhong Jiang" <yunhong.jiang@intel.com>
Subject: Re: [PATCH v2 2/2] KVM: x86: fix underflow in TSC deadline calculation
Date: Wed, 29 Jun 2016 22:49:07 +0200 [thread overview]
Message-ID: <e543aba8-cd44-6de0-8dae-2d060373e84c@redhat.com> (raw)
In-Reply-To: <20160629101655.1b1b1b7a@jnakajim-build>
On 29/06/2016 19:16, yunhong jiang wrote:
>> > + start_sw_tscdeadline(apic);
> IMHO, it's not good to start_sw_tscdeadline() on the start_hv_tscdeadline()
> function. I think it's expected that the sw_timer is stopped when
> start_hv_tscdeadline() returns successsfully, or sw_timer is not impacted if
> start_hv_tscdeadline() fails. But it's not expected that start_hv_tscdeadline()
> returns successfully while in fact it's the sw_timer started instead :)
>
> Would it be better to simply return failure here, and the caller then
> starts the sw_timer?
I agree with Yunhong.
Paolo
next prev parent reply other threads:[~2016-06-29 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 11:23 [PATCH v2 1/2] KVM: x86: introduce cancel_hv_tscdeadline Wanpeng Li
2016-06-29 11:23 ` [PATCH v2 2/2] KVM: x86: fix underflow in TSC deadline calculation Wanpeng Li
2016-06-29 17:16 ` yunhong jiang
2016-06-29 20:49 ` Paolo Bonzini [this message]
2016-06-29 22:26 ` Wanpeng Li
2016-06-29 16:38 ` [PATCH v2 1/2] KVM: x86: introduce cancel_hv_tscdeadline yunhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e543aba8-cd44-6de0-8dae-2d060373e84c@redhat.com \
--to=pbonzini@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
--cc=yunhong.jiang@intel.com \
--cc=yunhong.jiang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®