From: Elliot Ayrey <Elliot.Ayrey@alliedtelesis.co.nz>
To: "andrew@lunn.ch" <andrew@lunn.ch>
Cc: "olteanv@gmail.com" <olteanv@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"netdev@kapio-technology.com" <netdev@kapio-technology.com>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix switchdev error code
Date: Sun, 26 Jan 2025 22:07:26 +0000 [thread overview]
Message-ID: <e546520005bfbdb09e66d7b9e823af1da796aae6.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <ab85afaf-bd9d-416a-b54c-9c85062f3f3f@lunn.ch>
On Tue, 2024-12-17 at 10:54 +0100, Andrew Lunn wrote:
> I just had a quick look at other users of call_switchdev_notifiers()
> and all but vxlan_core.c and this one discarded the return
> value. Would that be a better fix, making the code more uniform?
>
> Andrew
Hi Andrew, I am hesitant to remove this error as it was very helpful
during development and helped to diagnose some subtle issues that would
have otherwise been very hard to notice.
next prev parent reply other threads:[~2025-01-26 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 4:39 Elliot Ayrey
2024-12-17 9:54 ` Andrew Lunn
2025-01-26 22:07 ` Elliot Ayrey [this message]
2025-01-28 16:32 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e546520005bfbdb09e66d7b9e823af1da796aae6.camel@alliedtelesis.co.nz \
--to=elliot.ayrey@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@kapio-technology.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®