From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08114392C2C for ; Tue, 13 Jan 2026 15:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768318018; cv=none; b=tSDLQPuIw/k0NA29RfhAXcnQt/Go0ydKcA3hd7J196f/+yfwnuQ+ehT2Wh5YYMOc9bmeI8w7Drm9dMi5S0YW3mxQJZauVVIuhINfW+40gsCVe5VjdNt73q8WtfzhuHkH155II5OQDtVhIA6EH7u2fMo23PJLJngQ7/fP+3WL67g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768318018; c=relaxed/simple; bh=H9mGWxU5tI/68NlwoUxq/KaGxGic4AYNAg1bQz0mc8g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QJFfl7SR6RzRkgDOvQrcD3uIjaGgQ7Fm6M6eKQKu7kRAGj8cD5VQn42Ct+jyrbsxh82OqVgBAxmQnzD1eP52hhkXGFkVIlqoZ4L6x5i3amu04ksa6KLggYSA+ddocJZSbI5rty/dxVWfAVYFa/ZhIzxuPUSTjAYCsJkDIdFF8fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PazK/Nv/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K8T7p0lw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PazK/Nv/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K8T7p0lw" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60DBDXoc4164854 for ; Tue, 13 Jan 2026 15:26:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= F1az1Woti5BYc/nrE9F+K1wucFs6vzpU2BiesykC2Rk=; b=PazK/Nv/9u0YNnk3 4f2m+A63AA6/dckoLcdhElKLR4gyvfV+TzwRMfShfoFjQ0oIlbm/TQcXNQtFh0LZ Ksx+/ecmR4UzdyiFD4l2N0dvX/wdoBMidautqc25z6PQCWsz+b/Jn1PGXwufDDs3 VYmClSeuzwtmrtbwcdld0y2X+/A3rPdo2f9vxCxCJyx/SsJ3kcg1ApwL6JE++WvA r8ggYoxRYEJx1UG1uqoRxgNEM7JC1/XIQw47dnUgdYilLVwIikSivKgYN1JV3CB5 wxc3tOVG/K+poy3XS4tyMrcBlddDAdpETFxRV+DT27Qb95iibWJ1Gttgg+ah5BEc 6afLEw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnn06rrxm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 15:26:56 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ee07f794fcso24484821cf.2 for ; Tue, 13 Jan 2026 07:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768318015; x=1768922815; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F1az1Woti5BYc/nrE9F+K1wucFs6vzpU2BiesykC2Rk=; b=K8T7p0lwb2Sdzys8RFWasShW/3ntCtgfqGH+x/8hwhSjfpPsJ5eK4ibp2WiHTL5gQm ptSZQ2opDunE0sQpYEwD70myd2wucOMcn6spszNe9++ckQ9pMvSHxVfcHYGf7b5mGczj c485milqyP42rtaTTxpqJeLIV/AEwS3vT6NGZNkcsRET+yY1GUejECSlalrAJTKC2EV/ gumksKP3F8YXxeUoVYjIFdiclEewwgrH5x2lbU9J9IbBsea6UFXIys2fj5UUFnk+H1Bg NLkLJLP5/nHG8KbUv++Pz3Pv2he1pVHNOFGE2WzF40slC6bOx8RJK/V1KM1g5LEOdLSa HSKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768318015; x=1768922815; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=F1az1Woti5BYc/nrE9F+K1wucFs6vzpU2BiesykC2Rk=; b=ZcorZ29e/8y5LXA65ADKV/3Fa1Hw825fcF7mT3EXeek2JUNFlT5gJCKzzoqPHPwc1P mS6R4eJXbtZj2bbgb33IOVrLShq0hCgussDDne6woowPpKGAa6L2jeAD5f2mJ5xgjto4 4cDzCN1zCvd/JFS3Sf0f1cYsnkeQtK8Jax2HQL3Q23oLPPlarHagM8TW/lEUFrlVOxdY V6yrDUTwbrcidGLb+ujLplLJeD7yydXry0dRZ7xs3lWLc7PbevBzxEAbaQxuTNvYOzd8 HFJaQUwBO4Ei5nYzV4RluUOA1GQlGa9GTrn5AdtPJijAEuIm0zUC3pUuycf1Ey7xYVeJ KTmg== X-Forwarded-Encrypted: i=1; AJvYcCV8MuM44yGjrsUR44OicgZKl7OcDwovR3Y5pe2Qt3qD8jfsshcoVew485U2GbxYcJMYAMfWyDknYewmpw4=@vger.kernel.org X-Gm-Message-State: AOJu0YzP1qIQiIqEbEd2xmLOD47OyZkNiFXRM54JnJGppzHHzjmgu8uj lO5AKg2ZGGBIcXY5yn/jT6QT0cThYSL2fXitnRWRntG4gT/OHQEZo0KtX48BxbxI1stcKo+6Dq9 oMelVp0nBEj5sDlueRY+UMM/auMFQSXVsbFC4skSkeywQMTJUYAsDjnKrLaNfBDzVHJA= X-Gm-Gg: AY/fxX42/Tigs6tIMwgf9f+bu/mOAlaREDaRj1W/r6wAWgWt0e6QYVeNLEfNif0kATN gg/9Kl46/pJZzQr1oDRYRo+hvOC138tQV6dIw0akzTFHAUlb1iwVhRZBapZrsdDJagx4GK9hvIf Fmiq8UfHqMrrlVO2dCRcQMfj0B1oPHxwOh5XjtPgK+MfcKpPR0pN8cI9DWpffMHs4MgF8RHpfsN kHr6DrSfXqoGqxjdobteWxRs0xVToG0GVP0C0sg+4epsvxwyH8oeApEBqhsvvxkXVJOdtyjISOl lof5jyYDzj6obErFv7NHia7oNAWMWXRKL4rBjG5bUuggk/hXcBU3iP6z6IFOj3QF/MIPylVkBEb ckXq44V9c4zRaYWvckLUKe3u+R91L1q1NhGrZvdmG5J7yUdnVot4WpxOop0uxNBPsx0Y= X-Received: by 2002:ac8:570f:0:b0:4f0:299b:c785 with SMTP id d75a77b69052e-4ffb4acf414mr226027881cf.11.1768318015260; Tue, 13 Jan 2026 07:26:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IH63OKsfsC1PCQAIfHI6h3nw+uJWv7koCZrOmWbLpsbWAxrJGkd3sfSU3Ah9H1bPnxDS8ArwA== X-Received: by 2002:ac8:570f:0:b0:4f0:299b:c785 with SMTP id d75a77b69052e-4ffb4acf414mr226027601cf.11.1768318014831; Tue, 13 Jan 2026 07:26:54 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b86ee5287e4sm1020534866b.52.2026.01.13.07.26.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 07:26:53 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 16:26:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/11] soc: qcom: ubwc: add helper to get min_acc length To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org References: <20260110-iris-ubwc-v1-0-dd70494dcd7b@oss.qualcomm.com> <20260110-iris-ubwc-v1-2-dd70494dcd7b@oss.qualcomm.com> <5594210c-ce25-40ac-9b5c-69c97eb0bd72@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: RHUKEKn8m0S0-QD9NyVQulJ0p5dwvz_9 X-Authority-Analysis: v=2.4 cv=ZODaWH7b c=1 sm=1 tr=0 ts=69666440 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=2hdBVZVomPjqdouaftMA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: RHUKEKn8m0S0-QD9NyVQulJ0p5dwvz_9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDEyOSBTYWx0ZWRfX7UJiRmjzQG5r pjw0izzZArH41Lx7JYTKNcmpe/8zOgsIQw9JWs2qvJgarVBLgvJYIpnrjtavnXXQGBvQwyMWHsh SCI52/eiAOrQsA2EOnezjNPqHKpBin0+H++rH0a/7B42b3mx0LbnsxDqkWOGI4XJQP6uUcL7YMs Ni3Jm60beKpWxDJRyN4ZA6nTORVgdPaRw7wtvO3kHSsm8I3s6Ruy4u9yi6BHdONkNGOKn/b9p7v /7KyH1TPdpo6x5ax4PJHPi2OYvJ4S62ZSfw+nVfT4TE8VYNPcTCZCLd55j03hcoubKlvZk2KqCD CVAJQVPH9wEsz+fFMHoGJfANC0XwUyOoclNJk/WQ1T/8uYBSE0clU4V45yPWiZpFVMR3HyrZk3g MzWy9AdmkfE9ryr+f+PpcWRTqx06vPPuEKrqvLprC1XcpGZNdO5T9ob+QPpXoTDUCHK4EjaMUWj aOIJdms4pvsFOZ02pBg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130129 On 1/13/26 1:24 AM, Dmitry Baryshkov wrote: > On Mon, Jan 12, 2026 at 12:08:13PM +0100, Konrad Dybcio wrote: >> On 1/10/26 8:37 PM, Dmitry Baryshkov wrote: >>> MDSS and GPU drivers use different approaches to get min_acc length. >>> Add helper function that can be used by all the drivers. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> include/linux/soc/qcom/ubwc.h | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/include/linux/soc/qcom/ubwc.h b/include/linux/soc/qcom/ubwc.h >>> index f052e241736c..50d891493ac8 100644 >>> --- a/include/linux/soc/qcom/ubwc.h >>> +++ b/include/linux/soc/qcom/ubwc.h >>> @@ -74,4 +74,11 @@ static inline bool qcom_ubwc_get_ubwc_mode(const struct qcom_ubwc_cfg_data *cfg) >>> return ret; >>> } >>> >>> +static inline bool qcom_ubwc_min_acc_length_64b(const struct qcom_ubwc_cfg_data *cfg) >>> +{ >>> + return cfg->ubwc_enc_version == UBWC_1_0 && >>> + (cfg->ubwc_dec_version == UBWC_2_0 || >>> + cfg->ubwc_dec_version == UBWC_3_0); >> >> Are you sure this is a correct heuristic? > > No, but it matches what we had in MDSS driver (and I think it matches > the chipsets that were selected by the GPU driver). Should we keep a comment that this is a best guess that worked out so far? Konrad