From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6388DC77B75 for ; Tue, 23 May 2023 19:53:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238224AbjEWTx6 (ORCPT ); Tue, 23 May 2023 15:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjEWTx4 (ORCPT ); Tue, 23 May 2023 15:53:56 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D1EB11D; Tue, 23 May 2023 12:53:55 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34NDtnsu019374; Tue, 23 May 2023 19:53:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=PTOy6D3KXyo3bx4Y9BYwVtX8ESpmcicMi5So7uRqGZ0=; b=NFdvZtJksiPGpfDveOX+hgzCbkJM8ZzXEO31saaXV0gviml5kptTTyYOl6WicRPCe4pD QLk3BOzEMO3f9jgtFCmosUXk+FTmQsc5G+t1W3gijhA5kRWYkwziVnP5ZnNA5Qx58qgG gUauiSdd5VUdNP8Zy5AA3hWuC0csKB0FR62qVclXlMRE6lJpmhyH9zpIuZGyfz2VzdIA XHvWsXBKPmNgTURYi2c79huz7k0UFM1Yd8afuFqtfgMY6ZAIImRvJmJWjmmiMwmdbnZf QQokJFRvCjCn4vJTI+DJ3MSPIehvu+XuFlp1csGZtS4NrrO+QWGFdT+V1bBKoWHG3QdL SQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qr8qrbw3c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 May 2023 19:53:22 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34NJrK1K020103 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 May 2023 19:53:21 GMT Received: from [10.71.110.189] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Tue, 23 May 2023 12:53:20 -0700 Message-ID: Date: Tue, 23 May 2023 12:53:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay" Content-Language: en-US To: Abhinav Kumar , Leonard Lausen , Dmitry Baryshkov , "Bjorn Andersson" CC: , Sankeerth Billakanti , Bjorn Andersson , , David Airlie , "Nikita Travkin" , , , Rob Clark , "Daniel Vetter" , , Stephen Boyd , Sean Paul , Johan Hovold References: <1345a125-f745-4fe3-0f5e-bfe84225958d@quicinc.com> <20230508021536.txtamifw2vkfncnx@ripper> <3802269cd54ce105ef6dece03b1b9af575b4fa06@lausen.nl> <49d175ec16e3f65a18265063e51092ee8d0d79c1@lausen.nl> From: Kuogee Hsieh In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: M1obPpIxL0X7eocteX6b6x1omt8oyBTr X-Proofpoint-ORIG-GUID: M1obPpIxL0X7eocteX6b6x1omt8oyBTr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-23_12,2023-05-23_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1011 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305230160 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/2023 11:56 AM, Abhinav Kumar wrote: > Hi Leonard > > On 5/22/2023 7:39 PM, Leonard Lausen wrote: >> Abhinav Kumar writes: >>>>>> There is no need to add the 100ms delay back yet. >>>>>> >>>>>> thanks for posting this but NAK on this patch till we post the >>>>>> fix this >>>>>> week. >>>>>> >>>>>> Appreciate a bit of patience till then. >>>>> >>>>> This regression is already part of the 6.3 stable release series. >>>>> Will >>>>> the new patch qualify for inclusion in 6.3.y? Or will it be part >>>>> of 6.4 >>>>> and this revert should go into 6.3.y? >>>> >>>> This is a tough situation, as landing a revert will break x13s, as >>>> noted >>>> by Bjorn. Given that the workaround is known at this moment, I would >>>> like to wait for the patch from Abhinav to appear, then we can decide >>>> which of the fixes should go to the stable kernel. >> >> I wasn't able to find new patches, though may have missed them. Is there >> a decision yet how to proceed with this regression? 6.2 now being EOL >> may make this a good moment to decide on the next steps. >> > > Yes, the new patch to fix this issue is here > > https://patchwork.freedesktop.org/patch/538601/?series=118148&rev=3 > > Apologies if you were not CCed on this, if a next version is CCed, > will ask kuogee to cc you. > > Meanwhile, will be great if you can verify if it works for you and > provide Tested-by tags. Hi Leonard, I had  cc you with v5 patches. Would you please verify it. Thanks, > >>>>> [  275.025497] [drm:dpu_encoder_phys_vid_wait_for_commit_done:488] >>>>> [dpu error]vblank timeout >>>>> [  275.025514] [drm:dpu_kms_wait_for_commit_done:510] [dpu error]wait >>>>> for commit done returned -110 >>>>> [  275.064141] [drm:dpu_encoder_frame_done_timeout:2382] [dpu >>>>> error]enc33 frame done timeout >>> >>> This is a different crash but the root-cause of both the issues is the >>> bridge hpd_enable/disable series. >>> >>> https://patchwork.freedesktop.org/patch/514414/ >>> >>> This is breaking the sequence and logic of internal hpd as per my >>> discussion with kuogee. >>> >>> We are analyzing the issue and the fix internally first and once we >>> figure out all the details will post it. >> >> Thank you!