From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D48F1E0DCC for ; Tue, 8 Oct 2024 19:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728415990; cv=none; b=JJiLuJcy+sHEfJ4WReQPNYZa3shAiRmob082gv2P2H3SQR+0FlqMhLoEj4yXujMdc25XQfM6EhDdWbhzhRmZPyNiTH4LyHsEUscahgNlnkFPEUIIrqD9e3HvD1tvWSDXykzY8phkocjTeX5zEDam0lRiYnzGoGQtoD1+i9tryro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728415990; c=relaxed/simple; bh=ZWjiWX2PYow7IFF+icnGCEcVzFP7KxAoECdaQ7XIMZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l4N/5ibfiH3gXQDuq9pHAsucd5qmUUYwA9Y/HBiZHwYE+tNS9SilHgKneKp2LjJB2J1ERUuKwap0OApMBVdpdBwXsdOvlcTErkFXA3bJuWsiARwDJX/Q+04cxTv/xp5mK41Hvxh1faVavPLO2FpYfae0VMP+Gy5m81HHLLNnKTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ghjmA6bn; arc=none smtp.client-ip=209.85.166.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ghjmA6bn" Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-37636c3872bso19599355ab.3 for ; Tue, 08 Oct 2024 12:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728415986; x=1729020786; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=igeyFC/Kp5wyyTrbzqjY53d0DZThT6N1c1YSK8tDcXQ=; b=ghjmA6bnep2bZryJgktuBxMALgNC83mtXOyUuH9YA4bxBLx8vR+GP+qoFrMkOcWCl6 djq4WCQFA5+C0GS542nhO6gWG48EmhhpCgBo/oXd+1L9HFb4v6ngmpqtRvciuxi/XrNs ypUILIbnoqsZ2JOlQG0pQ2TSuOAfJcCP7DLmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728415986; x=1729020786; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=igeyFC/Kp5wyyTrbzqjY53d0DZThT6N1c1YSK8tDcXQ=; b=eXuuMJXT8CbCBbDlXD+A/c/d75hv2dGfIit9UqzV4KWz5o+oQ/h2G3E6133tRgnCx3 bslIoYwwt+0ve9SNee0jdGdS7pOm3QCF5aiLkh3Afrxe9H4AaII6jpKrINKRLJ9CwgkT 5E8gAkN5sZlYOGibVxGmW0130CdWJo+IouEOcx5VxUW4Q+YI8akBfslYs2HIqkzAENHg lgWAFS9V9snagL0KxJ6nFoy+a3FybXsjYxA76lEbYyQ6G6BPdCAmD2IfkjSo6DnXWo4U hRi50GizSyZjFABTrXqpUyxox7duvLvWlc+g0DJbkEt40cbFT255hZmemVgWvTH8twPh b81A== X-Forwarded-Encrypted: i=1; AJvYcCWOBUp6Jpt16zzB/zizlb+e6LkTBl+yMcCbvTJ4to2SikaRU6AK7eOA3qFuYG5lKZJjRkzAC+B1pwZj7Wc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzs8GojSWJR+vPX1Im+USTPRLucG+bLIo7c/gDe2ja8/HxhWl+H Xlofn23VmZGBttLwT3RNgQbzpMQ3GYztAZxmDcJpUv8OaIqAZSpt55jkyze6SAk= X-Google-Smtp-Source: AGHT+IExoHge3ikoQI3mxSRfDzAdKfxp8Xxvr98miHmNy06vYEkpSOJyjh75gjwCWYFN1muiNtcY3g== X-Received: by 2002:a92:ca05:0:b0:3a0:a71b:75e5 with SMTP id e9e14a558f8ab-3a375999710mr142135035ab.7.1728415986588; Tue, 08 Oct 2024 12:33:06 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a39644f0c5sm947165ab.17.2024.10.08.12.33.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Oct 2024 12:33:05 -0700 (PDT) Message-ID: Date: Tue, 8 Oct 2024 13:33:05 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftest: hid: add the missing tests directory To: Yun Lu , jikos@kernel.org, bentiss@kernel.org, shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20241008093120.3081899-1-luyun@kylinos.cn> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241008093120.3081899-1-luyun@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/8/24 03:31, Yun Lu wrote: > Commit 160c826b4dd0 ("selftest: hid: add missing run-hid-tools-tests.sh") > has added the run-hid-tools-tests.sh script for it to be installed, but > I forgot to add the tests directory together. > > In fact, the run-hid-tools-tests.sh script uses the scripts in the tests > directory to run tests. The tests directory also needs to be added to be > installed Include the error you are seeing in here. > > Fixes: ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests") > Cc: stable@vger.kernel.org > Signed-off-by: Yun Lu > --- > tools/testing/selftests/hid/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile > index 38ae31bb07b5..662209f5fabc 100644 > --- a/tools/testing/selftests/hid/Makefile > +++ b/tools/testing/selftests/hid/Makefile > @@ -18,6 +18,7 @@ TEST_PROGS += hid-usb_crash.sh > TEST_PROGS += hid-wacom.sh > > TEST_FILES := run-hid-tools-tests.sh > +TEST_FILES += tests What about the files if any under the tests directory? The install rule would handle the case, however, did you verify that those are copied as well? > > CXX ?= $(CROSS_COMPILE)g++ > thanks, -- Shuah