From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBDB82EC55E for ; Fri, 12 Sep 2025 10:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757673846; cv=none; b=EPuNgWbxU9+NrYHgbedJH9FW30+ktPeFxVNW9eF2+ug0M1o2VdskC80/6e123iUPfEAotYAmJehbXk7X9hj6pYJc8tbkJJryEJ0AZITQV8ZBEoHPWXGC9FTrrkGZ3wBzDbAndsmA0hLK1wZNEEtvZix8BcvbCVzNGwwWjHvwHuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757673846; c=relaxed/simple; bh=1RhAAhWL14KKCCwjLjtFQQnHEgSFzReQkw1xUr24XvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GAXqXyygvO9KYbQEzZ6aamKjPDFfxw7Y9TROhnJdddi/G+YzDkfBrFgFaAegBVz76VktOGCMtRpj2FKWQtq/7CGprcQ5LbRjg/v8tMyH+kMSE8swOwn2ROYn0VjkfSmzSRWOgUijy+NDiIvanEfjTPHytSkam5JX3QQi97MsGBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FpZLhtJE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FpZLhtJE" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58C9fNa5023229 for ; Fri, 12 Sep 2025 10:44:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U6ixdakbQ5kVuK1Oh9RTq+mbKIlEiLNdgoJFQouUhYY=; b=FpZLhtJEUzFZSGt7 q43V341L7ZfsFjv4qk3jaCT6k/npPf4Us9JafjejZCvcBHGsi/kWmN9w41ixpi9F 7bdorMaHGnv5v9PQMNvLsUcnsMqk8Zljp5lPFOg06pt8m5rXWlIHS+KWsgbTv1om g14V8fF5F7G9w50drTe+jQtTcdRsZ4n1GNiWWW1urhPe5KuJtB9pWRrR1D2qU0Rq aw+nnCSYjrN9xvmrIxXGNKlaFlnvIAvPlf+EICRlcELOzDGr6t8EVWMpG9EzkkQf c8129BIdf4u7Funx7B6aUvIPasQ1v4Q02UyVruLSVBRrvduBw8drgQrq75Phpfb1 0JlVxw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 491vc2fab5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 12 Sep 2025 10:44:02 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-721c6ffab9cso6798706d6.2 for ; Fri, 12 Sep 2025 03:44:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757673842; x=1758278642; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U6ixdakbQ5kVuK1Oh9RTq+mbKIlEiLNdgoJFQouUhYY=; b=FUlLHkM3W5b4ta0KieAswyYGU6N3znGhpCv3lGtVKdR41/3koWHjMeepF/DSMljb3/ CyH6l64Vg4aLPc9tBH55G42c1eBiL75775puhYqyWAhS0sOeCZtxTxvOwSzP6c0tcQPs DD5PlBj1i3BkUkQhXiOCrjUeioHEM6oBGx73FkPVf3ew3cBfEdr1dQWkLOVJFH+Hvpft nXB032B0IbJqCUApmKEqonAnnR0AKtSMnznR3lxY91Fpe+nV9Z58GrXvKz7SXiseVgYI BV8L2ZG+ITqVfERC0cqRVYagXQkG0PMGzZQNpz/LuDtSI49a2yb+ArLQDDMbvX5yFQ+c KUqQ== X-Forwarded-Encrypted: i=1; AJvYcCWgs+CQjEz1Sq/2/ggqW+2kkbtUKMP8132PSMRffj1W5dffyLlJFWm93KRgX/OhAiUIwvgDcF7Q4Ti+Uho=@vger.kernel.org X-Gm-Message-State: AOJu0YxyabQX0kC6K+2gKIoRGlT9WpeijnODyvOuOw4HH9DatUN3PtxE bRYAkc1WH446nldvjUz4FxKihb8csRzWWEi8b7kJFotF1/RLuVdVQk2Eojkv6qZSHjYsUmO+CWx 9Poi9E4wzneWiHn1bpHZA6hpyuMU46ICmO3NO+/L/Y7NLyNehP5vbPFyX/Av8644jePI= X-Gm-Gg: ASbGncu/jEBzbYUqAxIO3rxuazkwDlFPl8dh7tcFn6MLCidxwcqOzRT3CQ6j4597DWR cjQkeA8y56icJ3WLHwSVRbEtRleZIJxhumT50A0DEp/fMN7SqqqsJozqqwLKvh4P/yjCjeLysgq aMij8gPqXlx6265kll695qrZEIViMPiiYxY+jC7yQkjWKgLKfzqjVAV9JYaJD0bRPMpoLSeut46 DvBZ9fhfCKkJsP72TDErkRrSjmsitjBMbFQqUx+FsbitjG7/n8p+Nwqvgc6c5fDX+QbnlKfq39Y t0elGPunDe9a0/AJ8GYW5hdfuo8qQotcFQ58rx9w5eJZp7MvMQLJaXRohiQeUk7XDu7rkCuBw4S 49HcC0itUYeRs//7j5sL1bg== X-Received: by 2002:a05:622a:1455:b0:4b5:e9b6:c9f with SMTP id d75a77b69052e-4b77cfb686dmr20878191cf.2.1757673841881; Fri, 12 Sep 2025 03:44:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZWNrezfUYTvVB+lGnpKpkT5LYRuL7bmjPVtk+17xLrpknyf/SfpAgAUionq66fQygxAEbJQ== X-Received: by 2002:a05:622a:1455:b0:4b5:e9b6:c9f with SMTP id d75a77b69052e-4b77cfb686dmr20878001cf.2.1757673841419; Fri, 12 Sep 2025 03:44:01 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-62ec33f3c01sm3111408a12.34.2025.09.12.03.43.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 03:44:00 -0700 (PDT) Message-ID: Date: Fri, 12 Sep 2025 12:43:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] arm64: dts: qcom: Rework X1-based Asus Zenbook A14's displays To: Aleksandrs Vinarskis , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Glathe References: <20250908-zenbook-improvements-v1-0-43ecbbf39c60@vinarskis.com> <20250908-zenbook-improvements-v1-2-43ecbbf39c60@vinarskis.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250908-zenbook-improvements-v1-2-43ecbbf39c60@vinarskis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=FN4bx/os c=1 sm=1 tr=0 ts=68c3f972 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=I76Qk8w-AAAA:8 a=gxl3bz0cAAAA:8 a=bDNgJRMZ7ET8QJXj1coA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=vUPM0Wvl0xcrLs4nqPIT:22 a=kiRiLd-pWN9FGgpmzFdl:22 X-Proofpoint-ORIG-GUID: GlXHg3H91ARq8ZdnVB1VTb5UofQL_1Sp X-Proofpoint-GUID: GlXHg3H91ARq8ZdnVB1VTb5UofQL_1Sp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA4MDA5NCBTYWx0ZWRfX2pMDgILMUSsj KWZ9vnXcL2/rp9szER9rZxnJJ5beX6hBfR/06a26LwVTqz2ECXJsXtjtoZUuDHa/kbrXxj5zmrz guSal8Cqqgx7IAchz9nOTaUncS1RDr8x/d+uePaZjMy4a30TaAw7NXi/sQJZ5uZTFXd96yjTeFG E22TOybOu2vBCy1F3mm/CPQcAIPf9NpZxduVqMd04CqPUWgOZjEE3+dczDCqRAlS1RNy3T5+Ax6 houC48cSzPnNCdfx12QP/rHMnb2zQ07+qMBQqYbW2UpdJD9I2jYJ2EOLeKbWPlIUMj+6PpsWWFs 4Y/N4T/UvwHvbs3l07sdUE02DL5JaH5KGkiGtlRRV9SsgwXgtAlEq6UnVlzE2iZpmXZf8qqI2Ml AP1NXMWq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-12_03,2025-09-11_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509080094 On 9/8/25 8:45 PM, Aleksandrs Vinarskis wrote: > The laptop comes in two variants: > > * UX3407RA, higher end, FHD+ OLED or WOXGA+ OLED panels > * UX3407QA, lower end, FHD+ OLED or FHD+ LCD panels > > Even though all three panels work with "edp-panel", unfortunately the > brightness adjustmenet of LCD panel is PWM based, requiring a dedicated > device-tree. Convert "x1p42100-asus-zenbook-a14.dts" into ".dtsi" to > allow for this split, introduce new LCD variant. Leave current variant > without postfix and with the unchanged model name, as some distros > (eg. Ubuntu) rely on this for automatic device-tree detection during > kernel installation/upgrade. > > As dedicated device-tree is required, update compatibles of OLED > variants to correct ones. Keep "edp-panel" as fallback, since it is > enough to make the panels work. > > Signed-off-by: Aleksandrs Vinarskis > Co-developed-by: Jens Glathe > Signed-off-by: Jens Glathe > --- [...] > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/x1p42100-asus-zenbook-a14.dtsi > @@ -0,0 +1,141 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2025 Aleksandrs Vinarskis > + */ > + > +/dts-v1/; > + > +#include "x1p42100.dtsi" > +#include "x1-asus-zenbook-a14.dtsi" > + > +/delete-node/ &pmc8380_6; > +/delete-node/ &pmc8380_6_thermal; > + > +/ { > + model = "ASUS Zenbook A14 (UX3407QA)"; 'model' in .dtsi is 'eeeeh' [...] > +&remoteproc_adsp { > + firmware-name = "qcom/x1p42100/ASUSTeK/zenbook-a14/qcadsp8380.mbn", > + "qcom/x1p42100/ASUSTeK/zenbook-a14/adsp_dtbs.elf"; > + are both of the aforementioned variants' firmwares the same? Konrad