From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193988460 for ; Sun, 27 Apr 2025 19:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745781448; cv=none; b=jy9aAXVercPwwTsH3k8Gh+mmYy4uJCL+1TkgaVVOwsa/ABHVHHp4kVUC8PhxsvNTsq1FjUJuBJi6V239YiJTCUNIVZWGeVKlsqwXFsSFAnWbTWnNyfomCmyZAPzjPzsL32jnopXeyV293GXeLX8GC8Xz3pBn/cTQhhTTeUHRJgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745781448; c=relaxed/simple; bh=FXjELEw88FulT7FupNCJSzusRtkbwfNo7cpeKBXb+YU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uipRCCkzSawa99+gUCrhbBBoc0K2Q4MXgAPsauYaxfwUCoTnB98f7QhXSzs+v9oW31zkDozed55FxDCsdwJD06NwRj3C6uPie+Fsd38Y3fivtW+r71V9Iv4BxDaK1qlxG8pDJ4bU/6p22hqtXsAIggPqqnXGBF9AMsvNBQtN2hs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=cloud.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=QDtZ9qP2; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="QDtZ9qP2" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so36536305e9.1 for ; Sun, 27 Apr 2025 12:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1745781445; x=1746386245; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=fgo1HhhwzN6JMUrp7rwymnKFHp8snUhIVeQypKZNvBA=; b=QDtZ9qP20YdHz8MrIePp0AIZZGhgQc5dqUSh31MQqsgq1ONpSapAmSyX066q/2nKHt xu/pAsHojPeIkeTDj5lG+GNc0Jbyrsx5JT50BbeBH5Q1s4LXn5Qhb8+FZNy4yLrS0tFZ 4N/4jGVJGMH0S2xfnwASAKZ7GTRc79Fho3CYw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745781445; x=1746386245; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fgo1HhhwzN6JMUrp7rwymnKFHp8snUhIVeQypKZNvBA=; b=blVXhXYOl3er8rrYoJMwqmccASkcxODWWx8BvnWEuaNur8Gdc2HX7TvHIjXQMy0gdQ cSjd6VG39yJXtd55kdOiP3dJ1I2WqAuePPqQ7LYFzoNa0goPLL8HiQU/ge2unHlDFta8 iCorlusyYER6VbJu9OcI8NG6qRNsrcH14P+Tl3VokJ/9INDmbwx1jt5I4QzPEam9DRO3 FoJ4DmiOz63ujKYZIVx8qNitQdCZL2xlglUucDHGc30YfUyOst3+zv9mNRiA9HiS0Q4K p2JPvu77oCd1Db0W/kyED/rCyrmQnGTq82DJerZseSalRBOSyk5kG4tlvtIm++mrn1tP //BA== X-Forwarded-Encrypted: i=1; AJvYcCXbBEE+A+tHzb6GSVcstysF8U/Li0y0ae0OHXatNdLPxvHKzZkBbJ2tJcAgvvGohcBVYmQgcLR2ztaojik=@vger.kernel.org X-Gm-Message-State: AOJu0YweuUMNPScUWcCrrsEmKgWjRv9JGTgsdckcDtPI25RKLtYfhlY5 qEB05KtjzdHIz32B5iq/AkR3Sld5Kbzb9cqUgMWRfPizvHgnCbswm7Tyy255QR4= X-Gm-Gg: ASbGncuO6d6Gto2T37+apg1YMFsYhn3RLHbnGLgrrEGy6HzItxeCbNSzO+QsGrpwz65 NdlAU5Ok0w/D42NFolPMHmgltdUYKXUgI1+KeNOPB8uQzq4fGsll3HRZAlGyl8hX31LXFnIQz90 Oq9Txb1pibMKa/QyUUUfIlVA6/trgmbbTIwuYN0lBxaaf8jYuV3cETMsUv4TDaFRH1tOdVZUj4B G3diYZQPBGxSyy0nggQ9afuSVs/LdQl5roq89bhuw6/55xgTrxQgwExHNI0WnkUsojlZl35usdH LL2Rq7nT6L02fGVxBVD9HL93xsP9ZhyjBwxTtbfGss5+tnJInNzmHIACs0JJGCYQK2VcvbY5lTM zIILJWw== X-Google-Smtp-Source: AGHT+IEhY5ybFGwjwKL2hzuwU29xJrgD8a5nx3iWjWsIG0Ko+irFEcz15VvGRESsIA9aEaOvT884qw== X-Received: by 2002:a05:6000:186c:b0:39b:f44b:e176 with SMTP id ffacd0b85a97d-3a06d6dd50fmr10870062f8f.24.1745781445304; Sun, 27 Apr 2025 12:17:25 -0700 (PDT) Received: from [192.168.1.183] (host-92-26-98-202.as13285.net. [92.26.98.202]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073cbed98sm8856912f8f.48.2025.04.27.12.17.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Apr 2025 12:17:24 -0700 (PDT) Message-ID: Date: Sun, 27 Apr 2025 20:17:23 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [RFC] x86/cpu: rework instruction set selection To: Linus Torvalds , Arnd Bergmann Cc: Ingo Molnar , Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Juergen Gross , Boris Ostrovsky , Alexander Usyskin , Greg Kroah-Hartman , =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= , Mike Rapoport , Ard Biesheuvel , Peter Zijlstra , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org References: <20250425141740.734030-1-arnd@kernel.org> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 26/04/2025 8:55 pm, Linus Torvalds wrote: > So I think that manual cmov pattern for x86-32 should be replaced with > > bool zero; > > asm("bsfl %[in],%[out]" > CC_SET(z) > : CC_OUT(z) (zero), > [out]"=r" (r) > : [in] "rm" (x)); > > return zero ? 0 : r+1; > > instead (that's ffs(), and fls() would need the same thing except with > bsrl insteadm, of course). > > I bet that would actually improve code generation. It is possible to do better still. ffs/fls are commonly found inside loops where x is the loop condition too.  Therefore, using statically_true() to provide a form without the zero compatibility turns out to be a win. > And I also bet it doesn't actually matter, of course. Something that neither Linux nor Xen had, which makes a reasonable difference, is a for_each_set_bit() optimised over a scalar value.  The existing APIs make it all too easy to spill the loop condition to memory. ~Andrew