mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	David Airlie <airlied@linux.ie>,
	Kevin Hilman <khilman@baylibre.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Sekhar Nori <nsekhar@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-drm <dri-devel@lists.freedesktop.org>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] drm: tilcdc: fix parsing of some DT properties
Date: Tue, 29 Nov 2016 11:24:20 +0200	[thread overview]
Message-ID: <e54f3479-b849-4195-07c7-72d97c40883d@ti.com> (raw)
In-Reply-To: <1480333043-1292-1-git-send-email-bgolaszewski@baylibre.com>

On 11/28/16 13:37, Bartosz Golaszewski wrote:
> The DT binding for tildc is not consistent with the driver code: there
> are two options - 'max-width' and 'max-pixelclock' specified in the
> documentation which are parsed as 'ti,max-width' and
> 'ti'max-pixelclock' respectively.
> 
> Make the driver code consistent with the binding.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Reviewed-by: Jyri Sarha <jsarha@ti.com>

I'll pick this up for a pull request that I'll send shortly.

> ---
> v1 -> v2:
> - fix max-pixelclock too
> 
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 5efb369..bd0a3bd 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -296,12 +296,12 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev)
>  
>  	DBG("Maximum Bandwidth Value %d", priv->max_bandwidth);
>  
> -	if (of_property_read_u32(node, "ti,max-width", &priv->max_width))
> +	if (of_property_read_u32(node, "max-width", &priv->max_width))
>  		priv->max_width = TILCDC_DEFAULT_MAX_WIDTH;
>  
>  	DBG("Maximum Horizontal Pixel Width Value %dpixels", priv->max_width);
>  
> -	if (of_property_read_u32(node, "ti,max-pixelclock",
> +	if (of_property_read_u32(node, "max-pixelclock",
>  					&priv->max_pixelclock))
>  		priv->max_pixelclock = TILCDC_DEFAULT_MAX_PIXELCLOCK;
>  
> 

      reply	other threads:[~2016-11-29  9:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 11:37 Bartosz Golaszewski
2016-11-29  9:24 ` Jyri Sarha [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e54f3479-b849-4195-07c7-72d97c40883d@ti.com \
    --to=jsarha@ti.com \
    --cc=airlied@linux.ie \
    --cc=bgolaszewski@baylibre.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nsekhar@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®