From: Frederic Barrat <fbarrat@linux.ibm.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Cédric Le Goater" <clg@kaod.org>,
"Michael Ellerman" <mpe@ellerman.id.au>, "Qian Cai" <cai@lca.pw>,
"Rob Herring" <robh@kernel.org>,
"Michal Suchánek" <msuchanek@suse.de>
Subject: Re: [PATCH kernel v3] genirq/irqdomain: Add reference counting to IRQs
Date: Sat, 14 Nov 2020 10:42:18 +0100 [thread overview]
Message-ID: <e552f6a9-8b82-f446-d67d-2f666870c766@linux.ibm.com> (raw)
In-Reply-To: <98d06682-da53-c851-74a7-952bf958b793@ozlabs.ru>
On 14/11/2020 04:37, Alexey Kardashevskiy wrote:
>> I'll try to go through this patch over the week-end (or more probably
>> early next week), and try to understand where our understandings
>> differ.
>
> Great, thanks! Fred spotted a problem with irq_free_descs() not doing
> kobject_put() anymore and this is a problem for sa1111.c and the likes
> and I will go though these places anyway.
So there are callers out there which don't care about mapping the
interrupt. Wouldn't it be easier to leave alone the kobject from the irq
descriptor (my understanding is that it's there to handle the sysfs
representation) and add a simple kref counter, just to handle the
mapping part?
Fred
next prev parent reply other threads:[~2020-11-14 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:46 Alexey Kardashevskiy
2020-11-13 18:19 ` Cédric Le Goater
2020-11-14 3:55 ` Alexey Kardashevskiy
2020-11-13 18:34 ` Marc Zyngier
2020-11-14 3:37 ` Alexey Kardashevskiy
2020-11-14 9:42 ` Frederic Barrat [this message]
2020-11-14 11:37 ` Marc Zyngier
2020-11-14 12:45 ` Thomas Gleixner
2020-11-22 5:53 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e552f6a9-8b82-f446-d67d-2f666870c766@linux.ibm.com \
--to=fbarrat@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=cai@lca.pw \
--cc=clg@kaod.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®