From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Xichao Zhao <zhao.xichao@vivo.com>,
Andi Shyti <andi.shyti@kernel.org>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"open list:SAMSUNG SPI DRIVERS" <linux-spi@vger.kernel.org>,
"open list:SAMSUNG SPI DRIVERS"
<linux-samsung-soc@vger.kernel.org>,
"moderated list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 6/6] spi: s3c64xx: Remove the use of dev_err_probe()
Date: Tue, 19 Aug 2025 11:00:01 +0100 [thread overview]
Message-ID: <e55326b7-7f52-4497-897b-32d67f522cd5@linaro.org> (raw)
In-Reply-To: <20250819092044.549464-7-zhao.xichao@vivo.com>
On 8/19/25 10:20 AM, Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
> remove the useless call to dev_err_probe(), and just return the value instead.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> drivers/spi/spi-s3c64xx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index b1567243ae19..3a00f9e480c5 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1268,8 +1268,7 @@ static int s3c64xx_spi_probe(struct platform_device *pdev)
>
> host = devm_spi_alloc_host(&pdev->dev, sizeof(*sdd));
> if (!host)
> - return dev_err_probe(&pdev->dev, -ENOMEM,
> - "Unable to allocate SPI Host\n");
> + return -ENOMEM;
>
> platform_set_drvdata(pdev, host);
>
next prev parent reply other threads:[~2025-08-19 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 9:20 [PATCH v1 0/6] spi: " Xichao Zhao
2025-08-19 9:20 ` [PATCH v1 1/6] spi: spi_amd: " Xichao Zhao
2025-08-19 9:20 ` [PATCH v1 2/6] spi: SPISG: " Xichao Zhao
2025-08-19 9:20 ` [PATCH v1 3/6] spi: " Xichao Zhao
2025-08-19 9:20 ` [PATCH v1 4/6] spi: mt65xx: " Xichao Zhao
2025-08-19 9:20 ` [PATCH v1 5/6] spi: pxa2xx: " Xichao Zhao
2025-08-19 9:20 ` [PATCH v1 6/6] spi: s3c64xx: " Xichao Zhao
2025-08-19 10:00 ` Tudor Ambarus [this message]
2025-08-19 18:52 ` [PATCH v1 0/6] spi: " Mark Brown
2025-10-09 1:07 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e55326b7-7f52-4497-897b-32d67f522cd5@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®