From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1558C2D738F for ; Wed, 22 Jul 2026 05:54:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784699676; cv=none; b=G7PALIKoCspQeWQ1kfK0EjNTjoja7poAbz8fjdg7XR7fKSktHuMD2W41gBq4rm0ksBNN+h4oJFBVDN0eUMQDcLCSaBSpYr4L4OIG6KSrkOWknROV26PSF9Ut5Pq7ZCZNYgbEwIf/Y/267fJov0ibpoeVO0Wg9VslbUSQmNxY23Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784699676; c=relaxed/simple; bh=coIzcvjb5ugtfK8437kbcjC7ap5uoz1cbPxQzWjRx4g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FQ6JJfcmVILowNG4qTzYOMxMwKJ4l0jlB8sSsjYYrKh0PY864NBGN3V0Nv5ZRYba4G+U2nGudcLIn3mGyNhEjGtBx27AD1qe07xSOPcNpNbG+ukXTzmd6LkWcbqaDrL1RnwHGuacdvQ8ZmlASnPUMCpGDrbfCRsK7s3ITUxT28M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CDcw0KjE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KfYIdDq6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CDcw0KjE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KfYIdDq6" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M54YEe3474861 for ; Wed, 22 Jul 2026 05:54:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vULQwCAmlohXfO2djgyMjy/psAkw3bTqxi1rFQrNtZE=; b=CDcw0KjESN4QgTAM iyKOHB7Yj4nWkKKS2108Zbt7nuWXFUj8yzRUWZ2EzPyElrmFpXy9B6IHYfn8t17y Yz0RpRe3Oj2o+8b8P8BObC+SOoIvboN0SH/7ekT4eGXV2wnHiAkq/4zsrVPwuJ6+ GXoPKAdTyzCx9gDLdOAtsTm5NT67ZVVcJCGBZsdcWY+i+sJhZokvEY1QxyAw5zgx m/a1B4lXgovOAyEQF2hBijBNlz8qzlcRRZ6o0UUvg98h8YZpF+cmmVr9AHuMfW83 Twhll7/sGGDwVSYOVfn8qk54jf1Y4lDrzHuQ3+FYmOde9dEetHlOnn1y63ABTlcV blyECQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjd6ftewc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 05:54:34 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-ca124bf0189so4123719a12.0 for ; Tue, 21 Jul 2026 22:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784699674; x=1785304474; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vULQwCAmlohXfO2djgyMjy/psAkw3bTqxi1rFQrNtZE=; b=KfYIdDq651VUm6kDrwXyviWBmmWA0hHCGVEmgcAM5p/ZaMLN224pxsv7rT8ZTZb+m7 6g40/3nFn4VZQXYk/ssH7HcIpoPQ5nw5S3viIHXeZMypMRMgNwnWnF9mEbjyPmiLYH1i 4sPPOtUZTL+kDAGtG+9FN9xwTclinWthF6Y9I1FNwcJUrsItFzULuAurBBK2V5eCzk2V +h57HpxG992R3viDIVAz62AfRhbyc2/Ngq9LE7LSqJw0n4tu4EXk80wpqv6HMNsNfYmk /PZ0S2sUlqS1Bngt5sANEqFswC4fn9e4SPgcbEpm8HxEo1/Fy6ZkItH9vFjhDqS0gI52 eDjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784699674; x=1785304474; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vULQwCAmlohXfO2djgyMjy/psAkw3bTqxi1rFQrNtZE=; b=jL2KBI4QTKAWeuFRcplmg2P5yRaVL/y3N2VJIMTr7wI6p55L5WP+Ao/tUu1J/t+ewL G/tT8X2d8qNrIa44P41esS9+ZQ09X0egsepw2xnY+MrRJD41/vNd8JvwlrcytKYmj/Gx 2Qjrn3MALQPoUbSXJhwSowNFs7CaP44Ao4/otjdEBQLwQ4juTvpLtjPvyNQvafEPAbVe ycNXUWUXE7xcLjZnYd4ri35fQxKxdqgfkYAHnzQch3QTMzGFORsJ44A3Oo9NDEmwUcIx EeUVwQZ7EWPdS6DnQVUt/4tp+KA6nYXKYQTY9vcfdoh/LBP3gD3+8dnuYE5WAX4gp5jk IzsQ== X-Forwarded-Encrypted: i=1; AHgh+RqIc7elW7t5gScqGrh0QGnmhwZZii3tRN8kI+LXjy9A/YeHVluis8tCCpTNk7N7Q6mtKzL7sHW/C53u1cM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3ekFX128/jRjot7TTYjNR6XLepiC+fx9OokYrVRoxQwLHm/AH nNKppNfmVHOJmwu9xYvRfbdkYe5IRFD3tcvNiClEYAyeKFHk8Ws4aXwvKSdSDuTaDbJRQIo9yBs rNwAX/PM3qoe5hZdg682pjpuluZ3hgMG4QhSM5QVSDuRQh9gV+8ixqUEaOVIfQx2CKSrftP4tyd M= X-Gm-Gg: AR+sD10iI1tAE873c7KRORvqyXBkjKIKz4yw8WJh8qXLZn8sp+2K7pZQSu2EY0MCcj7 f751TQ2UnO9pqoFAIG2kRuWfqTCNO/o2lK5qaC54r6EMJew92oa4aCDUloyMPHBjkr49L1BlagD 5WLKkA4ZS/5Eta7dYYz6+HZHdSDJQrpu1zMBZRkOfXgSeCqs8G0kvOL0HGN7ej65+V6XJtf/Yz7 LYSGUOna4uGHfCg88snuFYcEGgUyJwSoh0Mg8tU2WGXww/g9D4jVHvKscy5rq74xd7GOYZPmZFM eRo5FMmUEd6Hk7QcP8F0ljAnh0rxTA9BYkxl4vi3tQgOu+Cd/74964zy4By8r0TVXVzVaN2xhAC jnyJIh8GzEOjWuQ8MWcJMhcjU+2A2NRAAOFY= X-Received: by 2002:a05:6a21:1b81:b0:3a2:ed4a:5d7e with SMTP id adf61e73a8af0-3c429456cbcmr2634326637.22.1784699673325; Tue, 21 Jul 2026 22:54:33 -0700 (PDT) X-Received: by 2002:a05:6a21:1b81:b0:3a2:ed4a:5d7e with SMTP id adf61e73a8af0-3c429456cbcmr2634292637.22.1784699672896; Tue, 21 Jul 2026 22:54:32 -0700 (PDT) Received: from [192.168.0.172] ([49.205.252.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1b99esm5101865eec.3.2026.07.21.22.54.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 22:54:32 -0700 (PDT) Message-ID: Date: Wed, 22 Jul 2026 11:24:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 04/18] media: iris: Filter UBWC raw formats based on hardware capabilities To: Bryan O'Donoghue , Dmitry Baryshkov Cc: Abhinav Kumar , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal References: <20260709-iris-ar50lt-v7-0-76af9dd4d1f6@oss.qualcomm.com> <20260709-iris-ar50lt-v7-4-76af9dd4d1f6@oss.qualcomm.com> <5d213d08-8e00-4e7e-93ae-ba05f22f09e7@oss.qualcomm.com> <2323abe7-ecd3-4504-8790-ef1a2dacec8f@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: qMHhWDOsh6iEVQ67ipwGQeci96zUAdCl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA1MiBTYWx0ZWRfX4/wWztI8/bIT zm+gaAZ6TS0Vtu+Em9HGNkBvKJyl6yt/SRUp5YS8DpBDsBJFrbys2HigP2BoQxy0viVyZ2NJPae KwX+NLnDuuM2R7Yqbxi26ZjZOsVnjq+ea0KB4NmyOekRT0sTKwosJ9dykkYGzMFrGu1Oo+4T98O X2EHwJsH0dZmOf59OQZ1f48gwZBgDL7nHvvqrG87tdwgiILMgsyKTI+b/MuTld8/crZK3lbeLfO lviOdnq/7KIKP2oqNW3GAU2Br3fswx8exNvriXSjCSKKy+uB+Tx75kIFy+gTo1rcHtvk5+pFD/e VSVkhBPbgFsqdsMUqQ9aGZV6lAXetQ8soPhkw8glPiTZ8gGS3TQrnpp7yYSZj9+Oo3XPoS+OLHn YKw+EAtL//7g5oaBBWw6GvBmZNkBZSFyi6bzp2+i10oDynBBYJrt68zb+BVpAa4r2T/tSdxURj/ zLc4nLdsBnRj5Rf+Zpw== X-Authority-Analysis: v=2.4 cv=e/o2j6p/ c=1 sm=1 tr=0 ts=6a605b1a cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=7QKhCc/PCtuziN3cdRcg/A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=YfwmlBJXWq4pewXu0PsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-ORIG-GUID: qMHhWDOsh6iEVQ67ipwGQeci96zUAdCl X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA1MiBTYWx0ZWRfX3dqvDZ2swem1 8gH//r8eASdbCF645ROlKsZwLPn+mPYYQayoY4YWEyCqQnFYEW+HbckRcY9nKWLJWcmFTcx09pQ E+Ztfv1a6yNcfsPzQZtC/b8HHCAqBQM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_02,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220052 On 7/22/2026 3:46 AM, Bryan O'Donoghue wrote: > On 21/07/2026 17:23, Vikash Garodia wrote: >> >> On 7/21/2026 8:34 PM, Dmitry Baryshkov wrote: >>> On Tue, 21 Jul 2026 at 17:08, Vikash Garodia >>> wrote: >>>> >>>> >>>> On 7/9/2026 7:11 PM, Dmitry Baryshkov wrote: >>>>> From: Dikshita Agarwal >>>>> >>>>> The raw formats supported by Iris were previously advertised >>>>> unconditionally, assuming UBWC support on all platforms. However, some >>>>> platforms do not support UBWC which results in incorrect format >>>>> capability exposure. >>>>> >>>>> Use the UBWC configuration provided by the platform to dynamically >>>>> filter raw formats at runtime. If UBWC is not supported, UBWC-based >>>>> formats are omitted from the advertised capability list, while linear >>>>> formats remain available. >>>>> >>>>> Signed-off-by: Dikshita Agarwal >>>>> Signed-off-by: Dmitry Baryshkov >>>>> --- >>>>>     drivers/media/platform/qcom/iris/iris_vdec.c | 26 +++++++++++++ >>>>> +++++++++---- >>>>>     drivers/media/platform/qcom/iris/iris_venc.c | 25 +++++++++++++ >>>>> ++++++++---- >>>>>     2 files changed, 43 insertions(+), 8 deletions(-) >>>>> >>>>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/ >>>>> drivers/media/platform/qcom/iris/iris_vdec.c >>>>> index 4c8bc7aac135..9fee5f28097d 100644 >>>>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c >>>>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c >>>>> @@ -3,6 +3,7 @@ >>>>>      * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All >>>>> rights reserved. >>>>>      */ >>>>> >>>>> +#include >>>>>     #include >>>>>     #include >>>>> >>>>> @@ -69,8 +70,14 @@ static const u32 iris_vdec_formats_cap[] = { >>>>>         V4L2_PIX_FMT_QC10C, >>>>>     }; >>>>> >>>>> +static const u32 iris_vdec_formats_noubwc_cap[] = { >>>>> +     V4L2_PIX_FMT_NV12, >>>>> +     V4L2_PIX_FMT_P010, >>>>> +}; >>>>> + >>>>>     static bool check_format(struct iris_inst *inst, u32 pixfmt, >>>>> u32 type) >>>>>     { >>>>> +     const struct qcom_ubwc_cfg_data *ubwc = inst->core->ubwc_cfg; >>>>>         unsigned int size, i; >>>>>         const u32 *fmt; >>>>> >>>>> @@ -80,8 +87,13 @@ static bool check_format(struct iris_inst *inst, >>>>> u32 pixfmt, u32 type) >>>>>                 size = inst->core->iris_platform_data- >>>>> >inst_iris_fmts_size; >>>>>                 break; >>>>>         case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE: >>>>> -             fmt = iris_vdec_formats_cap; >>>>> -             size = ARRAY_SIZE(iris_vdec_formats_cap); >>>>> +             if (ubwc->ubwc_enc_version) { >>>> >>>> Do you see a possibility that ubwc is enabled for a SOC while VPU >>>> hardware does not support UBWC. IP document for qcom,qcm2290 lists some >>>> UBWC configuration, while VPU does not support UBWC. Not sure at this >>>> point if other blocks indeed support UBWC for qcom,qcm2290. >>> >>> No, QCM2290 doesn't really support UBWC between the IP cores (as such >>> it has ubwc_enc_version = 0). >>> Currently the database defines a least common denominator for all IP >>> cores. If we ever get to a point where we want to define UBWC params >>> per the core, we will need to restructure the database. >>> >> >> Ack. >> >> > > Ack-by ? The ack here was to acknowledge the explanation provided towards a specific case. R-B tag provided earlier on this patch stands good. > > --- > bod