Re: s2idle stopped working with 6.6-rc on Thinkpad T14 G1 (AMD)

[Mario Limonciello <mario.limonciello@amd.com>]

On 9/25/2023 05:55, Thorsten Leemhuis wrote:
> Hi Mario! Did you by chance hear anything about lock-ups on resume with
> mainline affecting AMD systems? I'm asking, as s2idle stopped working
> for me with 6.6-rc on my Thinkpad T14 G1 (AMD). 

You're the first report I've heard of this.  I've personally done s2idle 
on 6.6-rc1 + patch to fix the UCSI issue and 6.6-rc2 on a newer model 
(Lenovo Z13).

I haven't checked 6.6-rc3.

> I'm as of now not sure
> exactly when the problem started, as 6.6-rc1 didn't boot for me due to
> another regression fixed for -rc2. But 6.6-rc2 was affected and -rc3
> still is. Haven't found time for a bisection yet and will unlikely to be
> so in the next two or three days, that's why I thought "ask Mario, with
> a bit of luck he might be aware of a problem or even a fix".
> 

For any bisect steps that are failing to boot, I suggest you either 
compile without UCSI support (it shouldn't be critical) or apply

f26a679ed799 ("usb: typec: ucsi: Fix NULL pointer dereference")

> FWIW, I ran your amd_s2idle.py script, but the machine seems to lock up
> hard on resume, so I guess it's not much or help.
> 
> https://www.leemhuis.info/files/misc/s2idle_report-6.5.4-2023-09-25.txt
> https://www.leemhuis.info/files/misc/s2idle_report-6.6_rc3-2023-09-25.txt
> 

Yeah not too much useful stuff here unfortunately.  Can you check 
/var/lib/systemd/pstore to see if you got a traceback for whatever 
caused the problem?

> Dmesg for 6.6-rc3 (with a USB-C dock, but problem happens without it, too):
> https://www.leemhuis.info/files/misc/dmesg-6.6_rc3
> 
> Ciao, Thorsten
> 
> #regzbot introduced v6.5..v6.6-rc2

Being G1, can you try "amdgpu.mcbp=0" on kernel command line?