From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751323AbdFBTcC (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Jun 2017 15:32:02 -0400
Received: from resqmta-po-05v.sys.comcast.net ([96.114.154.164]:51110 "EHLO
        resqmta-po-05v.sys.comcast.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751218AbdFBTb6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Jun 2017 15:31:58 -0400
Reply-To: shuah@kernel.org
Subject: Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to
 dependencies
To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>,
        linux-kernel@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>,
        Jonathan Corbet <corbet@lwn.net>, Kees Cook <keescook@chromium.org>,
        Will Drewry <wad@chromium.org>, linux-doc@vger.kernel.org,
        linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
        Shuah Khan <shuahkh@osg.samsung.com>
References: <20170526184402.30267-1-mic@digikod.net>
 <20170526184402.30267-4-mic@digikod.net>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <e5611a2c-7348-7059-8b26-de0d7cd77ccb@kernel.org>
Date: Fri, 2 Jun 2017 13:31:50 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170526184402.30267-4-mic@digikod.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-CMAE-Envelope: MS4wfJHzc22tgpC7+MUHk4pePdm1+zc5mJFdEpgdQLSm2rvckNkI41ZJrMg9QJkP0luHtQUPpxTe6IoM5LcMeVePjj+2+xr+17gVwh3Wk7WRKoqMjvi8cE8s
 dnhSqj0W4Oma5kwwY09ihoccpT3r0yD+DMCRZ0KJU+afj1eCdJ/a/C4/ZTbkLkWD8W7dYyFYsnoTFi9DhRnFeD18PwVHd8toP9TWgSJrhDrAt9CajfqtyVAF
 RWzr0jmOtPVq6gJrkG8tp2gevT5AzZG/y8q8aPRUkI7N4eW7vTvaGQt1b3URT9IDwKWrOmXYLdVNpWvOT9nfEggXuvqSmPru3iNvOpwlXDuBrduh0Y+Vw7Yr
 ElaJhQjJJ82GCQAK3n8rngh3Nn6h3X1aQD7wOLaWfz+Yv+Kpi2n32CT72RMcoR8ch49hcz/HxyFXzecWgynBSuVim0tf1CpwxA3AkUeqMdIsXlzdf6M=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mickaël,

On 05/26/2017 12:43 PM, Mickaël Salaün wrote:
> Rebuild the seccomp tests when kselftest_harness.h is updated.
> 
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Acked-by: Kees Cook <keescook@chromium.org>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Will Drewry <wad@chromium.org>
> ---
>  tools/testing/selftests/seccomp/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile
> index 5fa6fd2246b1..aeb0c805f3ca 100644
> --- a/tools/testing/selftests/seccomp/Makefile
> +++ b/tools/testing/selftests/seccomp/Makefile
> @@ -4,3 +4,5 @@ LDFLAGS += -lpthread
>  
>  include ../lib.mk
>  
> +$(TEST_GEN_PROGS): seccomp_bpf.c ../kselftest_harness.h
> +	$(CC) $(CFLAGS) $(LDFLAGS) $< -o $@
> 

This change breaks seccomp build:

make -C tools/testing/selftests/seccomp/
make: Entering directory '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp'
make: *** No rule to make target '../kselftest_harness.h', needed by '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'.  Stop.
make: Leaving directory '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp'
shuah@mazurka:/mnt/data/lkml/linux_4.12$ cd tools/testing/selftests/seccomp/
shuah@mazurka:/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp$ make
make: *** No rule to make target '../kselftest_harness.h', needed by '/mnt/data/lkml/linux_4.12/tools/testing/selftests/seccomp/seccomp_bpf'.  Stop.


Did you happen to try building with this change?

thanks,
-- Shuah