From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493EAC433F5 for ; Mon, 21 Mar 2022 14:52:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349747AbiCUOxh (ORCPT ); Mon, 21 Mar 2022 10:53:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349859AbiCUOxP (ORCPT ); Mon, 21 Mar 2022 10:53:15 -0400 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0942754F8A; Mon, 21 Mar 2022 07:51:49 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R891e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0V7r0Du3_1647874305; Received: from 192.168.31.65(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0V7r0Du3_1647874305) by smtp.aliyun-inc.com(127.0.0.1); Mon, 21 Mar 2022 22:51:46 +0800 Message-ID: Date: Mon, 21 Mar 2022 22:51:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v5 06/22] cachefiles: implement on-demand read Content-Language: en-US To: David Howells Cc: linux-cachefs@redhat.com, xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org, torvalds@linux-foundation.org, gregkh@linuxfoundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com, tao.peng@linux.alibaba.com, gerry@linux.alibaba.com, eguan@linux.alibaba.com, linux-kernel@vger.kernel.org, luodaowen.backend@bytedance.com References: <20220316131723.111553-7-jefflexu@linux.alibaba.com> <20220316131723.111553-1-jefflexu@linux.alibaba.com> <1029512.1647871543@warthog.procyon.org.uk> From: JeffleXu In-Reply-To: <1029512.1647871543@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/22 10:05 PM, David Howells wrote: > Jeffle Xu wrote: > >> + { "cread", cachefiles_ondemand_cread }, > > Rather than adding the cread command, would it be better to use an ioctl on > the anon fd as the /dev/cachefiles write op is serialised? Sounds reasonable. I will try it in the next version. Thanks. > >> + /* Stop enqueuig request when daemon closes anon_fd prematurely. */ > > "Enqueuing" Wow.. Maybe I need to update my checkpatch... -- Thanks, Jeffle