From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A67E4283C9D for ; Thu, 4 Jun 2026 03:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780544650; cv=none; b=f9XEouJuiJ13IQNhK8Kmi30Fz/bZTiGX3a5dEMeiMpoSCbImsSRnp30iJvJT5b7jkM/B99gLcbqAEtMNf1V2eXzzCzzEGwnb2uRZ1NgFLKdAvkqSQYf2p0lYHj7zfxlHWx8K/beuTw0psjuco+R7gkYB3G6NYAqFc/Awm4rabbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780544650; c=relaxed/simple; bh=GVUrTFHWfKbP7BPQBwxHjJiAldO45+2g44/XMUp4QN8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p75e5AYFEFMa5u9UeqANW8EPUbh0YQ3qhSk3fMaiY46EQuyZ+LRMXTVfkCqlSfIfBWqvl0luQ9sxllbN5L6tN3RppUOibASJ9qEQN9g2graoVGbj7auMwBWw1eDT0bIifNdDyP8lnu2b9u0z0DWfP4Vs7nIlR1nB+dRk78YpJ4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cm/xXaND; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cm/xXaND" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2c0c274f362so961465ad.0 for ; Wed, 03 Jun 2026 20:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780544649; x=1781149449; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dzk72M4ewlzxGUDCkZjiIwUqM5Q/ys2Vzl6V4FwZ3I0=; b=cm/xXaNDWZc6oiRkYiEf3rhI5Frq8BcsTM1UEm2qaHQvktdYOZN/Lj1rPnYwq7ts60 k36L6mfiY3xKnFBaCLH7tjRWHaZW6D6t5FJeYqFWLEjHKmRiByEJEm/RzXaGMhAhpdoi Colrdn8Jxh8TMaKjgDgFWDBddXIEaNQvOgoKMfSiHcXeq4xfycXeQGWCER5uDnKOd/Hm 1/+sYJrINtKiRg4nL8pqmljlsl5wTqumsktClDX8yhE+dWExpxnX9zFl+m0jpg8mu8cT q4UssRPU3sHZX1gFO5m4zve+Olxd0U5d8/qR+mOVFTwV+9iT7bgMZbEnZj8L0T8tSJQN zjcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780544649; x=1781149449; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dzk72M4ewlzxGUDCkZjiIwUqM5Q/ys2Vzl6V4FwZ3I0=; b=klpxnga1gqqtdOMWQ4vMX6MLprk20ebR028KVPIU+dxBytqFGRQc5WTyCv7WZ1CRax xIM9FA9uOecaw4TQB8eGrQ58jYA3xRcYjQBbFkG1vLBMkVKKY/UOGYVcFk/Fud5XVLEf 6sj6TRNGt7VV58g3u/SoOeoNsJzdNDRDPZD3pncehdVcgT1jOafTqF1/4sE1aCq7Euu0 lSVYcP/10ajsMeg00C7ycmd1njx2kVcG3fkTEvzOHUpbr1JrVwota5CEJwm9n2K5sDEJ ewkirdw190wzOKEkFStbMocEEzm8zBeTK1392j1ICiAA5AC3yq4vg6/oZiqfxewpYxmV 6nJA== X-Forwarded-Encrypted: i=1; AFNElJ8jLBUSSvUsYdyT+WeLJNND1TDFwv1Qwr7mn/QkjuPKf89erxOPN8o8Yz76nTE6HqPwrEhb1I4e/IQZFlQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyjPV6sGnKDy/mZ2ZvVwOUWPd6b3FG+eBcZpV0u7rS9a0kSD0pO 7EOtsFzcbtZiddgC3Qh0J7AxnfyDF6j7UeIi/0wXswnxxxDTUw4P91ZX X-Gm-Gg: Acq92OHA0btmDv5KT+Eq8GJcbxrd0wO/692YGdoXJDi83p5mGJsCFMEmTepojz5ESpw HehZ5G6RQGXJXPmAYv7r6XfyrLPMAci1KP3p1seAQ562xFp6CybNMHft4q1Auzzu9zXwborQpMO Pkr2vQG52cLHRuIAiFaBeYOLbm0EVzc2pb1JB9LJJw6Xjs9dbolRuAWHavMqUKdehbmRvNYh4Vk epSNvAi0NLH+08/L6ZinzFyH/ijtsOXoRmjNTvGTamnsDJhilxuFwPqLwG4F+cQ63HbnN4jX0Pr 22x2xkGuL6So4DF5LN0eRf130eEQRdYiQOAmXUIdenj/oUjeZopuq0D5hKsAoPdMZK6LbWyLsJo p/nieaZEbBGQXcfd9qQxoJEH/dTJah99/XlOB25xUe5c5bNNyfPvlgD8blMAVM96iD8I/TFcpbF AuSah5Xs/3u5n81y4wJrVxANlF/+bSouDbNakCb5CQ4aDE X-Received: by 2002:a05:6a21:1519:b0:38b:d93f:bbf5 with SMTP id adf61e73a8af0-3b4b8115151mr578811637.0.1780544648870; Wed, 03 Jun 2026 20:44:08 -0700 (PDT) Received: from [192.168.1.7] ([159.192.166.161]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c85df043216sm3684818a12.10.2026.06.03.20.44.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 20:44:08 -0700 (PDT) Message-ID: Date: Thu, 4 Jun 2026 10:44:03 +0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] USB: serial: option: add new usb-id for Dell Wireless DW5826e-m To: jackbb_wu@compal.com, Johan Hovold , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260604-dw5826e-option-driver-v2-1-00609f65f5ae@compal.com> Content-Language: en-US From: Lars Melin In-Reply-To: <20260604-dw5826e-option-driver-v2-1-00609f65f5ae@compal.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-06-04 09:04, Jack Wu via B4 Relay wrote: > From: Jack Wu > > Add support for Dell DW5826e-m with USB-id 0x413c:0x81ea > > T: Bus=03 Lev=01 Prnt=01 Port=04 Cnt=01 Dev#= 8 Spd=480 MxCh= 0 > D: Ver= 2.10 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=413c ProdID=81ea Rev= 5.04 > S: Manufacturer=DELL > S: Product=DW5826e-m Qualcomm Snapdragon X12 Global LTE-A > S: SerialNumber=358988870177734 > C:* #Ifs= 7 Cfg#= 1 Atr=a0 MxPwr=500mA > A: FirstIf#=12 IfCount= 2 Cls=02(comm.) Sub=0e Prot=00 > I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=usbfs > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=60 Driver=option > E: Ad=84(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=40 Driver=option > E: Ad=86(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 4 Alt= 0 #EPs= 1 Cls=ff(vend.) Sub=ff Prot=ff Driver=option > E: Ad=87(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I:* If#=12 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=0e Prot=00 Driver=cdc_mbim > E: Ad=88(I) Atr=03(Int.) MxPS= 64 Ivl=32ms > I: If#=13 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > I:* If#=13 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=02 Driver=cdc_mbim > E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=0f(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > > Signed-off-by: Jack Wu > --- > - Link to v1: https://patch.msgid.link/20260601-dw5826e-option-driver-v1-1-e0a0a72cfe1b@compal.com > > To: Johan Hovold > To: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > v2: > - Blacklist interface #1 (ADB) using RSVD(1) > --- > --- > drivers/usb/serial/option.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 48ae0188f2e9..070e0c553d7a 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -203,6 +203,8 @@ static void option_instat_callback(struct urb *urb); > #define DELL_PRODUCT_5829E_ESIM 0x81e4 > #define DELL_PRODUCT_5829E 0x81e6 > > +#define DELL_PRODUCT_DW5826E_ESIM 0x81ea > + > #define DELL_PRODUCT_FM101R_ESIM 0x8213 > #define DELL_PRODUCT_FM101R 0x8215 > > @@ -1125,6 +1127,8 @@ static const struct usb_device_id option_ids[] = { > .driver_info = RSVD(0) | RSVD(6) }, > { USB_DEVICE_INTERFACE_CLASS(DELL_VENDOR_ID, DELL_PRODUCT_FM101R, 0xff) }, > { USB_DEVICE_INTERFACE_CLASS(DELL_VENDOR_ID, DELL_PRODUCT_FM101R_ESIM, 0xff) }, > + { USB_DEVICE_INTERFACE_CLASS(DELL_VENDOR_ID, DELL_PRODUCT_DW5826E_ESIM, 0xff), > + .driver_info = RSVD(1) } > { USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_E100A) }, /* ADU-E100, ADU-310 */ > { USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_500A) }, > { USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_620UW) }, > > --- > base-commit: e43ffb69e0438cddd72aaa30898b4dc446f664f8 > change-id: 20260601-dw5826e-option-driver-e9bac038e2b5 > > Best regards, > -- > Jack Wu > > > Thanks, it looks fine to me now Reviewed-by: Lars Melin