From: Guenter Roeck <linux@roeck-us.net>
To: "Blaž Hrastnik" <blaz@mxxn.io>,
"Jean Delvare" <jdelvare@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>
Cc: David Bartley <andareed@gmail.com>
Subject: Re: hwmon: (nct6683) Support ASRock boards.
Date: Mon, 18 Jan 2021 21:49:52 -0800 [thread overview]
Message-ID: <e57954ca-b2df-bb61-5717-51d63b4cd8d4@roeck-us.net> (raw)
In-Reply-To: <d5630b5e-52ec-4fc7-b8f3-ac219d0bfbbb@www.fastmail.com>
On 1/18/21 9:15 PM, Blaž Hrastnik wrote:
> (cc-ing David Bartley, who wrote the MSI patch)
>
> I had a follow-up question: I noticed that support for MSI was added in
> December, but there's this conditional that wasn't changed:
>
> /* Only update pwm values for Mitac boards */
> if (data->customer_id == NCT6683_CUSTOMER_ID_MITAC)
> return attr->mode | S_IWUSR;
>
> Should this continue to only apply for Mitac boards, or should it be changed to
> != NCT6683_CUSTOMER_ID_INTEL?
>
No, this has to be tested explicitly for each vendor.
Guenter
next prev parent reply other threads:[~2021-01-19 6:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 5:12 Blaž Hrastnik
2021-01-19 5:15 ` Blaž Hrastnik
2021-01-19 5:49 ` Guenter Roeck [this message]
2021-01-21 19:25 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e57954ca-b2df-bb61-5717-51d63b4cd8d4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andareed@gmail.com \
--cc=blaz@mxxn.io \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®