From: Dan Carpenter <dan.carpenter@linaro.org>
To: "Moritz C. Weber" <mo.c.weber@gmail.com>
Cc: marvin24@gmx.de, ac100@lists.launchpad.net,
linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: nvec: nvec: fixed two usleep_range is preferred over udelay warnings
Date: Mon, 12 Feb 2024 16:55:09 +0300 [thread overview]
Message-ID: <e57cb313-77da-47c3-be5a-93725a52707f@moroto.mountain> (raw)
In-Reply-To: <20240212133645.1836-1-mo.c.weber@gmail.com>
On Mon, Feb 12, 2024 at 02:36:45PM +0100, Moritz C. Weber wrote:
> Fixed a code style issue raised by checkpatch.
Needs Signed-off-by. Please run your patches through checkpatch.
> ---
> drivers/staging/nvec/nvec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 2823cacde..18c5471d5 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -627,7 +627,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
> break;
> case 2: /* first byte after command */
> if (status == (I2C_SL_IRQ | RNW | RCVD)) {
> - udelay(33);
> + usleep_range(32, 33);
We only accept these udelay() -> usleep_range() patches if they have
been tested on real hardware. Sorry.
regards,
dan carpenter
next prev parent reply other threads:[~2024-02-12 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 13:36 Moritz C. Weber
2024-02-12 13:55 ` Dan Carpenter [this message]
2024-02-12 14:21 ` Nam Cao
2024-02-16 11:53 ` Thierry Reding
2024-02-18 17:42 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e57cb313-77da-47c3-be5a-93725a52707f@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=ac100@lists.launchpad.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=mo.c.weber@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®