From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=158.69.130.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795105505; b=mFs5cIRiM5WHHrCmeiBjCTH9D3MkW8RHjy6rMjUtZC+4XZs7uGVb6GHNdH0zuGMDyFlG O1tYPBqROIUMvxwG+ctbSQaJdcWpoIkZdLbeycGEEDBBn1KlDBQEaZpzzNCYcznP5Pl/t i1uzdC4T4uVSmv/ee32GrRRv7paozjSzDvYPnyoQcSYYC+PV9Hv76AbGc6kxqgLxHuA2a okehDGJEeVO1hB+uLBMgSzv54ZQyVmZE+bnsRfjoDtLRCjreZ23Tx2WQYnFtNthDZWSVs WpZxW5XdmvUBzDcqRBTThXoBkueSikAjskdNC1S720ShaUJhDiTmB7pMWkFg+s/+kfg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795105505; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-Id:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=18ZdUzzadRsL6aFCNsE+0dn3GNsx1KvXA2R8ZIV+JwY=; b=ep0U4GD78TSuyMvKlUoJXLw35ADVCWJGfsvcFn1qf4pn0d9WZuRQZqYZ/robYWLN1YoG r7h/tX6b5zpaEv48t1GkvwDBei5DjyivVQ7uCM2qWnw3aRK34PHm4heQGfOp6sFz1y2vH KUPRjv4ShTlMmeyB3LsHk0vrNH772W/HUixzPCJsbBYl07JffByhFLe6B9CJyHdmQ70M+ fF53FZgatOLfUMakpHiLHArOxE0cSz1Y4Md4bNHZU3jYc1YroLf9+XzHpomYacV+nKjCf Qr2IeYTVe1wJySRU1H+1XvYR4uw/3NH0qVkvtdPB0cKuwcaiH9hLUhM1gD7aYXq1WFA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b="N5jkM/2O"; arc=none smtp.remote-ip=158.69.130.18 Received: from smtpout.efficios.com (smtpout.efficios.com [158.69.130.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC48B60A2633; Thu, 19 Nov 2026 16:25:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CC48B60A2633 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=smtpout1 header.b=N5jkM/2O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=smtpout1; t=1795105503; bh=18ZdUzzadRsL6aFCNsE+0dn3GNsx1KvXA2R8ZIV+JwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N5jkM/2OsYWwYxASdQwUH7EaftABouOuQEsDi4BNWscmGmwiXu3NqLHRSCRUgyNU1 Zf66kPEgx+J5t8Nso1+XCHjewfAnwqIZ42E0+v84AHAZ08i/Il2WH3rB7/Lz2iC1zq 1Vs2amEFd0ANeZh5w8DFhPZsOwWpAVQZ+khK7lMJZas4KwSyq4sOSFFpbfwZEo1OCW ydauzjobqF4PjZejgFKYlRaNNmiWySt9Wp5fR/+vezK5BUbYK0c/KY/+jWKpy0bC51 uqd/pCl2UIOhjEZwIYPAC07uUewTKRemB10OH+p/H+5RfQjmF3HuLYbhAjugelgVBR 4DBfe94P9GtEA== Received: from thinkos.internal.efficios.com (mtl.efficios.com [216.120.195.104]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4jVkMg03Z4zTnK; Thu, 19 Nov 2026 11:25:03 -0500 (EST) From: Mathieu Desnoyers To: juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org Cc: Mathieu Desnoyers , tglx@kernel.org, will@kernel.org, boqun@kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, kprateek.nayak@amd.com, luca.abeni@santannapisa.it, mathieu.poirier@linaro.org, longman@redhat.com, ridong.chen@linux.dev, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, shuah@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, parri.andrea@gmail.com, m.szyprowski@samsung.com, kayracizmeci@gmail.com, weihengqiuu@gmail.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: [RESEND PATCH v4 07/17] sched/deadline: Do not lose a throttled task switched out and back Date: Thu, 19 Nov 2026 11:24:47 -0500 Message-Id: X-Mailer: git-send-email 2.39.5 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A SCHED_DEADLINE task can be throttled, switched to another policy, and switched back before its 0-lag time. It may then never run again, not even to die of a fatal signal. A task that leaves SCHED_DEADLINE keeps its parameters until its 0-lag time, so that leaving and coming back gains nothing. Commit 209a0cbda7a0 ("sched/deadline: Improve the tracking of active utilization") moved their reset from the replenishment timer to the inactive timer, which switched_to_dl() cancels. This misses a task that was throttled when it left. An overrun can put its 0-lag time after its replenishment timer. That timer fires while the task is out of the class, and does nothing. On the return of the task, enqueue_dl_entity() leaves it to that timer, which has fired. The task is then on no dl_rq, with no timer pending, until it leaves SCHED_DEADLINE again. Fix this by replenishing the task when the timer finds it out of the class, as for a throttled task that is not queued. Its return then enqueues it. Clearing dl_throttled alone would not do. It would forgive the overrun. A yield left set, or the old deadline of a constrained task, would throttle the task again. The Sashiko AI review of this series found this in the first version of this patch. A cgroup selftest under development hung on this bug about once in 1350 runs. The throttled_round_trip case of deadline_switch_test, added later in this series, fails 8 times out of 8 on v7.3 and v7.4-rc2. It passes with this patch. Fixes: 209a0cbda7a0 ("sched/deadline: Improve the tracking of active utilization") Signed-off-by: Mathieu Desnoyers Acked-by: Juri Lelli Cc: stable@vger.kernel.org --- kernel/sched/deadline.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index b614d5fc1a1a..e4d7cbf4861d 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -1233,9 +1233,18 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer) /* * The task might have changed its scheduling policy to something * different than SCHED_DEADLINE (through switched_from_dl()). + * It keeps its parameters until its 0-lag time. If it comes back + * before then, nothing else would lift its throttle. So replenish + * it now, as the !queued case below does. Its return enqueues it. */ - if (!dl_task(p)) + if (!dl_task(p)) { + if (dl_se->dl_throttled && !is_dl_boosted(dl_se)) { + sched_clock_tick(); + update_rq_clock(rq); + replenish_dl_entity(dl_se); + } goto unlock; + } /* * The task might have been boosted by someone else and might be in the -- 2.47.3