mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Monish Chunara <monish.chunara@oss.qualcomm.com>,
	Rob Herring <robh@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Nitin Rawat <nitin.rawat@oss.qualcomm.com>,
	Pradeep Pragallapati <pradeep.pragallapati@oss.qualcomm.com>,
	Komal Bajaj <komal.bajaj@oss.qualcomm.com>,
	Sachin Rathore <sachin.rathore@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible
Date: Tue, 28 Jul 2026 14:20:23 +0200	[thread overview]
Message-ID: <e58778e3-86ae-483b-b52d-d3a0b0d5c59c@kernel.org> (raw)
In-Reply-To: <c99f89c1-fcae-41df-8426-9bdb3e8e9b5e@oss.qualcomm.com>

On 28/07/2026 14:02, Monish Chunara wrote:
> 
> 
> On 7/24/2026 1:24 AM, Rob Herring wrote:
>> On Wed, Jul 22, 2026 at 07:53:40PM +0530, Monish Chunara wrote:
>>> From: Monish Chunara <monish.chunara@oss.qualcomm.com>
>>>
>>> Document the SDHCI controller on Qualcomm Glymur SoC, fully compatible
>>> with existing MSM SDHCI v5.
>>>
>>> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
>>
>> Missing krzk's ack.
>>
>> Rob
> 
> I wasn't sure whether to carry over the Acked-by tag since the commit 
> message changed, so I left it out and queried on the previous series.
> 
> I'll make sure to retain it appropriately in future patches.

And where is it explained? Please quote me the cover letter explaining this.

You did not read neither kernel docs nor internal guideline.

And please explain me the logic behind your thinking - you received
comment from the reviewer and tag, you implemented the comment of
reviewer and this means that reviewer did not ack it?

How does this logic exactly work?

Best regards,
Krzysztof

  reply	other threads:[~2026-07-28 12:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 14:23 [PATCH V4 0/4] arm64: dts: qcom: Add SD card support for Glymur Monish Chunara
2026-07-22 14:23 ` [PATCH V4 1/4] arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card Monish Chunara
2026-08-12 10:39   ` Abel Vesa
2026-07-22 14:23 ` [PATCH V4 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible Monish Chunara
2026-07-23 19:54   ` Rob Herring
2026-07-28 12:02     ` Monish Chunara
2026-07-28 12:20       ` Krzysztof Kozlowski [this message]
2026-07-28 12:30         ` Monish Chunara
2026-07-28 12:40   ` Krzysztof Kozlowski
2026-07-22 14:23 ` [PATCH V4 3/4] arm64: dts: qcom: Add SD Card support for Glymur SoC Monish Chunara
2026-08-12 10:38   ` Abel Vesa
2026-07-22 14:23 ` [PATCH V4 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD Monish Chunara
2026-08-12 10:37   ` Abel Vesa
2026-08-11 12:12 ` [PATCH V4 0/4] arm64: dts: qcom: Add SD card support for Glymur Pankaj Patil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e58778e3-86ae-483b-b52d-d3a0b0d5c59c@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=komal.bajaj@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monish.chunara@oss.qualcomm.com \
    --cc=nitin.rawat@oss.qualcomm.com \
    --cc=pradeep.pragallapati@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sachin.rathore@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®