From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0908B3ACA41 for ; Wed, 21 Jan 2026 19:42:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769024580; cv=none; b=MzZyJpnlaVImpU9oAz90J89ec60WzwjjuC5LRm54ATYT+Ttf8LURELAoaHChsySzZh3ecZkCr3DV2LmJSA7aH9qNcVDkletdQybJuDrpnqe0xtiO3tENYFU/q1fRRt17UDDrRsDZy4bYUTNuH35dBUjvym7RungV7bL4rsrXhdY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769024580; c=relaxed/simple; bh=F1jquYdbse0f+h5PoDNJ9pGakn5CxPZjQwcYQH1T+jk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ojr2BpKQmDsdaofLmajzJoFbg9LSZdBNmky79B/DW1yB+sql8NgN9uarnPgjlxQWS/4nFf5SrlcQEsKWxnlM0IF3bjwVD8y/s0918K6wZtpXzHAv/9QfZ6ENnCcNwcTtiVHIH/udZ10ea3yBNmVMYfJftWlpXDY8WXubWxpve6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com; spf=none smtp.mailfrom=mojatatu.com; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b=LjYZfC7X; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20230601.gappssmtp.com header.i=@mojatatu-com.20230601.gappssmtp.com header.b="LjYZfC7X" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2b6fd5bec41so334441eec.1 for ; Wed, 21 Jan 2026 11:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20230601.gappssmtp.com; s=20230601; t=1769024578; x=1769629378; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DQvGCJmxpkROPmN9OrxKrrBVJtlOjFG6UFxmO3kVd3M=; b=LjYZfC7XW0ReDqdceYyCRzzO8cO0INzBeniWDhuOMniY2c2GQJurt3n3LxFA6n3Ikf IpCsWwWTZ9NOZhLEqy3f1zxDjNXj4kVtJVkNvXelBaKTmRLNclmi1H1TkMzLQWUtk0kq xztRmMel9QKg2MPg9Ujp30IGlj7KhYvOA1iEpS3W2bu3pP06GIwPa90jnb7qK5kaM3HN AqQXhBFsOQ3yA0MDSOgYJJBdKCIvhEadBASwf2ardiv2U0dh18g/99yGnsMl7cQm7y27 5W0q8INYGL73nq8mQMohbbQIuooL2yc2lqbMeW43c5oUvi9gOYZxjEOoRWu14MyzEXpO TR5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769024578; x=1769629378; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DQvGCJmxpkROPmN9OrxKrrBVJtlOjFG6UFxmO3kVd3M=; b=e8ae+ZzMsZq0XMIdvXT4ahmLylEq90uyf0vA5qAGp4uqefIaMP5M4uI9KRGcrb7LXb VtKiEE5eCSkoKZNVH6OAxMlZW2lq2hWsYmyS6ZkacLcjrc+M+do1fLlToBk57EuJLjf8 wU8/7V9Lqf5EyQXPVixULj8MNVYqJZ8GbmvjxO21huOQVLRYfxqx0OVggU4G6RypSGzY 6r4SOe3JPrGOcMRLqDRz/t+lr3mF3954UDgLnBEP/1+Xsr2poQWH29uwX34RRJAGgI6E uCm/Z/oh+ak4TfaZHrJ35UAHxUqvFEIwUhyuWqP/+5o95maRH0EiYaZevr9xcKuMghAp a6TQ== X-Forwarded-Encrypted: i=1; AJvYcCXy/PW4dve7AOewruL0NMb/Ks04ZyfTIsAOPV4SLdp/XhkDoj2PdhDPVraihx8FBD1dVuOwg+R8gIu1IOA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0z7eIABHwxD+QyL2jYDekGezkYowri8Wc9ofQhu9kaNDN9Sbl PRTbAHhlD3+0wOmDDzKm6dU08+0GoMNcW1i11dTGmk/Q2CQyi+QncAIiL8uO5wcrKQ== X-Gm-Gg: AZuq6aLe3OM6qNeVZEFvyamoxJCQ+USk278AVM/cgZEZxcEYrntBho1StdlvsZUkcMt xH0EmYgYd44YhJ2MitOmfT9I4icXpbTP5vwgwldPmW+oOsqr3TspWKn5BfHJNtE+9b7bnNrP/8e Gl8l36keEYEw0ikFEyYsJQvWn9ukGBREz0Z6l8v+C5q5yEk/kaqCKo9OuHCFd6230ywE9OimxtJ t4zqTjFJcbwE+VfpIkCgmTX97RxgBPf0foHSgWL+k3nZilLRa1Xh4NrH+l0G3/BrzD5MvLHvjH4 BqSeSwMt7WrvpX6xFiXElBhBWvUfWqzJZ8D2bEitc/W9TjWuPjy65F6F8t7f7gNjKD1jPll/1sW g8ad60jB0lIQrGjTbLNoHguyOHwlcAIrEHvMZMOtFsU6WyJPxnXcW24QSH5A1C2nj6b6t9mn+Id tC9FsbuLZxS4ljSoYCk7ZMj/dbTHHEar5p X-Received: by 2002:a05:7300:cd8a:b0:2b7:1320:f280 with SMTP id 5a478bee46e88-2b71320f4f2mr1913474eec.15.1769024577414; Wed, 21 Jan 2026 11:42:57 -0800 (PST) Received: from ?IPV6:2804:14d:5c54:4efb::1c9d? ([2804:14d:5c54:4efb::1c9d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7171be2dcsm3022869eec.11.2026.01.21.11.42.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 11:42:56 -0800 (PST) Message-ID: Date: Wed, 21 Jan 2026 16:42:50 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3 2/7] net/sched: act_gate: add RCU support for parameter update To: Paul Moses , netdev@vger.kernel.org Cc: Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260121131954.2710459-1-p@1g4.org> <20260121131954.2710459-3-p@1g4.org> Content-Language: en-US From: Victor Nogueira In-Reply-To: <20260121131954.2710459-3-p@1g4.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/01/2026 10:20, Paul Moses wrote: > Make gact->param RCU-protected and reclaim old params via call_rcu(). This > follows the pattern used by other actions: act_pedit swaps params with > rcu_replace_pointer() and defers free via call_rcu() (commit 52cf89f78c01bf), > act_connmark uses rcu_replace_pointer() under tcf_lock (commit 288864effe3388), > and act_tunnel_key does the same under lockdep (commit 445d3749315f34). > > Dump readers in act_ct and act_pedit already use rcu_read_lock() + > rcu_dereference() (commits 554e66bad84ce4 and 9d096746572616), so act_gate > must keep old params alive past updates as well. > [...] I think you could've transformed patches 2, 3, 4 into a single patch. Since all of them are RCU-related changes and they sometimes overwrite each other.