From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9DA1E4BE for ; Mon, 9 Feb 2026 16:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770656107; cv=none; b=Bck20fFshwrk2wa+YKJl33GGPTCVivbu2E/oSOCawrkcv4PUwAzT/D5jq+WqUrW3MiQxjOrBqG12kaEBSeoHa7yPz2KC8fdieWq1s66wehrEt1vfwGpw5e5Je9x2vjXXhlS4qxv57ZLwg3qpLRaIUVP2fxwLdzpfr2ZZ8cQhaBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770656107; c=relaxed/simple; bh=hSXngKbbYwrmuZGJVYl/CfKLEB6ffOhHPzOXI33k0Cs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HuI2gNfn0n5mUHXhCZeGKFsIhKWPkvTmWcD0lOMz0SGet0ReKrxyYh8GaUxGFRh/5EeWiANIzsojbMIXXvmFirg6u4mway5j3c546uE7DlQws6INrmC43Ijax+MczjPbSEp61+T3XgjWe7VLxwS1QabqlD71WnJam4I26LcKfPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=Ohr9qSQh; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="Ohr9qSQh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1770656101; bh=zz3AMZ0HmTG5KFhjHjUTlb4v4iJbRMJpAGoMJExp25U=; b=Ohr9qSQh21NZNvChWYAcMSQv3Rk2nW/mJfriinA+lqRcK7rY/3rrjyStzdUH8w2lQs8O5pMTF NO+DK+ip+stgok5ZQTmFoSMDoUQWQOe2egk2n5WdwveRBMUCkkBzWGxsPo5Mlz/7RQ5jceYdKGI Be6W8ov/0oCX21aRE0nqioFsoNkmF51ppNWmMQ/aU2AJaVgLz2xGDO/TybA2uDnpSU7FwoT5efz O50Pdsmn8f3MdndMXUAAFiLRpIn2UxOmV8no7VpdDzvOZWKvC1kWJs2WZmXC/UqBvgtQreOEPpX jHIcfWjCJmGEe2MWmgdimtNhzQ9k/RTnBSDe1aiBFHoQ== X-Forward-Email-ID: 698a115f438a0e4c5804a258 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.6.3 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: Date: Mon, 9 Feb 2026 17:54:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Enable OTP controller for RK3562 To: Heiko Stuebner Cc: "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kever.yang@rock-chips.com" , "finley.xiao@rock-chips.com" , "w@1wt.eu" References: <20260205212347.490636-1-heiko@sntech.de> <20260205212347.490636-2-heiko@sntech.de> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20260205212347.490636-2-heiko@sntech.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Heiko, Thanks for including my RK3528 patches :-) On 2/5/2026 10:23 PM, Heiko Stuebner wrote: > Enable the One Time Programmable Controller (OTPC) in RK3562 and add > an initial nvmem fixed layout. > > Signed-off-by: Heiko Stuebner > --- > arch/arm64/boot/dts/rockchip/rk3562.dtsi | 46 ++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3562.dtsi b/arch/arm64/boot/dts/rockchip/rk3562.dtsi > index f84676b47b27..07626dba21bf 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3562.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3562.dtsi > @@ -1093,6 +1093,52 @@ sdmmc1: mmc@ff890000 { > status = "disabled"; > }; > > + otp: otp@ff930000 { I noticed that the node names is not consistent for all three patches in this series. A quick grep at Linux src also suggest that efuse@ being the most common node name used for similar otpc/efuse, efuse is also listed under 2.2.2 Generic Names Recommendation in DT spec. Maybe the nodes should be renamed to use efuse@ or something else? I am mostly concerned on what the name ends up as and how that may affect U-Boot in a future dts/upstream sync. U-Boot currently have limited otp nodes in soc u-boot.dtsi files for these SoCs. Regards, Jonas > + compatible = "rockchip,rk3562-otp"; > + reg = <0x0 0xff930000 0x0 0x4000>; > + clocks = <&cru CLK_USER_OTPC_NS>, <&cru PCLK_OTPC_NS>, > + <&cru PCLK_OTPPHY>, <&cru CLK_SBPI_OTPC_NS>; > + clock-names = "otp", "apb_pclk", "phy", "sbpi"; > + resets = <&cru SRST_USER_OTPC_NS>, <&cru SRST_P_OTPC_NS>, > + <&cru SRST_P_OTPPHY>, <&cru SRST_SBPI_OTPC_NS>; > + reset-names = "otp", "apb", "phy", "sbpi"; > + > + nvmem-layout { > + compatible = "fixed-layout"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + cpu_code: cpu-code@2 { > + reg = <0x02 0x2>; > + }; > + > + otp_cpu_version: cpu-version@8 { > + reg = <0x08 0x1>; > + bits = <3 3>; > + }; > + > + otp_id: id@a { > + reg = <0x0a 0x10>; > + }; > + > + cpu_leakage: cpu-leakage@1a { > + reg = <0x1a 0x1>; > + }; > + > + log_leakage: log-leakage@1b { > + reg = <0x1b 0x1>; > + }; > + > + npu_leakage: npu-leakage@1c { > + reg = <0x1c 0x1>; > + }; > + > + gpu_leakage: gpu-leakage@1d { > + reg = <0x1d 0x1>; > + }; > + }; > + }; > + > dmac: dma-controller@ff990000 { > compatible = "arm,pl330", "arm,primecell"; > reg = <0x0 0xff990000 0x0 0x4000>;