From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Hao Jia <jiahao.os@bytedance.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] sched/deadline: Remove superfluous rq clock update in push_dl_task()
Date: Fri, 29 Apr 2022 16:30:51 +0200 [thread overview]
Message-ID: <e5931289-fd8c-c4d9-5ec3-c2c9edb1d2c6@redhat.com> (raw)
In-Reply-To: <20220427080014.18483-3-jiahao.os@bytedance.com>
On 4/27/22 10:00, Hao Jia wrote:
> The change to call update_rq_clock() before activate_task()
> commit 840d719604b0 ("sched/deadline: Update rq_clock of later_rq
> when pushing a task") is no longer needed since commit f4904815f97a
> ("sched/deadline: Fix double accounting of rq/running bw in push & pull")
> removed the add_running_bw() before the activate_task().
>
> So we remove some comments that are no longer needed and update
> rq clock in activate_task().
>
> Signed-off-by: Hao Jia <jiahao.os@bytedance.com>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
-- Daniel
prev parent reply other threads:[~2022-04-29 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 8:00 [PATCH v3 0/2] sched/core: Avoid obvious double update_rq_clock warning Hao Jia
2022-04-27 8:00 ` [PATCH v3 1/2] " Hao Jia
2022-04-29 12:59 ` Dietmar Eggemann
2022-04-30 7:24 ` [External] " Hao Jia
2022-04-27 8:00 ` [PATCH v3 2/2] sched/deadline: Remove superfluous rq clock update in push_dl_task() Hao Jia
2022-04-29 14:30 ` Daniel Bristot de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5931289-fd8c-c4d9-5ec3-c2c9edb1d2c6@redhat.com \
--to=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jiahao.os@bytedance.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®