From: "Matias Bjørling" <mb@lightnvm.io>
To: Wei Xu <wxu@cnexlabs.com>
Cc: javier@cnexlabs.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lightnvm: pblk: add CNEX Granby to the pblk device list
Date: Mon, 16 Apr 2018 20:47:26 +0200 [thread overview]
Message-ID: <e595a844-8879-5919-6fc6-8563da666af4@lightnvm.io> (raw)
In-Reply-To: <1523870357-2118-1-git-send-email-wxu@cnexlabs.com>
On 4/16/18 11:19 AM, Wei Xu wrote:
> Add a new lightnvm quirk to identify CNEX’s Granby controller.
>
> Signed-off-by: Wei Xu <wxu@cnexlabs.com>
> ---
> drivers/nvme/host/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index cb73bc8..9419e88 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2529,6 +2529,8 @@ static const struct pci_device_id nvme_id_table[] = {
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE(0x1d1d, 0x2807), /* CNEX WL */
> .driver_data = NVME_QUIRK_LIGHTNVM, },
> + { PCI_DEVICE(0x1d1d, 0x2601), /* CNEX Granby */
> + .driver_data = NVME_QUIRK_LIGHTNVM, },
> { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
> { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2003) },
Hi Wei,
The patch looks good, but the title is not description of the change.
Could the title be changed to "nvme: lightnvm: add granby support".
Also, please send it to the nvme mailing list and CC Keith Busch. It is
a pure NVMe device driver change, and can go directly up through the
NVMe maintainers. I'll add a Reviewed-by: when you've sent it.
-Matias
prev parent reply other threads:[~2018-04-16 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 9:19 Wei Xu
2018-04-16 18:47 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e595a844-8879-5919-6fc6-8563da666af4@lightnvm.io \
--to=mb@lightnvm.io \
--cc=javier@cnexlabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wxu@cnexlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®