From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE8C8451993 for ; Tue, 18 Aug 2026 10:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787049637; cv=none; b=U4sQTfLCbqMugYsZ/IkrOPlAMQu/NwFoI1JKMS6CZPyyWnEY/ZSU7LihSRmvEUd3ImML6w1IYr8xae4GRCkOzqEkHpYpPZn6sWgxug+QPPy6nKssX+YYRssw5vrIYAx/Gp0m+wSWJJInxxCKplrBV9i3I7nxlmrdGIQJf9VMxCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787049637; c=relaxed/simple; bh=JfVZGKTRKN6UKtfQwoLir8mHm6Rec0fxnWe518wunG4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kjf9tMjqAeHkvLGh3WvwZwrL+VRM4N42anWFAnC3xRpnPnxn6GXU7p5svQxWZXrvCDft8548FeFFYPKj9F1LZMg19+qgGYFjHjlLHHGY2DCDsyte3o98ElMtxl2Ax2mZABm9GECkGddszdB0/i7fK7cNmTCJYeV64yRvOeyX4X4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JzBOM1zw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QO5JLabw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JzBOM1zw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QO5JLabw" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IABZrO3979101 for ; Tue, 18 Aug 2026 10:40:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AnH+0QXrWlD6vyCJWXlr8r1LgxYaD69L2S6S9TrvEN8=; b=JzBOM1zwrfzILJEl xiCIDFHgpfHTv2BBYBURZs8BkOGG+iRDla0mPTLH4XPTybkmJtVPRk22Ep2+RIVa Ujc0ktiaFRJGLa/LOVFaCsZdWjTmUUnjSug93/xufxgJKS6StaR1eIMHs9qCVIpQ LbD6jUCEGRdgtFP4SrCe9UtW+IJY2vXGVr2XQ2XwZI/d5VoUnyrFPVj18M/MVJ9w l0AxGI0AdLDcASENkRVPK9u0foU/mKrCp18n614L+2oDF6gNv5WJJGx/UCwfIMFO dnmP3+VoMd1tlalk0Yllb2/PLzkOd6chGtZY2IyMGhGDgV9addMzlsmeabFZV8Wm VnsU4Q== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4ebpt0bm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 10:40:33 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-930bd2bfc45so123071585a.1 for ; Tue, 18 Aug 2026 03:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787049633; x=1787654433; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AnH+0QXrWlD6vyCJWXlr8r1LgxYaD69L2S6S9TrvEN8=; b=QO5JLabwaHz2EkMl5tF6CyxRwEx8bC17DUBJDCtIysJm07XOm27yeMD8zf/ssdu+yw QMnrAA3ar1epbwwYgzFon/zbW/8Y8zYpMWJlVISDIegLzA7H563hH4KIKMyjoFKd9SAj ITX6rQep4y6qUiwuPNjrT0w9e2BUqMGHrLbNsDtlj2FJpiZHkIWcoPmr1XG2gj670weH xkDvvxbb5SLHlJQlFxCsZUBgHWNUe0ndbm7UnkGOzzNWSe42m38EQ+cRL4Zj6YwI5Sh+ Mbj+i1oMYGIWYpu5eewMCaC9hTcjFJ9vzaCryCcGDnE+nE2WzFMwOoeX+O1vKQzSdLYY sWeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787049633; x=1787654433; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AnH+0QXrWlD6vyCJWXlr8r1LgxYaD69L2S6S9TrvEN8=; b=JbRGfrtG4KLdrZpCP2NB7Cf88zB5QeO16VLYBhoXEF+jqJcRb8FYEZG5K5Ih2nQF5a nwNFVT2vH8TxSkDTWVYfrz60PB9taQnno3LazjgAl8JnH7kZrM5N2epFCwzwwBavLq9C 2gSVb9e0txwvSsNzbVU7NOVpuCihRkdiKgwCUfLHX1HMr24etUIUmq0YhWYEcIRSd9rj UIldWpGLORNuw6i0dwu1OQwf9AY2NkV25j+oW901wX76NFYjJB7QMvcz2KVUkx5bUOWG YQ7cjQcwSToHZQC7Vd18Z1AuWes5zSLUnWNCUpVjg+eXH3GPZPZcyBEvIw6CiDJJH4vz KGcQ== X-Forwarded-Encrypted: i=1; AHgh+RqDGDy6bT+9oSfonR+Lum+oe0kMiOrQBxnhwVjf5p0tNZB5uoWk8V1SkTmMx0f0SqYZm95XPRTFPng7gZU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/BqV2hq9Dopz0Zt/a/2aad5j6dZPYKh0XAM9EnDQ2vFvSSIKl SzKAdpn/IXaLHmqHTYI7yaafV3Vcxed0Oq4rZSV7dFUFaNHihAOUUmgEKRGi2xZGQoizvAm9OD7 BSTlNVR85VHUzgCX4a92N6lr+4h99kpwM+en5MNio2kfICa24UNgo9wv8RfUp6/rRkxo= X-Gm-Gg: AR+sD13pbgEhvtV+Z84iVTfUwXwhG6cbEbK1cxLOdwO1KchWIhBjgIW+kpVbz7criD0 pT653bTnNgj3Tk/0+eF0oj7yiPBj7hW//j2OvXGwTxqGcs6/0e6JTHBA0+EvpVbeCEyB9nTZLFy JV5aETMOZe7QEmFkRPXjPm8J82WnXLLnCKnkqBTYFCQ0qZ5DYw3f60XAnN9sKlKzDior51pKWFW oI4NGtpPEtWWMQChQdnUReyw8MIdPp9s5DhaUkco7yT8swuQc2u0N+4ZLO/bGzWjAQ+adHwgV+o Rg3d8DHyt0xRGFGe+Q75TRNlJrLMOFd58Qcy4xt68ESnbVF47qC0ZANCLBlntiPc6N6wUezsT/Z Umq6uwOH2c9A5g2XQuHIxVzdU X-Received: by 2002:a05:620a:1a04:b0:92e:6485:f640 with SMTP id af79cd13be357-936d261aab1mr2297577485a.4.1787049633286; Tue, 18 Aug 2026 03:40:33 -0700 (PDT) X-Received: by 2002:a05:620a:1a04:b0:92e:6485:f640 with SMTP id af79cd13be357-936d261aab1mr2297575285a.4.1787049632914; Tue, 18 Aug 2026 03:40:32 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d85886bcsm1765658a12.16.2026.08.18.03.40.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 03:40:31 -0700 (PDT) Message-ID: Date: Tue, 18 Aug 2026 12:40:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/adreno: fix autosuspend cleanup during teardown To: Guangshuo Li , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20260808131624.2854412-1-lgs201920130244@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260808131624.2854412-1-lgs201920130244@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: VWjtSLIWCCXT5eI_FlyChHuZPBs8iqtK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA3OCBTYWx0ZWRfX0uQNQhItvDRC 7AZ2bBGAAF4Qj4CqBCsFoxCrGuz7QZ7chCkGszktZy/1y5DUHSFsQRUrAp0tfFu+T2jbxNYMUVq aEDFrork668gjxsl+OABqhECR2GeDh+29ezFkJjL0ZjXvOG+QqGzbdL5kpFCYApIc7jsopEBsCG 7usTqzGXUniVVnrpuSjw20QZSKjHsUaKtX2a7XDSpKqbN/5Seg/Yc1VX60tklFIlf7LX9EYdNSW 0HfOCeEwtwdlgb8o+DHrR7yT7q7Mn5Hh5PV7yzUj+g6fDuPFpr3jv0rLm/Z3DPI8xNJKGjWTlLK haV/hOEN1zt7aAmABQwjvjzVMu2opkWC3jFCCt32GBg3dBs5uRqP8AQ71Cv61GIjAjbwEHSp54f SolXpH6xhmorQf48lNVFoUiGJcIWQlzxYh2wMN16nYw8I5frbNjWKhOfeJGw+DxY56gI0nwor4g xkYO8Tk1fxToeGuImpA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA3OCBTYWx0ZWRfX3+H6Wgl/EJvT JGVB0DNqM6zZnnF69wzGp1U713ZgA4wVBKgyGrGZ1ascejPXGLxt/owWxH9A0KL+R783risXvHR I/lAbi1LkZEC5Yz7kdj0fyaan/PEFvI= X-Authority-Analysis: v=2.4 cv=FsU1OWrq c=1 sm=1 tr=0 ts=6a8436a1 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=Sp1j9OMB0jjwDDl5ZD4A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: VWjtSLIWCCXT5eI_FlyChHuZPBs8iqtK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180078 On 8/8/26 3:16 PM, Guangshuo Li wrote: > adreno_gpu_init() calls pm_runtime_use_autosuspend(), but > adreno_gpu_cleanup() does not call the matching > pm_runtime_dont_use_autosuspend() during teardown. > > If the autosuspend delay is set to a negative value while autosuspend > is enabled, the runtime PM core increments usage_count to prevent > runtime suspend. Without calling pm_runtime_dont_use_autosuspend() > during teardown, this reference is not dropped and usage_count remains > unbalanced. > > The documentation for pm_runtime_use_autosuspend() also notes that it > is important to undo it with pm_runtime_dont_use_autosuspend() at > driver exit time, unless runtime PM was initially enabled with > devm_pm_runtime_enable(). > > Add the missing pm_runtime_dont_use_autosuspend() call to > adreno_gpu_cleanup(). > > This issue was found by manual code inspection. > > Fixes: eeb754746b14 ("drm/msm/gpu: use pm-runtime") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- I think we can use devm_pm_runtime_enable() instead, which will take care of cleaning up both the autosuspend and runpm halves Konrad