mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keno Goertz <contact@kenogo.org>
To: John Stultz <jstultz@google.com>
Cc: tglx@linutronix.de, zippel@linux-m68k.org, mingo@elte.hu,
	linux-kernel@vger.kernel.org,
	Miroslav Lichvar <mlichvar@redhat.com>
Subject: Re: ntp: Adjustment of time_maxerror with 500ppm instead of 15ppm
Date: Fri, 9 May 2025 21:40:31 +0200	[thread overview]
Message-ID: <e598eaa0-3b3b-4c16-9d7c-ff35dd150baa@kenogo.org> (raw)
In-Reply-To: <CANDhNCpQLN0j5KBp9OB4LB-YJGCCexFG+v5Zax2wwBn-3Tv3Tw@mail.gmail.com>

Hey!

On 5/8/25 21:45, John Stultz wrote:
> Have you tried a patch introducing PHI (likely setting it to 15000 as
> MAXFREQ is represented as nsec/sec) and using it instead of MAXFREQ in
> the calculation? Do you see any behavioral change in fixing it, or is
> this just a reporting  correctness issue?

I haven't tried a patch, but I couldn't find any place in the kernel 
itself that uses time_maxerror.  So I wouldn't expect behavioral changes 
within the kernel.  Of course, user space applications may depend on the 
values returned by the adjtimex system call.

In fact, I only noticed this behavior in the first place because I am 
writing a distributed time-stamping program and the maxerror reported by 
libc's ntp_gettime (which calls adjtimex on Linux) just felt way too large.

I'm curious to hear what Miroslav might know about other user space 
applications that take an interest in this value.

Best regards
Keno

  reply	other threads:[~2025-05-09 19:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 11:28 Keno Goertz
2025-05-08 19:45 ` John Stultz
2025-05-09 19:40   ` Keno Goertz [this message]
2025-05-09 19:49     ` John Stultz
2025-05-12  8:57   ` Miroslav Lichvar
2025-05-14 10:01     ` Keno Goertz
  -- strict thread matches above, loose matches on Subject: below --
2025-05-07  9:15 Keno Goertz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e598eaa0-3b3b-4c16-9d7c-ff35dd150baa@kenogo.org \
    --to=contact@kenogo.org \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mlichvar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®