From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aurelien Jarno <aurelien@aurel32.net>,
Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lin Jinhan <troy.lin@rock-chips.com>
Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: RNG: Add Rockchip RNG bindings
Date: Mon, 14 Nov 2022 09:33:04 +0100 [thread overview]
Message-ID: <e59bd325-0982-3a20-ed09-d75747c7e659@linaro.org> (raw)
In-Reply-To: <20221112141059.3802506-2-aurelien@aurel32.net>
On 12/11/2022 15:10, Aurelien Jarno wrote:
> Add the RNG bindings for the RK3568 SoC from Rockchip
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> .../devicetree/bindings/rng/rockchip-rng.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rng/rockchip-rng.yaml
>
> diff --git a/Documentation/devicetree/bindings/rng/rockchip-rng.yaml b/Documentation/devicetree/bindings/rng/rockchip-rng.yaml
> new file mode 100644
> index 000000000000..87d80e8ff7f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rng/rockchip-rng.yaml
Filename matching compatible, so "rockchip,rk3568-rng.yaml"
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rng/rockchip,rk-rng.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip TRNG bindings
Drop "bindings"
> +
> +description:
> + This driver interface with the True Random Number Generator present in some
Drop "This driver interface" and make it a proper sentence. Bindings are
not about drivers.
> + Rockchip SoCs.
> +
> +maintainers:
> + - Aurelien Jarno <aurelien@aurel32.net>
> +
> +properties:
> + compatible:
> + oneOf:
It's not a oneOf. Drop.
> + - const: rockchip,rk3568-rng
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + minItems: 2
Drop minItems.
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: clk
> + - const: hclk
You need to explain what are these in clocks. Also you need better
names. A clock name "clk" is useless.
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + items:
> + - const: reset
Drop reset-names entirely, not useful.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-14 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 14:10 [PATCH v1 0/3] hwrng: add hwrng support for Rockchip RK3568 Aurelien Jarno
2022-11-12 14:10 ` [PATCH v1 1/3] dt-bindings: RNG: Add Rockchip RNG bindings Aurelien Jarno
2022-11-13 14:00 ` Rob Herring
2022-11-14 8:33 ` Krzysztof Kozlowski [this message]
2022-11-12 14:10 ` [PATCH v1 2/3] hwrng: add Rockchip SoC hwrng driver Aurelien Jarno
2022-11-12 20:51 ` kernel test robot
2022-11-12 14:10 ` [PATCH v1 3/3] arm64: dts: rockchip: add DT entry for RNG to RK356x Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e59bd325-0982-3a20-ed09-d75747c7e659@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aurelien@aurel32.net \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=olivia@selenic.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=troy.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®