From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711AbdK1Jsi (ORCPT ); Tue, 28 Nov 2017 04:48:38 -0500 Received: from mga02.intel.com ([134.134.136.20]:11442 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbdK1Jsf (ORCPT ); Tue, 28 Nov 2017 04:48:35 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,467,1505804400"; d="scan'208";a="6766059" Subject: Re: v4.14/v4.15-rc1: deferred setup in drm/fb-helper breaks entering pc3 To: Thomas Voegtle Cc: daniel.vetter@ffwll.ch, liviu@dudau.co.uk, john.stultz@linaro.org, treding@nvidia.com, linux-kernel@vger.kernel.org References: <575fff87-908c-c1d6-b504-54ec1f342662@linux.intel.com> From: Maarten Lankhorst Message-ID: Date: Tue, 28 Nov 2017 10:48:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 28-11-17 om 10:30 schreef Thomas Voegtle: > On Tue, 28 Nov 2017, Maarten Lankhorst wrote: > >> Op 27-11-17 om 19:09 schreef Thomas Voegtle: >>> >>> Hello, >>> >>> with v4.14 I recognized that my file server (headless haswell system) >>> doesn't enter packages pc3 anymore and only enters pc2 according to >>> powertop. >>> In v4.13 the system used pc2 and pc3. >>> >>> So I bisected that down to: >>> >>> ca91a2758fcef6635626993557dd51cfbb6dd134 is the first bad commit >>> commit ca91a2758fcef6635626993557dd51cfbb6dd134 >>> Author: Daniel Vetter >>> Date:   Thu Jul 6 15:00:21 2017 +0200 >>> >>>     drm/fb-helper: Support deferred setup >>> >>> >>> Reverting this commit on top of v4.14 and v4.15-rc1 fixes the problem and >>> the system uses package states pc2 and pc3 again. >>> >>> Nothing is connected to the VGA and DVI port. >>> I'm using a kernel without modules on openSUSE 42.3. >>> I have no "vga=xxx" or something like that on the cmdline. >>> >>> >>> Thanks, >>> >>>       Thomas >>> >> Could you send some logs with drm.debug=0x1f ? >> >> ~Maarten > > dmesg attached. Does this work? A log of a working config (4.14 or with revert) would be nice regardless. :) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 07374008f146..6d71ced16f6e 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -1809,6 +1809,7 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper, if (crtc_count == 0 || sizes.fb_width == -1 || sizes.fb_height == -1) { DRM_INFO("Cannot find any crtc or sizes\n"); + restore_fbdev_mode(fb_helper); return -EAGAIN; }