From: "wanghai (M)" <wanghai38@huawei.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: <ericvh@gmail.com>, <lucho@ionkov.net>, <davem@davemloft.net>,
<v9fs-developer@lists.sourceforge.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] 9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work
Date: Fri, 12 Jun 2020 17:22:50 +0800 [thread overview]
Message-ID: <e59d96eb-9ef6-c6c9-2572-a3f219600130@huawei.com> (raw)
In-Reply-To: <20200612091044.GA11129@nautica>
在 2020/6/12 17:10, Dominique Martinet 写道:
> Wang Hai wrote on Fri, Jun 12, 2020:
>> p9_read_work and p9_fd_cancelled may be called concurrently.
>> In some cases, req->req_list may be deleted by both p9_read_work
>> and p9_fd_cancelled.
>>
>> We can fix it by ignoring replies associated with a cancelled
>> request and ignoring cancelled request if message has been received
>> before lock.
>>
>> Fixes: 60ff779c4abb ("9p: client: remove unused code and any reference to "cancelled" function")
>> Reported-by: syzbot+77a25acfa0382e06ab23@syzkaller.appspotmail.com
>> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> Thanks! looks good to me, I'll queue for 5.9 as well unless you're in a
> hurry.
Ok, thanks.
prev parent reply other threads:[~2020-06-12 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 9:08 Wang Hai
2020-06-12 9:10 ` Dominique Martinet
2020-06-12 9:22 ` wanghai (M) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e59d96eb-9ef6-c6c9-2572-a3f219600130@huawei.com \
--to=wanghai38@huawei.com \
--cc=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®