From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752661AbeEOJka (ORCPT ); Tue, 15 May 2018 05:40:30 -0400 Received: from mail-wr0-f180.google.com ([209.85.128.180]:36997 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbeEOJk1 (ORCPT ); Tue, 15 May 2018 05:40:27 -0400 X-Google-Smtp-Source: AB8JxZp22GlG6tg1c2l53pv/XfzNoMNoOzbdZQWVh4MJo4cBt03zqCfGzgPo/HAIBaps7yuFfchw5w== Subject: Re: [PATCH v2 27/29] venus: implementing multi-stream support To: Hans Verkuil , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Vikash Garodia References: <20180515075859.17217-1-stanimir.varbanov@linaro.org> <20180515075859.17217-28-stanimir.varbanov@linaro.org> <3008410e-3311-b836-a6a8-f95f1161a2e9@xs4all.nl> From: Stanimir Varbanov Message-ID: Date: Tue, 15 May 2018 12:40:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <3008410e-3311-b836-a6a8-f95f1161a2e9@xs4all.nl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, On 05/15/2018 11:17 AM, Hans Verkuil wrote: > Hi Stanimir, > > On 05/15/18 09:58, Stanimir Varbanov wrote: >> This is implementing a multi-stream decoder support. The multi >> stream gives an option to use the secondary decoder output >> with different raw format (or the same in case of crop). > > You told me that multi-stream support is currently internal only. > > It would be good if you could elaborate a bit about that in this > commit log and (I think) also add some comments in the code that > reflect this. > > It's also not clear to me how and why this is used in the driver > if this is just internal. Does it enable a feature you would > otherwise not be able to use? > > I have no complaints about the code, I would just like to see a > bit more background information in the source and commit log. Thanks for the fast comments! Sure I will try to document multi-stream support in the patch description and in the code if it makes sense. -- regards, Stan