Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h

[Christophe Leroy <christophe.leroy@csgroup.eu>]

Le 04/03/2024 à 11:32, Thomas Zimmermann a écrit :
> Hi
> 
> Am 04.03.24 um 10:55 schrieb Jani Nikula:
>> Removal of the backlight include from fb.h uncovered an implicit
>> dependency in powerpc asm/backlight.h. Add the explicit include.
>>
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>> Closes: 
>> https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com
>> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in 
>> header")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Helge Deller <deller@gmx.de>
>> Cc: linux-fbdev@vger.kernel.org
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> Not even compile tested!
> 
> That's one of the cases that's hard to catch unless you get the config 
> right.
> 
>> ---
>>   arch/powerpc/include/asm/backlight.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/include/asm/backlight.h 
>> b/arch/powerpc/include/asm/backlight.h
>> index 1b5eab62ed04..275d5bb9aa04 100644
>> --- a/arch/powerpc/include/asm/backlight.h
>> +++ b/arch/powerpc/include/asm/backlight.h
>> @@ -10,6 +10,7 @@
>>   #define __ASM_POWERPC_BACKLIGHT_H
>>   #ifdef __KERNEL__
>> +#include <linux/backlight.h>
> 
> Thanks, but I think this should go directly into chipsfb.c. I would have 
> provided a patch already, if our mail server didn't have issues this 
> morning. Let me try again.

asm/backlight.h needs it for struct backlight_device

At least if you don't want to include linux/backlight.h in 
asm/backlight.h, then you need a forward declaration of struct 
backlight_device;

> 
> Best regards
> Thomas
> 
>>   #include <linux/fb.h>
>>   #include <linux/mutex.h>
>