From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f42.google.com (mail-qk2-f42.google.com [74.125.230.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74562415B79 for ; Mon, 28 Sep 2026 16:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.234 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790612534; cv=none; b=WEn71Ds+uHWR7sG9ZS5IXjJI78LIt7NjB67GeTnh61yFPnOK5Euc0rMiYVrlt0j29CmegiJeGsnN9IrJRxtJDwntfCsIFMKl8gwv3xpX7t/SusXNe6Xq08/9uFUsxqUttn8D4H7eDw6oumLsutpS4W6DOwm9dMIDF0hihQwrCDQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790612534; c=relaxed/simple; bh=WBUMNLsirzlSTr+A8TJzMQ3GDuiW6bCNowDjytQerEQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=merUIS1qiQ0c2i3QdQcLdGUOq/po01P1FgA2tZWR9G/7rve3YB3nnNEqKdQpmlOuDD0JnVW82sJFTW4IO3Ik1kOhDRH0hbF/cEXWKInWPD2386+8vM1MuFlo6mfmqYY8KuchIsrylMM8mb78WCi7sclgoB93pswulpiQqA2hKX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brivo.com; spf=pass smtp.mailfrom=brivo.com; dkim=pass (2048-bit key) header.d=brivo.com header.i=@brivo.com header.b=Jnkv73Lx; arc=none smtp.client-ip=74.125.230.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=brivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=brivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brivo.com header.i=@brivo.com header.b="Jnkv73Lx" Received: by mail-qk2-f42.google.com with SMTP id d75a77b69052e-53320dc09f3so22507901cf.1 for ; Mon, 28 Sep 2026 09:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brivo.com; s=google; t=1790612532; x=1791217332; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=I9iZ745V3O9TQK90r+cmJTPJh5uGbsz3PptJMxIgYsU=; b=Jnkv73LxNJNzjx3EXUAL6KNN1W+3BJ7cdjqY3jqMgrTtmtK4K/jYk2DU1xxvuUlu5y zKCAu2A3nyUvHDg/z2LU6GyEhqD3hAajw4egLCoz/3w0nxY9CZMv9QLYvLd10FCkY+zl T3vGGn+b5Td5JTAc+ga3tmWP3VvX2nCpjIpDZ57I/NeDM9TL5XfqgZk7zH4a1kjJAxWj hJAme6lNT7RXlYX0opuZEgT0CgZQz7lM+VTOQTLLFRm3Do7EmTywGu3HSkNZyNHjNTuH ojETuwKMZA3uOsWoGh0tBz9YEsprRy/7G73SfZIZHg9N0dcoTPiOVQbaH3pNyVxjWd2x 14ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790612532; x=1791217332; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I9iZ745V3O9TQK90r+cmJTPJh5uGbsz3PptJMxIgYsU=; b=e4+3S91Y6eOE/TimpYqfoiOC3iCwLKB0C00ejhaNe1vftAUCbd9mcWBbsC62TFISuS 0HRwubyCNsy1S8GSHuy74ZydO2BZ0NyA7dyxz4JDogaar1qMs89ZyxMetaJQgx9q4qQB XjCmbHg4Um4qe2us6AMYpjvFoYvdsGwh7MwHLUUHqr+cl0isiag/HZOba7Dx2ATcntB0 srra2cy8LzKSrdUglh5hx4uzfs4wN9cfbxcwc/bJ26OjMwuWmqgAdV2gJx1QP7dFERPt RHS003uC7G1MWh/zN0wJrrh5Y0snL2sTtNChcCY5rS6yAnMe9mqS19HolqV7FCbuyzd2 E7sA== X-Forwarded-Encrypted: i=1; AKwUvBwSaB5xoHdQD2f8g+2lneuC5D1eO4rMYYqHJ9qnStD1AJqXFGcdeklvu28v0CF4bNAfJqvvwIUfARFpcEU=@vger.kernel.org X-Gm-Message-State: AFuF++nyh/KiZJdpI5S/fbKSuQtCTG2AIAAn5KXq1spfmPh6nj3DP5Fz dPDJuTBibToXNGw7XgXDYILM5Y4hilBOSvP1Mu8/exWKjQWkYZ8WRPGGgLxEJxcq+7S43BJvayO k3nRobhmESp1EdzVcDl5GIV8GejCFLPVqrZ/qpcy75C75NRz8TnFzEcyGz8o= X-Gm-Gg: AYBFou1RQrd1m5hfDM0dcyJItR0toyONrNTmQCb7Rgxaa1iMyQVgOPa40D+TOtXlia3 4MYrvMBp8CpzB0sd/9snqJEgaSdZpwtuBIl8nLdyWPngsU38jXRJMzzG3+zv7ooLllCSqxqevON 7cdZ0DY2ZnIo0sctRwV2r3n01P47Nytfu2HWaMUR/ShSeGi+UvBoqN21f0+uBagWUbVyUfOBJFv jx6bSnGDPSDdIdhgWbQ8WcBvBvvqb8tQKI/+EbH8+9hRSUyOLMo8hSsCnJwF02rE6CjPVhVv+8S ceSeolFNuteAVmcJ4S360xKezuRpoFTG8xhWzJYumhjgHfAYI1QV5Yal0mA8vFPBz0kh4pmhxzO 7f+ddoVeFXRlwmLmzpImlX3LA3DO5RuBKvAFYKGydPPDZIFfUUV2OTGBkXxQZAkq09kKTWw/wNf dnemNJfWLvmn05iBaTBpTIuUcgcjRaLRc7LpXroUq6g9P2X1e5NiunCOlymVc2PiIb1Wo9gwEbZ W4= X-Received: by 2002:ac8:5c8d:0:b0:533:33c6:e63c with SMTP id d75a77b69052e-53333c6fec4mr122429221cf.16.1790612531895; Mon, 28 Sep 2026 09:22:11 -0700 (PDT) Received: from [10.200.233.210] ([66.193.28.125]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-533223cad4esm65860381cf.24.2026.09.28.09.22.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Sep 2026 09:22:11 -0700 (PDT) Message-ID: Date: Mon, 28 Sep 2026 12:22:11 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mmc: meson-gx: Convert host->lock to raw spinlock To: Ulf Hansson Cc: Ulf Hansson , linux-mmc@vger.kernel.org, Martin Blumenstingl , Neil Armstrong , Kevin Hilman , Heiner Kallweit , linux-arm-kernel@lists.infradead.org, Jerome Brunet , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org References: <20260921191326.2146363-1-sanderson@brivo.com> Content-Language: en-US From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/28/26 12:17 PM, Ulf Hansson wrote: > On Mon, Sep 21, 2026 at 9:14 PM Sean Anderson wrote: >> >> The primary handler for IRQF_ONESHOT interrupts is always run without >> threading, even on PREEMPT_RT. Therefore, we must use a raw spinlock, >> which will never sleep (even on PREEMPT_RT). > > Sorry, but I don't quite understand the above. Are you saying that > IRQF_ONESHOT only works with raw spinlocks? The primary handler of an IRQF_ONESHOT handler must use raw spinlocks. https://www.kernel.org/doc/html/latest/core-api/real-time/differences.html#interrupt-handling > >> >> Fixes: 066ecde6d826 ("mmc: meson-gx: add SDIO interrupt support") >> Signed-off-by: Sean Anderson >> --- >> >> drivers/mmc/host/meson-gx-mmc.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c >> index 694bb443d5f3f..d5365c0404cb9 100644 >> --- a/drivers/mmc/host/meson-gx-mmc.c >> +++ b/drivers/mmc/host/meson-gx-mmc.c >> @@ -176,7 +176,7 @@ struct meson_host { >> >> bool needs_pre_post_req; >> >> - spinlock_t lock; >> + raw_spinlock_t lock; >> }; >> >> #define CMD_CFG_LENGTH_MASK GENMASK(8, 0) >> @@ -953,10 +953,10 @@ static irqreturn_t meson_mmc_irq(int irq, void *dev_id) >> cmd = host->cmd; >> >> if (status & IRQ_SDIO) { >> - spin_lock(&host->lock); >> + raw_spin_lock(&host->lock); >> __meson_mmc_enable_sdio_irq(host->mmc, 0); >> sdio_signal_irq(host->mmc); >> - spin_unlock(&host->lock); >> + raw_spin_unlock(&host->lock); >> status &= ~IRQ_SDIO; >> if (!status) >> return IRQ_HANDLED; >> @@ -1112,9 +1112,9 @@ static void meson_mmc_enable_sdio_irq(struct mmc_host *mmc, int enable) >> struct meson_host *host = mmc_priv(mmc); >> unsigned long flags; >> >> - spin_lock_irqsave(&host->lock, flags); >> + raw_spin_lock_irqsave(&host->lock, flags); >> __meson_mmc_enable_sdio_irq(mmc, enable); >> - spin_unlock_irqrestore(&host->lock, flags); >> + raw_spin_unlock_irqrestore(&host->lock, flags); >> } >> >> static void meson_mmc_ack_sdio_irq(struct mmc_host *mmc) >> @@ -1225,7 +1225,7 @@ static int meson_mmc_probe(struct platform_device *pdev) >> if (ret) >> goto err_init_clk; >> >> - spin_lock_init(&host->lock); >> + raw_spin_lock_init(&host->lock); >> >> if (host->dram_access_quirk) { >> /* Limit segments to 1 due to low available sram memory */ >> --- >> base-commit: 587858367581b9c55c3690f4e63382ad622719d4 >> branch: meson_mmc_raw >> >> -- >> 2.53.0 >>