From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD535C4332F for ; Sun, 5 Nov 2023 23:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjKEXCH (ORCPT ); Sun, 5 Nov 2023 18:02:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjKEXCF (ORCPT ); Sun, 5 Nov 2023 18:02:05 -0500 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CADB5B3 for ; Sun, 5 Nov 2023 15:02:02 -0800 (PST) Received: from [192.168.68.112] (ppp14-2-79-67.adl-apt-pir-bras31.tpg.internode.on.net [14.2.79.67]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id A739120075; Mon, 6 Nov 2023 07:02:00 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1699225321; bh=04hJQYLWQCJ4CRv9lZP5YG9RTCflGKtfQuIl4H68cJI=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=CQY/Yg8tFzkQ/t8U2VI16F8ktZiHrqYp9yZeDdh9PWOedddtBl79Pc7c4BlxqT7v2 GsFrlEGexwSYOP9ozh8142zA5HL2cTdQcza5TUEPGK1/P8AmU8d7bA7elx40t8zGna m/U4svtuVn+5ea/jsEAy9hkO8GTo/u+jRfdwPTGfgBw7LyWUaXRCBe1o/T5MVkUM9I j/HHagzuPjOIonpETGlrOU6YY6OxWpZt2q738n6uT2AC9edhGFsxNzRsqG4rqFMW7z GJwlq0Yp6YDzH3z4fjIq1j6hFPWLwLiT67TstHhcpQokg7/xo4KG0G+PQ2rYcLOPga 0pWkZSFo4mKdg== Message-ID: Subject: Re: [PATCH 07/10] ipmi: kcs_bmc: Disassociate client from device lifetimes From: Andrew Jeffery To: Jonathan Cameron Cc: minyard@acm.org, openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, aladyshev22@gmail.com, jk@codeconstruct.com.au Date: Mon, 06 Nov 2023 09:31:59 +1030 In-Reply-To: <20231103145129.000067d8@Huawei.com> References: <20231103061522.1268637-1-andrew@codeconstruct.com.au> <20231103061522.1268637-8-andrew@codeconstruct.com.au> <20231103145129.000067d8@Huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2023-11-03 at 14:51 +0000, Jonathan Cameron wrote: > On Fri, 3 Nov 2023 16:45:19 +1030 > Andrew Jeffery wrote: >=20 > > KCS client modules may be removed by actions unrelated to KCS devices. > > As usual, removing a KCS client module requires unbinding all client > > instances from the underlying devices to prevent further use of the cod= e. > >=20 > > Previously, KCS client resource lifetimes were tied to the underlying > > KCS device instance with the use of `devm_k[mz]alloc()` APIs. This > > requires the use of `devm_free()` as a consequence. It's necessary to > > scrutinise use of explicit `devm_free()`s because they generally > > indicate there's a concerning corner-case in play, but that's not reall= y > > the case here. Switch to explicit kmalloc()/kfree() to align > > expectations with the intent of the code. > >=20 > > Signed-off-by: Andrew Jeffery > Bit more unrelated white space stuff in here that ideally wouldn't be the= re. Ack, I'll address that for v2. > Otherwise makes sense to me. >=20 > Reviewed-by: Jonathan Cameron Thanks, Andrew