From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2D5528C869 for ; Mon, 23 Feb 2026 16:07:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771862859; cv=none; b=MYsW0e/iR/SrOuC7oD2ZLXblhFjOTf3NX0IT//IcQ2OGPWmWKiE0NEdekS9pYf0g3WCiBUrCAkwkg6z4oKoaBoVH2YAi2XEN9LKIL2wubTLBS2bFyzoT2NKdRZs+RZMQZUparh0aagcfcQkv1/eOvKTf/+lKW5v5T06Dg9wm0kE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771862859; c=relaxed/simple; bh=xnscsEbvGvzAlUJqCsyMT01YFbXTrU6UNc8MiK5cOUw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Pw8icoqEbcQc36AvYD2FBbs0J0rgOEnbP7AuVlbzIZJXv39pRu2Q3pswm4hxnMyVv6RfDKxu0P50MDqCM0CZXfN30zLzjStDwgmG4/TPYUF2huUdYlwYoLtY1WSIMjcqRMH1EPdjlKLA1yIChYbSgK0RxwXZ0QTs1gfMuKRjAw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vuYT8-0006iC-OH; Mon, 23 Feb 2026 17:07:34 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuYT7-002G93-0d; Mon, 23 Feb 2026 17:07:34 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1vuYT8-00000000KqW-1zGN; Mon, 23 Feb 2026 17:07:34 +0100 Message-ID: Subject: Re: [PATCH v2 05/14] reset: warn on reset-gpio release From: Philipp Zabel To: Bartosz Golaszewski , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org Date: Mon, 23 Feb 2026 17:07:34 +0100 In-Reply-To: <20260223-reset-core-refactor-v2-5-5e5a7289190c@oss.qualcomm.com> References: <20260223-reset-core-refactor-v2-0-5e5a7289190c@oss.qualcomm.com> <20260223-reset-core-refactor-v2-5-5e5a7289190c@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Mo, 2026-02-23 at 11:06 +0100, Bartosz Golaszewski wrote: > While we implement an empty .release() callback for reset-gpio (driver > core requires it), this function will never actually be called as nobody > ever removes the device and the last reference is not dropped anywhere. >=20 > This is by design - once created, the reset-gpio device stays in memory. > Make the .release() callback emit a warning, should it ever be called > due to a programming bug. >=20 > Signed-off-by: Bartosz Golaszewski Reviewed-by: Philipp Zabel regards Philipp