From: Markus Elfring <Markus.Elfring@web.de>
To: Peng Hao <richard.peng@oppo.com>, linux-mmc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: Fix use after free in mmc_rpmb_chrdev_release()
Date: Fri, 22 May 2020 11:08:59 +0200 [thread overview]
Message-ID: <e5af0076-7386-c6d9-960a-1b6b29141bfe@web.de> (raw)
> This is caused by dereferencing 'rpmb' after put_device().
I suggest to improve also this change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=051143e1602d90ea71887d92363edd539d411de5#n151
How do you think about a wording variant like the following?
The data structure member “rpmb->md” was passed to a call of
the function “mmc_blk_put” after a call of the function “put_device”.
Reorder these function calls to keep the data accesses consistent.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
reply other threads:[~2020-05-22 9:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5af0076-7386-c6d9-960a-1b6b29141bfe@web.de \
--to=markus.elfring@web.de \
--cc=chaotian.jing@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=richard.peng@oppo.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®