From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB53C61DA4 for ; Thu, 9 Mar 2023 23:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231204AbjCIXjW (ORCPT ); Thu, 9 Mar 2023 18:39:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230095AbjCIXjT (ORCPT ); Thu, 9 Mar 2023 18:39:19 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78610F5A9E; Thu, 9 Mar 2023 15:39:18 -0800 (PST) Received: from mercury (unknown [185.254.75.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1C6146602FA9; Thu, 9 Mar 2023 23:39:16 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678405156; bh=sw0SP7znHcbMaYLFlrdtC+IVpzQcmnkAonuPK990SE8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W/ma3Reoeh8jLwaUGRS9wce6nvdmXYeStCA5md3BjcboEUIUZGvGMcUWjHE61klfl fwe9TpoJLed6W5IVb87jIBPbJYCG39yahdxjZ+o1mcU2uDSLDaUTc3jQHfvfvxkiZj JK6AX4xafOn2sKLIswsp9qL464cRuK+Oz8IE6Vnku8l6/wE9sVB7saE1Nq0LfUpgfU 4wQT4YAoKpXpZWt9HzQspN7j7KdlcGu6IEKbg3QjcShVaOb8j7vOfj0DMKeftw0OdT TSPMZoJwqtncjVZWgkcKHi4v1duRLXmjapqPhaXf+juBDWji2gMmg347q6J7w3jA4g yX2ou+i8OAWjg== Received: by mercury (Postfix, from userid 1000) id 1E448106083C; Fri, 10 Mar 2023 00:39:13 +0100 (CET) Date: Fri, 10 Mar 2023 00:39:13 +0100 From: Sebastian Reichel To: Zheng Wang Cc: support.opensource@diasemi.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com Subject: Re: [PATCH] power: supply: da9150: Fix use after free bug in da9150_charger_remove due to race condition Message-ID: References: <20230309181036.262674-1-zyytlz.wz@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yn5uwxsqlu5pcour" Content-Disposition: inline In-Reply-To: <20230309181036.262674-1-zyytlz.wz@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yn5uwxsqlu5pcour Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 10, 2023 at 02:10:36AM +0800, Zheng Wang wrote: > In da9150_charger_probe, &charger->otg_work is bound with > da9150_charger_otg_work. da9150_charger_otg_ncb may be > called to start the work. >=20 > If we remove the module which will call da9150_charger_remove > to make cleanup, there may be a unfinished work. The possible > sequence is as follows: >=20 > Fix it by canceling the work before cleanup in the mtk_jpeg_remove mtk_jpeg_remove? >=20 > CPU0 CPUc1 >=20 > |da9150_charger_otg_work > da9150_charger_remove | > power_supply_unregister | > device_unregister | > power_supply_dev_release| > kfree(psy) | > | > | power_supply_changed(charger->usb); > | //use > Fixes: c1a281e34dae ("power: Add support for DA9150 Charger") > Signed-off-by: Zheng Wang > --- Looks correct to me, but the cancel_work_sync should happen after usb_unregister_notifier(), otherwise there is still a race condition. -- Sebastian > drivers/power/supply/da9150-charger.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/power/supply/da9150-charger.c b/drivers/power/supply= /da9150-charger.c > index 14da5c595dd9..41b68f2f6ed8 100644 > --- a/drivers/power/supply/da9150-charger.c > +++ b/drivers/power/supply/da9150-charger.c > @@ -642,6 +642,7 @@ static int da9150_charger_remove(struct platform_devi= ce *pdev) > struct da9150_charger *charger =3D platform_get_drvdata(pdev); > int irq; > =20 > + cancel_work_sync(&charger->otg_work); > /* Make sure IRQs are released before unregistering power supplies */ > irq =3D platform_get_irq_byname(pdev, "CHG_VBUS"); > free_irq(irq, charger); > --=20 > 2.25.1 >=20 --yn5uwxsqlu5pcour Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQKbhUACgkQ2O7X88g7 +pozKRAAkt+cogTU0OitcVOC7xKmnQ9usa1JLlbQavCplC7OB37jUPNmMwexLRdn Y+KXwUPBV6RtIAUzqpqfRy5DRxbtTt5j4n1Ibs3l5gV/iuprncTI3tnGC/YMaJrM u89V5+BTW6A6qy1HjcQNFewwwC6GglBy4Upgk6h0rb4MZQxboqZzgRzv8mCmuHZl 7yMQtmrgd7EmSrcPSkevrnVSKaKzHGmSt8KBmgAuMD9Cewhubg9cmr2gg8tHfhAs 11zDQWBIy529qH7zgiwTFssRJ7RTcYrlobEtWKTKvOy/j9ah4s+anB4i/VGmP+lK DjdnBTz63sXZ+eFPqhe0Po96uRlBmGbznP3v9cXtCyWuXdVj1zzsOMUacjJ3RGwj 4o6xlg90id5xKshOyOYF3nHSUYNSz4pOZw+DgdtVMBN/Z/VLVfRVttG2Tf3RzOoW /jR2wqB5FmMWgoxbtDmdCGr62KPOC8Mie22Oklr3IEZaB365CJ9Zwk8uquZJaPdy i2syS0mHxis5n4q7F6B2olckwDLPxYvYrXXcp/cM1HG68ixvWhHsAakyVsHxa9t8 xnaj5fM72lK9SQhL37oFrV15nQ20nwxFhNXlGH0uA3gq5sHI2EDqJuuwkBK/X//A 4PdQ7iJKNADN8ScFnJMwEL3eumT3MhGzWAvw4vzSP9hawR2XEzY= =x/P3 -----END PGP SIGNATURE----- --yn5uwxsqlu5pcour-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C1BDC64EC4 for ; Thu, 9 Mar 2023 23:40:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231269AbjCIXkQ (ORCPT ); Thu, 9 Mar 2023 18:40:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbjCIXkO (ORCPT ); Thu, 9 Mar 2023 18:40:14 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C21F8F14; Thu, 9 Mar 2023 15:40:10 -0800 (PST) Received: from mercury (unknown [185.209.196.169]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6968D6602F6A; Thu, 9 Mar 2023 23:40:09 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1678405209; bh=yus2n4zT7YL65UzDvwPoMrXAkOB+W5gstntm6QHWC30=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lFLdcvl9PVt2oBbymAfYwIiHTQc4EWQE7mkSl2iIr4RFn1G7lJbxOwPAmo4fDVf6R TxrqkLjqix3dzXUk4n2vZMMjoAJINcT21b5HfiLLdwRw+T35RabcnGSzMPhV8HJ1Sx +zGp5rZEGffCjlO09hiuo6lWr/+H+qjID96/fEse7vsAEM9wUEwQcQEW346+LeLV6e COfkFwxdzYmO2bDXoaGTQ7gun737o93DbvqFt+pIqXOduko+b/tVNMd4pV7r5XtFFg 8z+ULGb4WNG9/t6SMPShwmTJb/c9+fP9ELS6Qtrng8/CQbjmw/U53116c7JRr7Q1s/ nz2s1rn2hxF3g== Received: by mercury (Postfix, from userid 1000) id A9751106083C; Fri, 10 Mar 2023 00:40:06 +0100 (CET) Date: Fri, 10 Mar 2023 00:40:06 +0100 From: Sebastian Reichel To: Zheng Wang Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com Subject: Re: [PATCH] power: supply: bq24190: Fix use after free bug in bq24190_remove due to race condition Message-ID: References: <20230309174728.233732-1-zyytlz.wz@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wur4n5pn2pcsi5ms" Content-Disposition: inline In-Reply-To: <20230309174728.233732-1-zyytlz.wz@163.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20230309234006.E2_qJQzZiFzSJSwgPmgkmJOypemqHwvYGH_8TXRg1UQ@z> --wur4n5pn2pcsi5ms Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 10, 2023 at 01:47:28AM +0800, Zheng Wang wrote: > In bq24190_probe, &bdi->input_current_limit_work is bound > with bq24190_input_current_limit_work. When external power > changed, it will call bq24190_charger_external_power_changed > to start the work. >=20 > If we remove the module which will call bq24190_remove to make > cleanup, there may be a unfinished work. The possible > sequence is as follows: >=20 > CPU0 CPUc1 >=20 > |bq24190_input_current_limit_work > bq24190_remove | > power_supply_unregister | > device_unregister | > power_supply_dev_release| > kfree(psy) | > | > | power_supply_get_property_from_supplier > | //use >=20 > Fix it by finishing the work before cleanup in the bq24190_remove >=20 > Fixes: 97774672573a ("power_supply: Initialize changed_work before callin= g device_add") > Signed-off-by: Zheng Wang > --- Thanks, queued to fixes branch. -- Sebastian > drivers/power/supply/bq24190_charger.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/suppl= y/bq24190_charger.c > index be34b9848450..de67b985f0a9 100644 > --- a/drivers/power/supply/bq24190_charger.c > +++ b/drivers/power/supply/bq24190_charger.c > @@ -1906,6 +1906,7 @@ static void bq24190_remove(struct i2c_client *clien= t) > struct bq24190_dev_info *bdi =3D i2c_get_clientdata(client); > int error; > =20 > + cancel_delayed_work_sync(&bdi->input_current_limit_work); > error =3D pm_runtime_resume_and_get(bdi->dev); > if (error < 0) > dev_warn(bdi->dev, "pm_runtime_get failed: %i\n", error); > --=20 > 2.25.1 >=20 --wur4n5pn2pcsi5ms Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmQKblYACgkQ2O7X88g7 +pqTsA/+Og6pqjCTe2UubZ8YbdZXWhRC4T3cM2h5w8pG+wDSmsxIRfyHcqb0rf7t 2YEbjpXi3DSbYvzZ1ceqxv4sJXqE0RpI6J09EYC00RR658QKKR84lSo/RRWLqVej Lk/9M4yvoy7EA7JTARHJxyNifuAik05jP8c7yiN5OfZWWdwZ40BoshSFvKyFUggS rU5sGD8yDRfNpOn3m6PDsdHBTusq+wx8XQZtcBh7zexOIMTa6W5hDy9x4xlP8Vuz sGMETClZfPyQne5oDul/t1rCzekvJ6qIgb6RmS42sYkUb5rm6hxGFMhBgabfakbY TME3RH7TR9/w5rEkBgjTumxy76TdUEOAtOIcYYez2da+Sg8VVUfXf2HsbtNAp/sf nD7VxFAUrFmz8cbMAOkjloVx3qOu/Nk90N+0APwBZTY2B0ObVgNFjlXZB6NEywIv UHrI/V2n3fLMW/nZ1JQXEeUOUTHbg8qqTIy3kc+q+QQ9oDkiXi1Lt5riVmkJfxTm 8uJKVmZ0D+7URdZ/qUNKuueJVA1p30S/kd2pTYibhxIJZztGzXhfR/Fi4xs7YoqA EM6RJ7A0A6CSZD8lma8kpZ3sNUg+1fjHZF+mGCvU/TVebH/lpTDbchbXDBWbqJzm uOj51nj5dTnP7xGJub7hwH5h5GnHS6TLc1gaGxKwIT+FgnbsEf8= =4hNN -----END PGP SIGNATURE----- --wur4n5pn2pcsi5ms--