From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 439452E9ED2 for ; Fri, 24 Oct 2025 07:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761291737; cv=none; b=GFU8HQzHwN+Jk0a/TxEm+MB/zD0X7zO01Kyj9bmOyyCfn0HbWdopfNMzgqhnRMWnP6cL8Vfwkg/PpRPVcJSU7ZeDuCZjTERMtp9rNSrR0Zp2t6gigfh7irLtMiFfBnU1mCUNpfuZo28RaaTJ2U63uTNPohcfDlW6yJYrWf8LUkk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761291737; c=relaxed/simple; bh=qP2/hLBVxN3FJm/O4nmUItT5aATfx/1KfPXyw+Y9EeM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S8/NdWmXM8W+JsaQF+TZ0wcG6poeD6zRA6cn04Nivz5tTZPoTN9LnzuRN8slrwGVa7g+h7PMDAaNhC+JSC+gUM0re7db4+CU8Gbk2T5gBaqohRApDZTVvd+yriybVx4jlsV6lJGpuyMuvUWQd8ihz3Hrb9+Po3O7R2R+eabh/hI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N/IFoA6h; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N/IFoA6h" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59O3FNkc022356 for ; Fri, 24 Oct 2025 07:42:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ujDdSK7F0vmTpCGIcAVVQEeirzSPmezFnb3ovMYte/w=; b=N/IFoA6hqMVmGE0/ /SiF94CHg7Oof/ep2mbOtHozxKBqkhLTch7HcWoThMPHMk+7xttlnWh/kUgBfssu 8x0ZqQhSl1wdbp+6N5LDWic6iHft1nIeUL1T7xJQYvM3NMNfQOVy6lrx6J4BwYRI eShJdhtv763f+HaiqkoO8dDo7e/tQbxXHWB3PTkm0uO4jEZ1oUZpRJqXd7gOFb6N bBEqh3cB59gLfOcNNaIzen64W9fc2TsE6FFZBlUa4oX5vrmH6W7wAo6TJwklKE6t uuZpHsSNeuMSUnD96p7IOspg2z6eI2rPXzcdwv1ZE4T+jFQDU2XGt00n4Z7MmU8f 5SVGLg== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49y67qn6ce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 24 Oct 2025 07:42:12 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7a26c0c057eso1661884b3a.2 for ; Fri, 24 Oct 2025 00:42:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761291732; x=1761896532; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ujDdSK7F0vmTpCGIcAVVQEeirzSPmezFnb3ovMYte/w=; b=DF8RQE/tHMwrYLVZO/M3JL3yDA1Dv+Hovp/ppaCnBVHVHn9+1ZD93BN3fjATiNaNvy k3snhCHPXtYVT1SCdbY+wj+WuSmvOVBjanMAaZfW91ezR008Arq1Wj/44ocO7j2MCHS1 +34dgzE7pjBuxUfAC7/5+uWpdWHvuhkb4RLAilnbQnTwcYM2HRnLt2328VKqLgmRHE1E 5NEVFr6wzx3a86yK85j949sbAyHJZ4TayNzRyAnfVz1gQ69+zvBDUXms1rlqMhotXGXh SuKWXM/tRJyaNRW9dQ4KuUykjYHwPKh42sLdxEidj9zHbda4gvvOv8axI30zJwUm8YMG RjCg== X-Forwarded-Encrypted: i=1; AJvYcCUs79M9KzENhYtOgB5YbGAYFzFJdgKtIv5bxD1ece+rVPkKBoqbmxFRqdseeQxTf6L+cI+MoeCNmsyvV9Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzCuR5LVy6TXP4s5iGLO4szB2PKUXCG7NNneuiRJ0WOedGiggS3 w6x02xUodS4FeF2CN8lCUv4UG8CFyPqikyaqP7BOCiaMmVMXFUMKIJ+nZrUEkTFAuWOZvlOkIu5 AYLp1Zr0rxb+3pEE/YxL4OnIu6X0Z5b3+qMwLbSrEpVUwqtoIstLM2G1sIW0g05Pm7gk= X-Gm-Gg: ASbGncv42BTvW3TZuaYAA4IFW5aagQsq+KENZiO1g7QBBxbvCddeFsyAVlWYnEwlz2C Azu8reJKyOtgsrEeF7alwOJBqIz1hI4fJdcQatfINOcbXZcZKrqOUwDaxTTYbVAXWKpIvh4v7d+ ScGCeQwNB2ciPeVYc/u/zAaQ2Tca1dGuPs+oCf4Twmba2D7GNJjY+EPGhoU0yW+r6RbucAzS2Mi s+32pwMccbLAj5rNBxpcaBPNSAd7kYm8hyxRnKd1cqdGpU+xqR0YsOFQwZmJPoFINyBL6YKKP0b icMTSadxinufQD02keDURIMVlo/glgyxY0Ec7pDg5gVI3QSDtz1japoTQsLDER554y9U+4d9fx4 g4eYfzzUqPigGjDDqU5bwgLQ0ANjDt+SccF1mJVxBeKLgwYUQyDcFGd7ZDPjVFsBcFIxOWg== X-Received: by 2002:a05:6a00:4f89:b0:7a2:7d09:cf40 with SMTP id d2e1a72fcca58-7a27d09d3abmr3935326b3a.9.1761291731640; Fri, 24 Oct 2025 00:42:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGB/pYor8fIltrEjQLCEvB8tf/UTov5v9SzsRwyA8eyQVdoIU2c/LQbw5Wo1KaPqhYAKhDT1g== X-Received: by 2002:a05:6a00:4f89:b0:7a2:7d09:cf40 with SMTP id d2e1a72fcca58-7a27d09d3abmr3935291b3a.9.1761291731164; Fri, 24 Oct 2025 00:42:11 -0700 (PDT) Received: from [10.133.33.160] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a274bb3636sm4943582b3a.61.2025.10.24.00.42.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Oct 2025 00:42:10 -0700 (PDT) Message-ID: Date: Fri, 24 Oct 2025 15:42:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-remoteproc-v1-0-611bf7be8329@oss.qualcomm.com> <20250924-knp-remoteproc-v1-2-611bf7be8329@oss.qualcomm.com> <5820a9a9-4474-4c4d-905c-0efd9442e5e1@oss.qualcomm.com> <540b1de6-c959-4911-925f-8163f5fa5147@oss.qualcomm.com> <7952ed3d-f019-4593-af43-b2df7f738d04@oss.qualcomm.com> <1f98f83f-328f-47c8-84e7-2c77abb37a6a@oss.qualcomm.com> <91288aa0-0088-4b50-8b33-661d8c0c25ae@gmail.com> Content-Language: en-US From: Jingyi Wang In-Reply-To: <91288aa0-0088-4b50-8b33-661d8c0c25ae@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDIyMDE2OCBTYWx0ZWRfX2sjx6K3A0vcq yeg4namCvjol3+NRzlpDttWm+So/mx4p6p7jrIXYy1ljEYM4OaSNWoZ7zHlgstTKJs7/rNMYJMG r0Kgf3id7xA/7E6rEDzmbOVdcl44WPw8Gr5fGyMKz4Ps2nRoE410oeH/J5vuhvTYjSX+bA85GgV Ti+/yjT5ucsKBGmWH22lFZTCTvWWYUNpQAO6nySX0ga1Apx//RuyFPtbBRQ4MnYRCE15+sOlhWF kVNWsuSY4TJnGY3CGXS3iLjtwqkTLuwrrH/VQ54x2BL7GhsUkcBbUqGTOVGr3fXhqWwY7gmW4Pe YmaipPM6Z17BERyjb6Pi3ERJqr+6O6NG+T50LZF7BRKTUhl3jp3uNmSHHVNAtfrPz1zq8mH/3sM +IQf3cr0W0DBNPDTiUaUWiXc9GDgYQ== X-Authority-Analysis: v=2.4 cv=LMRrgZW9 c=1 sm=1 tr=0 ts=68fb2dd4 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=s-QpUPJv85p2Yj6lvi4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: zuyArcT5OGWOkSiMx5Ny0Alu5B976OxY X-Proofpoint-ORIG-GUID: zuyArcT5OGWOkSiMx5Ny0Alu5B976OxY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-23_03,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510220168 On 10/24/2025 3:28 PM, Krzysztof Kozlowski wrote: > On 24/10/2025 04:10, Jingyi Wang wrote: >>>> >>>> Hi Krzysztof， >>>> >>>> I tested with falling back to sm8650 cdsp but it will fail with: >>>> [ 4.739615] qcom_q6v5_pas 26300000.remoteproc: unable to resolve shareable memory-region index 0 >>>> >>>> sm8550 and kaanapali define 2 memory regions: >>>> "memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>;" >>>> >>>> sm8650 and sm8750 define 3 memory regions: >>>> "memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>, <&global_sync_mem>;" >>>> with the driver: >>>> >>>> static const struct qcom_pas_data sm8650_cdsp_resource = { >>>> .crash_reason_smem = 601, >>>> .firmware_name = "cdsp.mdt", >>>> .dtb_firmware_name = "cdsp_dtb.mdt", >>>> <...> >>>> .region_assign_idx = 2, >>>> .region_assign_count = 1, >>>> .region_assign_shared = true, >>>> .region_assign_vmid = QCOM_SCM_VMID_CDSP, >>>> }; >>>> >>>> When kaanapali fallback to sm8650 it cannot parse this region_assign_idx. >>>> >>>> So shall we still fallback to sm8550 or define a new node "kaanapali_cdsp_resource" >>>> in the driver? >>> >>> And partially the point here is that you might need the third region, no? >>> Best regards, >>> Krzysztof >> >> On kaanapali, the global_sync_mem region is not managed by kernel, so it should >> be removed. > > > OK, then please mention this in the commit msg, so it is clear why this > is not compatible with previous generation. > > Best regards, > Krzysztof Sorry for being a bit verbose, but I would like to make it clear that we can still use this fallback if we clarify it in the commit message, right? Thanks, Jingyi