From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbdLSUV1 (ORCPT ); Tue, 19 Dec 2017 15:21:27 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35605 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbdLSUVX (ORCPT ); Tue, 19 Dec 2017 15:21:23 -0500 X-Google-Smtp-Source: ACJfBosc/sRRZs8TW+KFRxPM29VW5FFT+Fco6yi6UCX/eAKTFzerIa2CgrK4CQfjMelpyUPl9ZF6IA== Subject: Re: [PATCH v5 1/6] dt: bindings: lp8860: Update bindings for lp8860 To: Dan Murphy , robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net, pavel@ucw.cz References: <20171218202307.4913-1-dmurphy@ti.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org From: Jacek Anaszewski Message-ID: Date: Tue, 19 Dec 2017 21:20:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171218202307.4913-1-dmurphy@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan, Thanks for the updated patch set. Applied to linux-leds.git. -- Best regards, Jacek Anaszewski On 12/18/2017 09:23 PM, Dan Murphy wrote: > Update the lp8860 bindings to fix various issues > found. Rename enable-gpio to enable-gpios, > update the node name to the device name and > indent the node example. > > Reviewed-by: Rob Herring > Signed-off-by: Dan Murphy > --- > > v5 - Update commit message to remove address and size cells - https://patchwork.kernel.org/patch/10108357/ > > v4 - No changes > v3 - Indicatd enable-gpios is active high, moved address and size cells to child > node patch and updated parent DT node name - https://patchwork.kernel.org/patch/10093745/ > v2 - New patch > > Documentation/devicetree/bindings/leds/leds-lp8860.txt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > index aad38dd94d4b..b9d09acbaa73 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt > +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > @@ -6,22 +6,22 @@ current sinks that can be controlled by a PWM input > signal, a SPI/I2C master, or both. > > Required properties: > - - compatible: > + - compatible : > "ti,lp8860" > - - reg - I2C slave address > - - label - Used for naming LEDs > + - reg : I2C slave address > + - label : Used for naming LEDs > > Optional properties: > - - enable-gpio - gpio pin to enable/disable the device. > - - supply - "vled" - LED supply > + - enable-gpios : gpio pin to enable (active high)/disable the device. > + - vled-supply : LED supply > > Example: > > -leds: leds@6 { > +led-controller@2d { > compatible = "ti,lp8860"; > reg = <0x2d>; > label = "display_cluster"; > - enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; > + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > vled-supply = <&vbatt>; > } > >