From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>, Borislav Petkov <bp@alien8.de>
Cc: Takahiro Itazuri <itazur@amazon.com>,
dave.hansen@linux.intel.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, mingo@redhat.com,
tglx@linutronix.de, x86@kernel.org, zulinx86@gmail.com
Subject: Re: [PATCH 0/2] KVM: x86: Propagate AMD-specific IBRS bits to guests
Date: Mon, 6 Mar 2023 22:25:29 +0100 [thread overview]
Message-ID: <e5bf7da5-df29-31c6-6d33-81bbecb849ba@redhat.com> (raw)
In-Reply-To: <ZAZYKe4L8jhMG4An@google.com>
On 3/6/23 22:16, Sean Christopherson wrote:
>> Not harmless - cpufeatures.h should contain flags which the kernel uses
>> and not*every* CPUID bit out there.
>
> I thought that the consensus was that adding unused-by-the-kernel flags to
> cpufeatures.h is ok so long as the feature is hidden from /proc/cpuinfo and the
> kernel already dedicates a word to the CPUID leaf?
Yeah, I understand adding no new CPUID leaf just for KVM, but you don't
gain anything really from not having X86_FEATURE_* defines.
Paolo
next prev parent reply other threads:[~2023-03-06 21:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 21:05 Takahiro Itazuri
2023-02-27 21:05 ` [PATCH 1/2] x86/cpufeatures: Add AMD-specific IBRS bits Takahiro Itazuri
2023-02-27 21:05 ` [PATCH 2/2] KVM: x86: Propagate AMD-specific IBRS related bits Takahiro Itazuri
2023-02-27 21:40 ` [PATCH 0/2] KVM: x86: Propagate AMD-specific IBRS bits to guests Borislav Petkov
2023-02-28 18:13 ` Takahiro Itazuri
2023-02-28 19:24 ` Borislav Petkov
2023-02-28 19:41 ` Takahiro Itazuri
2023-02-28 20:45 ` Borislav Petkov
2023-02-28 22:24 ` Takahiro Itazuri
2023-02-28 22:50 ` Borislav Petkov
2023-03-06 21:16 ` Sean Christopherson
2023-03-06 21:25 ` Paolo Bonzini [this message]
2023-03-06 21:44 ` Borislav Petkov
2023-03-06 21:47 ` Paolo Bonzini
2023-03-06 21:54 ` Borislav Petkov
2023-03-07 18:49 ` Sean Christopherson
2023-03-07 18:58 ` Borislav Petkov
2023-03-07 19:28 ` Sean Christopherson
2023-03-07 19:55 ` Borislav Petkov
2023-03-06 21:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5bf7da5-df29-31c6-6d33-81bbecb849ba@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=itazur@amazon.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zulinx86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®