From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C2E7C433FF for ; Mon, 29 Jul 2019 12:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9B05206B8 for ; Mon, 29 Jul 2019 12:11:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GTFtRr1b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbfG2MLg (ORCPT ); Mon, 29 Jul 2019 08:11:36 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:45714 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbfG2MLg (ORCPT ); Mon, 29 Jul 2019 08:11:36 -0400 Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 04E6ACC; Mon, 29 Jul 2019 14:11:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1564402293; bh=858qY4EmDwiMBdRHoxTSaL+Ublt1kQgaIWAAkh9Vhz4=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GTFtRr1beIO6Ck5gVW8Jpc6Pz9mR6bbeN0BszzKi3IdNAjsuVO4jiVCqsGsrii/EF H/6DASPoxE07EVkchiHLuLct8aByzOGl3myccmxEn7WAHs74SvFOgI1BP7C0sVyznM fcYvq62vXTR7DOuAhotT10l3nVUeQXUXBu9Gv98Y= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH] media: vsp1: fix memory leak of dl on error return path To: Colin King , Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190728171124.14202-1-colin.king@canonical.com> From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Mon, 29 Jul 2019 13:11:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190728171124.14202-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin, On 28/07/2019 18:11, Colin King wrote: > From: Colin Ian King > > Currently when the call vsp1_dl_body_get fails and returns null the > error return path leaks the allocation of dl. Fix this by kfree'ing > dl before returning. Eeep. This does indeed look to be the case. > > Addresses-Coverity: ("Resource leak") > Fixes: 5d7936b8e27d ("media: vsp1: Convert display lists to use new body pool") > Signed-off-by: Colin Ian King Thank you! Reviewed-by: Kieran Bingham > --- > drivers/media/platform/vsp1/vsp1_dl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c > index 104b6f514536..d7b43037e500 100644 > --- a/drivers/media/platform/vsp1/vsp1_dl.c > +++ b/drivers/media/platform/vsp1/vsp1_dl.c > @@ -557,8 +557,10 @@ static struct vsp1_dl_list *vsp1_dl_list_alloc(struct vsp1_dl_manager *dlm) > > /* Get a default body for our list. */ > dl->body0 = vsp1_dl_body_get(dlm->pool); > - if (!dl->body0) > + if (!dl->body0) { > + kfree(dl); > return NULL; > + } > > header_offset = dl->body0->max_entries * sizeof(*dl->body0->entries); > >