mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: aiyengar1990@gmail.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chen-Yu Tsai <wens@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: allwinner: orangepi-zero2: Reference the SPI NOR by label
Date: Thu, 19 Nov 2026 12:19:21 +0100	[thread overview]
Message-ID: <e5c405ce-0847-41c5-a936-0d8809f90ae0@arm.com> (raw)
In-Reply-To: <20261119-zero2-spi-nor-dual-read-v2-1-185c87065e39@gmail.com>

Hi Arun,

thanks for the changes and the respin!

On 11/19/26 06:29, Arun Iyengar via B4 Relay wrote:
> From: Arun Iyengar <aiyengar1990@gmail.com>
> 
> Andre Przywara suggested labelling the flash node, so the Zero2 sets its
> supply through the label instead of nesting flash@0 in &spi0.
> 
> Suggested-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
> ---
>   arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi |  2 +-
>   arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts | 10 ++++------
>   2 files changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
> index 0d3e761f6466..646d92e0f724 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
> @@ -104,7 +104,7 @@ &spi0 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
>   
> -	flash@0 {
> +	flash: flash@0 {

I feel like "spi_flash" would be a better, more specific label to use, 
"flash" is a bit generic.

>   		#address-cells = <1>;
>   		#size-cells = <1>;
>   		compatible = "jedec,spi-nor";
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> index 90c25e12e189..59bbb09bcdbf 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
> @@ -24,6 +24,10 @@ &emac0 {
>   	phy-supply = <&reg_dcdce>;
>   };
>   
> +&flash {
> +	vcc-supply = <&reg_aldo1>;
> +};
> +

Could you do me a favour and add the OrangePi Zero3 regulator as well, 
to sun50i-h618-orangepi-zero3.dts? It's also reg_aldo1, although that's 
a different PMIC, so actually a different regulator, and so should stay 
in the board specific .dts (even though the lines look the same).
That saves me from sending a follow-up patch with a dependency.

Otherwise the patch looks alright!

Thanks,
Andre.

>   &gpu {
>   	mali-supply = <&reg_dcdcc>;
>   };
> @@ -147,9 +151,3 @@ &pio {
>   	vcc-ph-supply = <&reg_aldo1>;
>   	vcc-pi-supply = <&reg_aldo1>;
>   };
> -
> -&spi0 {
> -	flash@0 {
> -		vcc-supply = <&reg_aldo1>;
> -	};
> -};
> 


  reply	other threads:[~2026-11-19 11:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  5:29 [PATCH v2 0/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay
2026-11-19  5:29 ` [PATCH v2 1/2] arm64: dts: allwinner: orangepi-zero2: Reference the SPI NOR by label Arun Iyengar via B4 Relay
2026-11-19 11:19   ` Andre Przywara [this message]
2026-11-19  5:29 ` [PATCH v2 2/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay
2026-11-19 11:21   ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5c405ce-0847-41c5-a936-0d8809f90ae0@arm.com \
    --to=andre.przywara@arm.com \
    --cc=aiyengar1990@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®