mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Aditya Srivastava <yashsri421@gmail.com>, linux-kernel@vger.kernel.org
Cc: lukas.bulwahn@gmail.com, dwaipayanray1@gmail.com,
	broonie@kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	clang-built-linux@googlegroups.com
Subject: Re: [PATCH] checkpatch: add warning for avoiding .L prefix symbols in assembly files
Date: Wed, 20 Jan 2021 01:21:03 -0800	[thread overview]
Message-ID: <e5c5f8495fbdd063f4272f02a259bbf28b199bdd.camel@perches.com> (raw)
In-Reply-To: <20210120072547.10221-1-yashsri421@gmail.com>

On Wed, 2021-01-20 at 12:55 +0530, Aditya Srivastava wrote:
> Local symbols prefixed with '.L' do not emit symbol table entries, as
> they have special meaning for the assembler.
> 
> '.L' prefixed symbols can be used within a code region, but should be
> avoided for denoting a range of code via 'SYM_*_START/END' annotations.
> 
> Add a new check to emit a warning on finding the usage of '.L' symbols
> in '.S' files, if it lies within SYM_*_START/END annotation pair.

I believe this needs a test for $file as it won't work well on
patches as the SYM_*_START/END may not be in the patch context.

Also, is this supposed to work for local labels like '.L<foo>:'?
I don't think a warning should be generated for those.



  reply	other threads:[~2021-01-20 10:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  7:25 Aditya Srivastava
2021-01-20  9:21 ` Joe Perches [this message]
2021-01-20 12:53   ` Aditya
2021-01-20 18:43     ` Joe Perches
2021-01-20 18:57       ` Nick Desaulniers
2021-01-20 22:59         ` Josh Poimboeuf
2021-01-22 13:18       ` Aditya
2021-01-22 19:10         ` Joe Perches
2021-01-22 20:13           ` Aditya
2021-01-22 20:36             ` Fāng-ruì Sòng
2021-01-23 15:14             ` [PATCH v2] " Aditya Srivastava
2021-01-23 17:21               ` Joe Perches
2021-01-23 18:23                 ` Aditya
2021-01-23 19:04                   ` [PATCH v3] " Aditya Srivastava
2021-01-23 21:01                     ` Joe Perches
2021-01-25 18:15                       ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5c5f8495fbdd063f4272f02a259bbf28b199bdd.camel@perches.com \
    --to=joe@perches.com \
    --cc=broonie@kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=yashsri421@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®