From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAD9F231835 for ; Fri, 24 Jul 2026 22:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784932489; cv=none; b=b6zLeWCh02bThbCISzP8hkdswt7CbPLRqJv9mtKI2Qc0sODyUrwrB7FNmZf4jwaL1dSdoSf2p1oKU+QY4TVnrWPo/HsKyrnVOuXDEfjSuIEPNCk+wfeoFFZA6P+QOIe6wqYg3TUjLOB8VojAzcxYoq0iWTLvCsJAlUJ92qJv7ZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784932489; c=relaxed/simple; bh=Za7tuLG+oJlXVZsNt2T1/1UpnkYjwnuqj8tc1Qh3GaA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LEWeFen9QNhZKh1gCojQmlHp03PTQCwwriH3cRKlslUT988gmglwf7KfWA9OWdNDyRIOeaq/SWZKALGnO4VtvQxaLeG1of6arc1WQe4os1oVZafAgI0mGxmQW7gBe7l9t9NyaNFbZtlBwfLDIz+5cjrjPzc2rjzfBkpNJlsnTxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jnrcCcMm; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jnrcCcMm" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso619989f8f.1 for ; Fri, 24 Jul 2026 15:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784932486; x=1785537286; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Yj67a1DgutWwa9X5sp8V7S4CDf9EKf8IVII2uXmKvNA=; b=jnrcCcMm18y+xKBSRl+eDdk2S1xuoEy45TqgdY6FOhoPXD+gXxndSl6jSy/8TJVFn/ Ai6IxMpiskbbo5Swjv9buKtunqqJfQYSy3U5tTu8kME1aw2Uo9EFKWgrppO2avCsU4lV OmHFLQjFB5wltgT7YUvfxUO3mz1CH1fivgoi/DK5LZhRwig4lQWgUuS07ahySy7sLujo U10GXTCZEBsa3hOoLFmFFP/dJa2PZDhymS4cKUPjowp+NzSpKNJGAQl1SHZOdA4/s6Sg dASlaFsG+4jcCYpt6Q6jkz8aMjSs85a03WoTcx1eJ4l3/4u8QhNtFFFfT6vLkXba+Bee TOBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784932486; x=1785537286; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Yj67a1DgutWwa9X5sp8V7S4CDf9EKf8IVII2uXmKvNA=; b=gAnq3iHDgt4+GoMt9WvWqw1tk6bLrn93eG0x/fZ4niV2DMYv64SCIas3LNwmNw9Lbh oH4JBeiGsGphCGOU5T47kwE7urMp6iUSKhGUzxomfmxfrA4TShiiWIxdyOgeWr0wcfy3 FFSHrsRQvZA70mxDB8bj+XJXQfm45HcZASmVa07jRvls7rPmjptRmXLsVXj8TGNCT8ao sRsEXUa9mfnDdvlAUK95D4QjJLnfsfipBsUzBRMH8oMXIhwfLnjcmGvqTJS8NdfRD8Me InWeF2h7U1+z/Xx/nPmx6cU/6TZE5dOXd4Jp4LV26MrDJNPuhgTLP4jmClRagDm218I/ V/tA== X-Forwarded-Encrypted: i=1; AHgh+RrdbD+wQbDY9Y4xOLGBGblvOQiqJFro1qKcpdHLPQNaZd+fjVTrOxiMZXGdEm1R8fg8O0ypPhGVRLVY4Bg=@vger.kernel.org X-Gm-Message-State: AOJu0YwEEtpRp544LEP3yYZkwWGHqWOplcvLWH1Tl52n7PjlDQbc5Hmy lp+nipvSsFm1C0p96bU6m94hxmU7FUJ+txARJO4ZOyHNv4gcy4i5f09k X-Gm-Gg: AR+sD11RUHg4ZU3ZQZVm4WOzBTkFQxvsEmXKHEcNlcZYVfUM/ZUBqUIkmgUxAlU4ukh I+nThBKmtqcdaQEgmO6ylc6QhV4kZz5SCDUX8SHI8xuRVdDfRwgczP3qEXSPMTGQxHT9tRVxywF ohplOJbF3ESs9MwCl+eVOGlbT+M4sl4B0NKGX02RGeR1fkcBk2JnQ0RRTNNsL0ycGpkjn4wwQNK sPoh7oSFM8Q8841gZSh+qTy5SzSF2cVxWMwoJkHTnZm63hg4bOxpXwl7CyNpdH+7X0YmqaXSZ1U 0A2oHatDL5nheyjzU9B9dgtBH5GkCNsMVBsgzYviQKcwonJwsO+CICzoo6RFsugtYBT+5TH6oPj HQ0EednB6KDp3PMFHbFqQ/viQaDIDB/WFjWQUU42/skR2XQsQ6BZMHTagftkJpdy4Auw/vsgryN dU2B+p7qDn X-Received: by 2002:a05:6000:401e:b0:47f:934a:3029 with SMTP id ffacd0b85a97d-47f9febf056mr87198f8f.60.1784932485890; Fri, 24 Jul 2026 15:34:45 -0700 (PDT) Received: from [192.168.1.50] ([79.118.68.61]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85bd77a9sm26007453f8f.14.2026.07.24.15.34.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 15:34:45 -0700 (PDT) Message-ID: Date: Sat, 25 Jul 2026 01:34:43 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/19] wifi: rtw88: rx: mark zero length packets on RTL8723B To: luka.gejak@linux.dev, Ping-Ke Shih Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Straube , Peter Robinson References: <20260724181858.192903-1-luka.gejak@linux.dev> <20260724181858.192903-3-luka.gejak@linux.dev> Content-Language: en-US From: Bitterblue Smith In-Reply-To: <20260724181858.192903-3-luka.gejak@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/07/2026 21:18, luka.gejak@linux.dev wrote: > From: Luka Gejak > > Like the RTL8703B, the RTL8723B reports receive descriptors with a zero > packet length, which the vendor driver drops outright. rtw88 already > flags these as having no PSDU for the RTL8703B, so extend the same > handling to the RTL8723B rather than passing an empty frame up. > I wonder if this only happens with SDIO? I don't think RTL8723BU does it. > Signed-off-by: Luka Gejak > --- > drivers/net/wireless/realtek/rtw88/rx.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtw88/rx.c b/drivers/net/wireless/realtek/rtw88/rx.c > index 01fd299abb7f..57facbc1b41f 100644 > --- a/drivers/net/wireless/realtek/rtw88/rx.c > +++ b/drivers/net/wireless/realtek/rtw88/rx.c > @@ -253,10 +253,12 @@ static void rtw_rx_fill_rx_status(struct rtw_dev *rtwdev, > > rtw_rx_addr_match(rtwdev, pkt_stat, hdr); > > - /* Rtl8723cs driver checks for size < 14 or size > 8192 and > - * simply drops the packet. > + /* Rtl8723cs and rtl8723bs drivers check for size < 14 or size > 8192 > + * and simply drop the packet. > */ > - if (rtwdev->chip->id == RTW_CHIP_TYPE_8703B && pkt_stat->pkt_len == 0) { > + if ((rtwdev->chip->id == RTW_CHIP_TYPE_8703B || > + rtwdev->chip->id == RTW_CHIP_TYPE_8723B) && > + pkt_stat->pkt_len == 0) { > rx_status->flag |= RX_FLAG_NO_PSDU; > rtw_dbg(rtwdev, RTW_DBG_RX, "zero length packet"); > }