From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 987D513B293 for ; Wed, 17 Dec 2025 15:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765986620; cv=none; b=dOgDwQCAKo/foBnXZvI94ssS7zJdAiJ9gF7Bhxl5EzSzZjA3DblJCqwsrujJKKbQLKRCr+fnkCAN8gGOm0omlht9WWTHQ6q9arZBrN7K1l6tVVidj8iVRqZtWrePjG6mPIRv0ZErDrUg3NP8Hzdeszqd9ybZvwAl6nY3WzCmwf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765986620; c=relaxed/simple; bh=1s+bHStxcwWIMOXM5pPxuiiHoOVEg7LkK+jslEE+r2U=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=P87P06jfifPUmdSCRfhUb9geLST/85CNS6rbYcOKompB2V3eOod4ECGcX+lvgga+IhlkzplEsFdaQa0o6c1RszCbo7pZNcyn5Hc4SfxLk4/T3dgAmMOG6npZYAIxn4BuZ5SjAos/FN0aYcWsJ899L3ViszuU/2p6LFoJJhFuLUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZROMkXAm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hd2/IzSO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZROMkXAm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hd2/IzSO" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHCKn073329725 for ; Wed, 17 Dec 2025 15:50:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /4QUxKEjBHYMFtRD8B12B6GRb83HFUlJRIfmrJQpEwM=; b=ZROMkXAmbm2IsDnI 4ECsX2JKtHVozHxhBLD4PW2offnD/XuZtaBj6Od269XDrVeHRBzGNcWft199wHBz CofjgMh+n24IpVdOcCVuSMZAfEC10SgBkuPNACQQSFnOvnhOwv8GMv0G9acMbnVG f/d6Vmyx+H+F25JYIkUiZBAJbZ5rhkh26OrSj12oG+WaCmRRy7D5qx4CHrmgooNj Lzi1ASxPFxlHR9n2PWGppnMU5ZetYLgzuT8etttd7SJ2YG14xpPZS/Cq58r4PYPA vak21KnCIPzeGCp6cd1znoUfrNxLac9tpD50/GOpkjLB0ajxJ/RrXYa0tDHdXQ3J K5uOAg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3nkkj1td-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 15:50:17 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a0f4822f77so88454955ad.2 for ; Wed, 17 Dec 2025 07:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765986615; x=1766591415; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=/4QUxKEjBHYMFtRD8B12B6GRb83HFUlJRIfmrJQpEwM=; b=hd2/IzSOH93KEs549NNK2Rd4IH+iHs0Zyvjjyfy2QHRngpvMuIUoVZHy72pz/8YWI6 r0fSwXslB3mODrFO3qc4U7F0Px9vyz49U4Zj4SoVEDBFpJIqDUl81o6G+XpvxPd12Ehk bvrLvvHA/+cCzPr0DxrIkMxjzsYwIEng1uLLpOA1tVtd6vb0pBbk9CcwVnKZWiiTLUr9 bxKdKSNMFTUEfUSq+JfCIvDqJR+MaMluJ7Qb04BF1GKf2rk66lh/Ijum4uOlYaSU+uVY a52XcpbVovD9syAm45YuCSTwXapp8efOfwoz1fDb3TnO8lJWHx5RSHg0w9Pe8S5IlKXk r/kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765986615; x=1766591415; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/4QUxKEjBHYMFtRD8B12B6GRb83HFUlJRIfmrJQpEwM=; b=iyD+arDJmXO6tXv02s4q5Q5is2cjtrevP5k942flqSvVbIuwpoYc6gSHs+rNa67nS8 t0WNPEBc7caPtH0FQQiw1vSXr9GlJrFB0z6qeisDrAk0Yv8yDA+maE1FD8yzvrDgKjWb 6eckSxQ0o1C5BsR2hzgoegDzP8LFBK4z05P61g3Sy8jDhfuRLrpvM7qoUqTm6j9b24M5 d5n7UCP0L6pqIZT8A5/0PglYl6MtH4WSOeDb3eBqxaNY+216w+HBF2ad7zHPUb2vXLMN Y/S4GmuJO1o9Rg/yFM8EdOrJuDDHDRkCUjVJS4nTX336cgnEeuSjDdhpRtvYgpAPTzJe adlg== X-Forwarded-Encrypted: i=1; AJvYcCVpiHUoyCy6EzptzAKGkW3L0GZXDphrIwoVj9BbvbbGi4pEy8dDnvF1JLdGR4skLBnWp3yr+swR+N4+nbI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4hJkIwpumdYeWo/gF2F+D6clnPdnJlAzzokRNzLk5hNmX89fG t3adPBtysu8tCJ2ZSyWSZTOpQHdNIaHZraCzfjQfYv7XSSldI/YsTTLsFtiGoTQ8S90dXc6R0Si CCwZA44hFQNHApkrxywqz5zxJ77KonvN15FxyU1Pq+vrpE6fD+46LueGPshfQLpgrGuk= X-Gm-Gg: AY/fxX7MEi1Q2a64OTafliEXCfcHWHaid39RLnF/Khu+l57MWKGSOU3BbHYxqBu75qG LgStS+sFuJAfW618Ho1YrVikQP4UB/aUC5Z6WuMg9xzsTmUQ/zbOGYVll4JpjPcno7KDHtB67W9 Y0bPFH0SXs2kcG/CKeWx6q5FRy+j16p2YVMpeBROdOpVTbnUPooTL4SmiI8rdEyllp22etOp+U0 rU6bDyNvt6TtDQ5s71B6BN0s/QFq/9Wl0BfQmEc5/56ECMU9pylqAVcsOjRQn7PoZ5FA+dxCgxp V34uQvyIYm7diOnOJBkgEIW9qrt82sIodQP7ybxi8nfNqvZonXOj/KIMcLx9qFvsQJJphbLUaXV uuodHNvTJTtCruwuAzorI25xYsNCCDYrmZYZNl7GQv0uc X-Received: by 2002:a17:902:d2ca:b0:29e:9c82:a920 with SMTP id d9443c01a7336-29f23de51d5mr215098135ad.6.1765986614716; Wed, 17 Dec 2025 07:50:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGr/NSSNMw40CeleOvDZ7LwBtVWgIRZm/LTuLHUAln8GG63qNEMGWxH5P9/R2/azpWRzoGFw== X-Received: by 2002:a17:902:d2ca:b0:29e:9c82:a920 with SMTP id d9443c01a7336-29f23de51d5mr215097845ad.6.1765986614252; Wed, 17 Dec 2025 07:50:14 -0800 (PST) Received: from [192.168.1.8] ([106.222.232.223]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0cf143804sm112063765ad.73.2025.12.17.07.50.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 07:50:13 -0800 (PST) Message-ID: Date: Wed, 17 Dec 2025 21:20:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] arm64: dts: qcom: talos: Drop opp-shared from QUP OPP table From: Viken Dadhaniya To: Dmitry Baryshkov , Bjorn Andersson Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@oss.qualcomm.com, dmitry.baryshkov@linaro.org, mukesh.savaliya@oss.qualcomm.com References: <20251111170350.525832-1-viken.dadhaniya@oss.qualcomm.com> <13ea5fd7-b28b-b6c0-752f-a7d4b4677298@oss.qualcomm.com> Content-Language: en-US In-Reply-To: <13ea5fd7-b28b-b6c0-752f-a7d4b4677298@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: wqImrfJn-c8YI4R0Y31mArrCM9aXF2on X-Proofpoint-ORIG-GUID: wqImrfJn-c8YI4R0Y31mArrCM9aXF2on X-Authority-Analysis: v=2.4 cv=f/RFxeyM c=1 sm=1 tr=0 ts=6942d139 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=00/2rs7gRTLD851aB34Rjw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=9lPpWIWHvWp9pA5eUzgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDEyNCBTYWx0ZWRfX+P/GyymLJAI7 gmXtOj3Pv4gGJhmVkDjhjXAx/iUve8GAu+r5Q8CvhNjv3QajZvIL4hTC7JaD+s1pki7Nj+27Lpi DnBdAHD1Gmn+HC4Q0+qANmfAlYOrtiSsi5ParkzB6X9Kulk1MPo0r3BSfnMlFuK3uV0I2ZbzFq1 M1SCsQ7HRRMm5a3FeFkBoxY1RqsHUmjC9vJVdDU9iyoyT02aoJvYgzYXCd/tbgoIaNCKJBujOsq yCmhxrp5Fz3s85MPhgVvyd9tk0PRZTfn74dyfY9bjwbf1EZ/EFkVkTlFaQDDX8Pdp4BeeB9n03i 8sN3gXQOu2EDEm1bxQJHrXA7JybhlgtTMxKMBJIbkx8vBbOKar3vewIXNpljwVWG8IMFlE+YkFU f4TSAhL9dRtD02vaYFc3n0JVOA5+Kg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_03,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170124 Hi Bjorn and Dmitry, On 11/24/2025 3:10 PM, Viken Dadhaniya wrote: > > > On 11/21/2025 5:33 PM, Dmitry Baryshkov wrote: >> On Fri, Nov 21, 2025 at 03:37:21PM +0530, Viken Dadhaniya wrote: >>> >>> >>> On 11/12/2025 1:25 AM, Bjorn Andersson wrote: >>>> On Tue, Nov 11, 2025 at 10:33:50PM +0530, Viken Dadhaniya wrote: >>>>> QUP devices are currently marked with opp-shared in their OPP table, >>>>> causing the kernel to treat them as part of a shared OPP domain. This >>>>> leads to the qcom_geni_serial driver failing to probe with error >>>>> -EBUSY (-16). >>>>> >>>>> Remove the opp-shared property to ensure the OPP framework treats the >>>>> QUP OPP table as device-specific, allowing the serial driver to probe >>>>> successfully >>>>> >>>>> Fixes: f6746dc9e379 ("arm64: dts: qcom: qcs615: Add QUPv3 configuration") >>>> >>>> This was merged 11 months ago, and Yu Zhang added bluetooth support 3 >>>> months ago. What changed to break the QUP users? I think it's reasonable >>>> to use this "Fixes", but we should document - at least on the mailing >>>> list, where the regression happened. >>>> >>>> Regards, >>>> Bjorn >>> >>> I’ve checked the older Linux versions and found that this issue started occurring after the following change: >>> https://lore.kernel.org/linux-devicetree/20250630064338.2487409-1-viken.dadhaniya@oss.qualcomm.com/ >> >> Hmm, but it's your patch. How was it tested? > > For this patch, I had verified only the I²C instance and compared it against other SoCs (like sc7280.dtsi). But missed to validate all other instances from SPI/Serial. > I realized now and will make sure to test all possible nodes in future changes to avoid such gap. > I hope the above information addresses your question. The current change has been validated for the SPI, Serial, and I2C drivers, and it is functioning as expected. Please let us know if you have any further queries. >> >>> >>>> >>>>> Signed-off-by: Viken Dadhaniya >>>>> --- >>>>> arch/arm64/boot/dts/qcom/talos.dtsi | 1 - >>>>> 1 file changed, 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi >>>>> index eb6f69be4a82..ed89d2d509d5 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/talos.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi >>>>> @@ -536,7 +536,6 @@ cdsp_smp2p_in: slave-kernel { >>>>> >>>>> qup_opp_table: opp-table-qup { >>>>> compatible = "operating-points-v2"; >>>>> - opp-shared; >>>>> >>>>> opp-75000000 { >>>>> opp-hz = /bits/ 64 <75000000>; >>>>> -- >>>>> 2.34.1 >>>>> >>