From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Daniel Baluta <daniel.baluta@nxp.com>,
andersson@kernel.org, konradybcio@kernel.org
Cc: dmitry.baryshkov@oss.qualcomm.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, nathan@kernel.org,
imx@lists.linux.dev
Subject: Re: [PATCH v5 3/3] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n
Date: Mon, 17 Aug 2026 09:50:52 +0200 [thread overview]
Message-ID: <e5cfb9fb-d4fd-4563-acc6-9b62e9c95ae0@oss.qualcomm.com> (raw)
In-Reply-To: <20260814141724.1006382-4-daniel.baluta@nxp.com>
On 8/14/26 4:17 PM, Daniel Baluta wrote:
> ubwc_config.c calls qcom_smem_is_available() and qcom_smem_dram_get_hbb()
> unconditionally, so QCOM_UBWC_CONFIG=y with QCOM_SMEM=n fails to link:
>
> arm-linux-gnueabihf-ld: ubwc_config.c:(.text+0x2c): undefined
> reference to 'qcom_smem_is_available'
>
> Add the missing 'depends on QCOM_SMEM'.
>
> Fixes: 1b445022d1d0 ("soc: qcom: ubwc: Get HBB from SMEM")
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-08-17 7:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 14:17 [PATCH v5 0/3] " Daniel Baluta
2026-08-14 14:17 ` [PATCH v5 1/3] drm/msm: Guard the QCOM_UBWC_CONFIG select with QCOM_SMEM Daniel Baluta
2026-08-14 14:36 ` Dmitry Baryshkov
2026-08-14 14:47 ` Dmitry Baryshkov
2026-08-17 7:50 ` Konrad Dybcio
2026-08-14 14:17 ` [PATCH v5 2/3] media: iris: " Daniel Baluta
2026-08-17 7:50 ` Konrad Dybcio
2026-08-14 14:17 ` [PATCH v5 3/3] soc: qcom: ubwc: Fix link error when QCOM_SMEM=n Daniel Baluta
2026-08-17 7:50 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5cfb9fb-d4fd-4563-acc6-9b62e9c95ae0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=imx@lists.linux.dev \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®