From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93AFA18990E for ; Sat, 19 Oct 2024 10:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729332207; cv=none; b=lKSnrvwP4KaMprDDtq5aiAyzqB1XOmkoscms4WCpnHG5d9NCjmJChPSYKIGVgqXVZP+gwWCwdWdzS7HxWfwod4qPTX6FYaRITaWX8uzKDolJ+uRUOnU8a6e2XA8V7Lw0oeJM1N9rvZU0YxR0zbYpNyHBmfVVLpxb1PC+rMT6Krk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729332207; c=relaxed/simple; bh=U7PM/dNz5I96Ba7/XpaFXn/lBSoh0Jw64utHtnjJDCk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FiHZzQlZzOquG9z305Nz72dksnTaBYnScRs0SYAr62epSTz13ymdk+oiNngzPPNIJBXkpmid1YgL4HsIoYUlnuTd6bN2/TABgNWwrqw+CjGuVtFPwY3ZgKxen69rNLAZpqDeZhjA1kyaNjITO2dVzrrjuxh+4FJAeP00sL/d61w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WCiQ0nBG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WCiQ0nBG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729332204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YQdLe7AC4cpIWV8LdUUUTpes6sLRsgEFIkPJaIztUC0=; b=WCiQ0nBGYiKtmcR3oKIXxeNB2qcLYevoFQyThghjm3eqf4k49pW7jy4kqnwsPfvw3K43S1 QRbpZI9k39yeEsBz1PlXy9T19RGoA0zRJbAQMtxznEELtEKIfTn2bY5QqRs4n1GXIfNJeq QSpX6cDm0ykILwc6bL1TRU7iccj7mrU= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-Qq0hpV44NrSZY9kcqJohXw-1; Sat, 19 Oct 2024 06:03:22 -0400 X-MC-Unique: Qq0hpV44NrSZY9kcqJohXw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a9a194d672bso184840666b.2 for ; Sat, 19 Oct 2024 03:03:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729332201; x=1729937001; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YQdLe7AC4cpIWV8LdUUUTpes6sLRsgEFIkPJaIztUC0=; b=NAml6bBtPdvPCmMA9qDJ823ML2bL+NaCupAd4WXam8cz1rKdo/eAZQgO+qBy74o47y oNVw43yWT2ITE3opzvsLMqUBDehL4KMgsnkMp8HTG9S+sjLOEop0okgkxS+UC57YV3Ws fk79NizZsKV7pbldhusxuhvCZmoM3XsU6Xa49w4JhFxQWZVsjrEdA9gk3fWfyifkQfXr 5fsvr8eg5qXqVAcs68Ko84Nb1CAo52XL0XbSsBS0px9aFGAjKwtR421hN8673QUdweCG qS2HzUkQfPMvBuxw74ryyOmai2QVTpaTcz18uBFBKvfWk0GzH1M8k4mhj70e+exVMLib U74w== X-Forwarded-Encrypted: i=1; AJvYcCXuZdB+9LSPs+7E3p4UFdgPgpOVaTpEPiWTngj8Y/5RGszJ8xCRLRnJvTm2DLEprSZQELzJHrAko9j5fLU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0SRjRdqE+Xq7HYh1fsHkd2RWR0fZWtXPb/LddUQz0n/pRETfD ex3Dlv2Vxm0u3zvVRevCbMvxbljUpweqHWyW7NOAtNHT/RvexGvJd+RZCEoiDwbguNBOeqiWoFt 1xnQ69BThj2LXBBLlwRJaHXyAG9T9RX//uP7qUW4M/cdDEksIkyqccWwjup8r3g== X-Received: by 2002:a05:6402:4316:b0:5c8:8381:c1bf with SMTP id 4fb4d7f45d1cf-5ca0ac44799mr3261843a12.3.1729332201566; Sat, 19 Oct 2024 03:03:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaqFk9oqqqSjxjVrweCCXfJF51uwgxJVjHIxKFEkoVNAcG+G/U+1zY6NZd6YvWHHMeB1a3wA== X-Received: by 2002:a05:6402:4316:b0:5c8:8381:c1bf with SMTP id 4fb4d7f45d1cf-5ca0ac44799mr3261828a12.3.1729332201122; Sat, 19 Oct 2024 03:03:21 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ca0b0f96b4sm1657456a12.87.2024.10.19.03.03.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Oct 2024 03:03:20 -0700 (PDT) Message-ID: Date: Sat, 19 Oct 2024 12:03:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] iio: magnetometer; bmc150_magn: Drop most likely fake ACPI IDs To: Andy Shevchenko , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jonathan Cameron , Lars-Peter Clausen References: <20241018145805.2181682-1-andriy.shevchenko@linux.intel.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20241018145805.2181682-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 18-Oct-24 4:58 PM, Andy Shevchenko wrote: > The commits in question do not proove that ACPI IDs exist. > Quite likely it was a cargo cult addition while doing that > for DT-based enumeration. Drop most likely fake ACPI IDs. > > The to be removed IDs has been checked against the following resources: > 1) DuckDuckGo > 2) Google > 3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx > This gives no useful results in regard to DSDT, moreover, the official > vendor IDs in the registry for Bosh are BSG and BOSC. > > Signed-off-by: Andy Shevchenko These HIDs are also not used in my acpidump collection (mostly BYT / CHT models): Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/iio/magnetometer/bmc150_magn_i2c.c | 9 --------- > drivers/iio/magnetometer/bmc150_magn_spi.c | 9 --------- > 2 files changed, 18 deletions(-) > > diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c > index a28d46d59875..17e10a462ac8 100644 > --- a/drivers/iio/magnetometer/bmc150_magn_i2c.c > +++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c > @@ -38,14 +38,6 @@ static void bmc150_magn_i2c_remove(struct i2c_client *client) > bmc150_magn_remove(&client->dev); > } > > -static const struct acpi_device_id bmc150_magn_acpi_match[] = { > - {"BMC150B", 0}, > - {"BMC156B", 0}, > - {"BMM150B", 0}, > - {}, > -}; > -MODULE_DEVICE_TABLE(acpi, bmc150_magn_acpi_match); > - > static const struct i2c_device_id bmc150_magn_i2c_id[] = { > { "bmc150_magn" }, > { "bmc156_magn" }, > @@ -67,7 +59,6 @@ static struct i2c_driver bmc150_magn_driver = { > .driver = { > .name = "bmc150_magn_i2c", > .of_match_table = bmc150_magn_of_match, > - .acpi_match_table = bmc150_magn_acpi_match, > .pm = &bmc150_magn_pm_ops, > }, > .probe = bmc150_magn_i2c_probe, > diff --git a/drivers/iio/magnetometer/bmc150_magn_spi.c b/drivers/iio/magnetometer/bmc150_magn_spi.c > index abc75a05c46a..c850de1bc79b 100644 > --- a/drivers/iio/magnetometer/bmc150_magn_spi.c > +++ b/drivers/iio/magnetometer/bmc150_magn_spi.c > @@ -41,20 +41,11 @@ static const struct spi_device_id bmc150_magn_spi_id[] = { > }; > MODULE_DEVICE_TABLE(spi, bmc150_magn_spi_id); > > -static const struct acpi_device_id bmc150_magn_acpi_match[] = { > - {"BMC150B", 0}, > - {"BMC156B", 0}, > - {"BMM150B", 0}, > - {}, > -}; > -MODULE_DEVICE_TABLE(acpi, bmc150_magn_acpi_match); > - > static struct spi_driver bmc150_magn_spi_driver = { > .probe = bmc150_magn_spi_probe, > .remove = bmc150_magn_spi_remove, > .id_table = bmc150_magn_spi_id, > .driver = { > - .acpi_match_table = bmc150_magn_acpi_match, > .name = "bmc150_magn_spi", > }, > };