Re: [PATCH 1/3] hwmon: scmi: Add default case with debug output

[Guenter Roeck <linux@roeck-us.net>]

On 8/5/25 05:43, a.shimko wrote:
> From: Artem Shimko <artyom.shimko@gmail.com>
> 
> Improve handling of unsupported sensor types:
> - Add default case in sensor type switch statement
> - Log skipped sensors with debug information including:
>    * Sensor ID
>    * Sensor type
>    * Sensor name (if available)
> - Use rate-limited dev_dbg for safety
> 

The code doesn't actually do that, and it would be pointless
and make the message useless.

> Debug output format:
> "Skipping unsupported sensor ID:%d Type:%d (%s)"
> 
> Signed-off-by: Artem Shimko <artyom.shimko@gmail.com>
> ---
>   drivers/hwmon/scmi-hwmon.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> index 364199b332c0..a3b5b5c0ec25 100644
> --- a/drivers/hwmon/scmi-hwmon.c
> +++ b/drivers/hwmon/scmi-hwmon.c
> @@ -275,6 +275,10 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
>   			nr_count[type]++;
>   			break;
>   		}
> +		default:
> +			dev_dbg(dev, "Skipping unsupported sensor ID:%d Type:%d (%s)\n",
> +				i, sensor->type, sensor->name ? sensor->name : "unnamed");
> +			continue;

			break;

>   	}
>   
>   	if (nr_count[hwmon_temp])
> @@ -323,6 +327,10 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
>   			idx = --nr_count[type];
>   			*(scmi_sensors->info[type] + idx) = sensor;
>   			break;
> +		default:
> +			dev_dbg(dev, "Skipping unsupported sensor ID:%d Type:%d (%s)\n",
> +				i, sensor->type, sensor->name ? sensor->name : "unnamed");
> +			continue;

			break;

>   		}
>   	}
>